From 8331dca55bec53838df3aa37acc47fc536056157 Mon Sep 17 00:00:00 2001 From: Stefan Topfstedt Date: Mon, 9 Feb 2026 15:18:57 -0800 Subject: [PATCH] properly namespace components for managing competencies at the school level. --- .../app/components/school-manager.gjs | 8 ++++---- .../competencies-collapsed.gjs} | 0 .../competencies-expanded.gjs} | 8 ++++---- .../competencies-list-item-pcrs.gjs} | 0 .../competencies-list-item.gjs} | 8 ++++---- .../competencies-list.gjs} | 6 +++--- .../competencies-manager.gjs} | 0 .../competencies-pcrs-mapper.gjs} | 0 .../{ => school}/competency-title-editor.gjs | 4 ++-- .../{ => school}/new-competency.gjs | 4 ++-- packages/frontend/app/styles/components.scss | 10 +++++----- .../competencies-collapsed.scss} | 2 +- .../competencies-expanded.scss} | 2 +- .../competencies-list.scss} | 2 +- .../competencies-manager.scss} | 2 +- .../competencies-pcrs-mapper.scss} | 2 +- .../competency-title-editor-test.gjs | 4 ++-- .../competencies-collapsed-test.gjs} | 12 +++++------ .../competencies-expanded-test.gjs} | 10 +++++----- .../competencies-list-item-pcrs-test.gjs} | 20 +++++++++---------- .../competencies-list-item-test.gjs} | 14 ++++++------- .../competencies-list-test.gjs} | 8 ++++---- .../competencies-manager-test.gjs} | 14 ++++++------- .../competencies-pcrs-mapper-test.gjs} | 12 +++++------ .../{ => school}/new-competency-test.gjs | 6 +++--- .../tests/pages/components/school-manager.js | 4 ++-- .../competencies-collapsed.js} | 0 .../competencies-expanded.js} | 4 ++-- .../competencies-list-item-pcrs.js} | 0 .../competencies-list-item.js} | 4 ++-- .../competencies-list.js} | 2 +- .../competencies-manager.js} | 0 .../competencies-pcrs-mapper.js} | 0 .../{ => school}/competency-title-editor.js | 2 +- .../components/{ => school}/new-competency.js | 2 +- 35 files changed, 87 insertions(+), 89 deletions(-) rename packages/frontend/app/components/{school-competencies-collapsed.gjs => school/competencies-collapsed.gjs} (100%) rename packages/frontend/app/components/{school-competencies-expanded.gjs => school/competencies-expanded.gjs} (95%) rename packages/frontend/app/components/{school-competencies-list-item-pcrs.gjs => school/competencies-list-item-pcrs.gjs} (100%) rename packages/frontend/app/components/{school-competencies-list-item.gjs => school/competencies-list-item.gjs} (91%) rename packages/frontend/app/components/{school-competencies-list.gjs => school/competencies-list.gjs} (89%) rename packages/frontend/app/components/{school-competencies-manager.gjs => school/competencies-manager.gjs} (100%) rename packages/frontend/app/components/{school-competencies-pcrs-mapper.gjs => school/competencies-pcrs-mapper.gjs} (100%) rename packages/frontend/app/components/{ => school}/competency-title-editor.gjs (92%) rename packages/frontend/app/components/{ => school}/new-competency.gjs (93%) rename packages/frontend/app/styles/components/{school-competencies-collapsed.scss => school/competencies-collapsed.scss} (87%) rename packages/frontend/app/styles/components/{school-competencies-expanded.scss => school/competencies-expanded.scss} (90%) rename packages/frontend/app/styles/components/{school-competencies-list.scss => school/competencies-list.scss} (97%) rename packages/frontend/app/styles/components/{school-competencies-manager.scss => school/competencies-manager.scss} (92%) rename packages/frontend/app/styles/components/{school-competencies-pcrs-mapper.scss => school/competencies-pcrs-mapper.scss} (86%) rename packages/frontend/tests/integration/components/{school-competencies-collapsed-test.gjs => school/competencies-collapsed-test.gjs} (83%) rename packages/frontend/tests/integration/components/{school-competencies-expanded-test.gjs => school/competencies-expanded-test.gjs} (90%) rename packages/frontend/tests/integration/components/{school-competencies-list-item-pcrs-test.gjs => school/competencies-list-item-pcrs-test.gjs} (91%) rename packages/frontend/tests/integration/components/{school-competencies-list-item-test.gjs => school/competencies-list-item-test.gjs} (92%) rename packages/frontend/tests/integration/components/{school-competencies-list-test.gjs => school/competencies-list-test.gjs} (88%) rename packages/frontend/tests/integration/components/{school-competencies-manager-test.gjs => school/competencies-manager-test.gjs} (93%) rename packages/frontend/tests/integration/components/{school-competencies-pcrs-mapper-test.gjs => school/competencies-pcrs-mapper-test.gjs} (92%) rename packages/frontend/tests/integration/components/{ => school}/new-competency-test.gjs (87%) rename packages/frontend/tests/pages/components/{school-competencies-collapsed.js => school/competencies-collapsed.js} (100%) rename packages/frontend/tests/pages/components/{school-competencies-expanded.js => school/competencies-expanded.js} (83%) rename packages/frontend/tests/pages/components/{school-competencies-list-item-pcrs.js => school/competencies-list-item-pcrs.js} (100%) rename packages/frontend/tests/pages/components/{school-competencies-list-item.js => school/competencies-list-item.js} (75%) rename packages/frontend/tests/pages/components/{school-competencies-list.js => school/competencies-list.js} (83%) rename packages/frontend/tests/pages/components/{school-competencies-manager.js => school/competencies-manager.js} (100%) rename packages/frontend/tests/pages/components/{school-competencies-pcrs-mapper.js => school/competencies-pcrs-mapper.js} (100%) rename packages/frontend/tests/pages/components/{ => school}/competency-title-editor.js (90%) rename packages/frontend/tests/pages/components/{ => school}/new-competency.js (92%) diff --git a/packages/frontend/app/components/school-manager.gjs b/packages/frontend/app/components/school-manager.gjs index 301f080c6f..9cf97e2aff 100644 --- a/packages/frontend/app/components/school-manager.gjs +++ b/packages/frontend/app/components/school-manager.gjs @@ -20,8 +20,8 @@ import LeadershipExpanded from 'ilios-common/components/leadership-expanded'; import { fn } from '@ember/helper'; import LeadershipCollapsed from 'ilios-common/components/leadership-collapsed'; import hasManyLength from 'ilios-common/helpers/has-many-length'; -import SchoolCompetenciesExpanded from 'frontend/components/school-competencies-expanded'; -import SchoolCompetenciesCollapsed from 'frontend/components/school-competencies-collapsed'; +import CompetenciesExpanded from 'frontend/components/school/competencies-expanded'; +import CompetenciesCollapsed from 'frontend/components/school/competencies-collapsed'; import SchoolVocabulariesExpanded from 'frontend/components/school-vocabularies-expanded'; import SchoolVocabulariesCollapsed from 'frontend/components/school-vocabularies-collapsed'; import SchoolSessionTypesExpanded from 'frontend/components/school-session-types-expanded'; @@ -180,7 +180,7 @@ export default class SchoolManagerComponent extends Component { /> {{/if}} {{#if (or (eq @school.competencies.length 0) @schoolCompetencyDetails)}} - {{else}} - diff --git a/packages/frontend/app/components/school-competencies-collapsed.gjs b/packages/frontend/app/components/school/competencies-collapsed.gjs similarity index 100% rename from packages/frontend/app/components/school-competencies-collapsed.gjs rename to packages/frontend/app/components/school/competencies-collapsed.gjs diff --git a/packages/frontend/app/components/school-competencies-expanded.gjs b/packages/frontend/app/components/school/competencies-expanded.gjs similarity index 95% rename from packages/frontend/app/components/school-competencies-expanded.gjs rename to packages/frontend/app/components/school/competencies-expanded.gjs index d3f9610b08..442e7af253 100644 --- a/packages/frontend/app/components/school-competencies-expanded.gjs +++ b/packages/frontend/app/components/school/competencies-expanded.gjs @@ -12,8 +12,8 @@ import FaIcon from '@fortawesome/ember-fontawesome/components/fa-icon'; import perform from 'ember-concurrency/helpers/perform'; import { or } from 'ember-truth-helpers'; import { fn } from '@ember/helper'; -import SchoolCompetenciesManager from 'frontend/components/school-competencies-manager'; -import SchoolCompetenciesList from 'frontend/components/school-competencies-list'; +import CompetenciesManager from 'frontend/components/school/competencies-manager'; +import CompetenciesList from 'frontend/components/school/competencies-list'; import { faArrowRotateLeft, faCaretDown, @@ -190,7 +190,7 @@ export default class SchoolCompetenciesExpandedComponent extends Component {
{{#if @isManaging}} - {{else if this.domains.length}} - + {{/if}}
diff --git a/packages/frontend/app/components/school-competencies-list-item-pcrs.gjs b/packages/frontend/app/components/school/competencies-list-item-pcrs.gjs similarity index 100% rename from packages/frontend/app/components/school-competencies-list-item-pcrs.gjs rename to packages/frontend/app/components/school/competencies-list-item-pcrs.gjs diff --git a/packages/frontend/app/components/school-competencies-list-item.gjs b/packages/frontend/app/components/school/competencies-list-item.gjs similarity index 91% rename from packages/frontend/app/components/school-competencies-list-item.gjs rename to packages/frontend/app/components/school/competencies-list-item.gjs index 22eac2c587..8f1c872a98 100644 --- a/packages/frontend/app/components/school-competencies-list-item.gjs +++ b/packages/frontend/app/components/school/competencies-list-item.gjs @@ -4,8 +4,8 @@ import { action } from '@ember/object'; import { service } from '@ember/service'; import { TrackedAsyncData } from 'ember-async-data'; import { uniqueValues } from 'ilios-common/utils/array-helpers'; -import SchoolCompetenciesListItemPcrs from 'frontend/components/school-competencies-list-item-pcrs'; -import SchoolCompetenciesPcrsMapper from 'frontend/components/school-competencies-pcrs-mapper'; +import CompetenciesListItemPcrs from 'frontend/components/school/competencies-list-item-pcrs'; +import CompetenciesPcrsMapper from 'frontend/components/school/competencies-pcrs-mapper'; export default class SchoolCompetenciesListItemComponent extends Component { @service store; @@ -96,7 +96,7 @@ export default class SchoolCompetenciesListItemComponent extends Component {
{{@competency.title}}
- {{#if this.isManaging}} - {{t "general.aamcPcrs"}} {{#each this.proxies as |proxy|}} - {{#each proxy.competencies as |competency|}} - - + {{#if @canUpdate}} -
+
- - , + , ); assert.strictEqual(component.title.text, 'Competencies (3/4)'); @@ -44,7 +42,7 @@ module('Integration | Component | school competencies collapsed', function (hook this.set('expand', () => assert.step('expand called')); await render( , ); await component.title.click(); diff --git a/packages/frontend/tests/integration/components/school-competencies-expanded-test.gjs b/packages/frontend/tests/integration/components/school/competencies-expanded-test.gjs similarity index 90% rename from packages/frontend/tests/integration/components/school-competencies-expanded-test.gjs rename to packages/frontend/tests/integration/components/school/competencies-expanded-test.gjs index 2707989249..4df5e7f28b 100644 --- a/packages/frontend/tests/integration/components/school-competencies-expanded-test.gjs +++ b/packages/frontend/tests/integration/components/school/competencies-expanded-test.gjs @@ -3,11 +3,11 @@ import { setupRenderingTest } from 'frontend/tests/helpers'; import { render } from '@ember/test-helpers'; import { setupMirage } from 'frontend/tests/test-support/mirage'; import a11yAudit from 'ember-a11y-testing/test-support/audit'; -import { component } from 'frontend/tests/pages/components/school-competencies-expanded'; -import SchoolCompetenciesExpanded from 'frontend/components/school-competencies-expanded'; +import { component } from 'frontend/tests/pages/components/school/competencies-expanded'; +import CompetenciesExpanded from 'frontend/components/school/competencies-expanded'; import noop from 'ilios-common/helpers/noop'; -module('Integration | Component | school competencies expanded', function (hooks) { +module('Integration | Component | school/competencies-expanded', function (hooks) { setupRenderingTest(hooks); setupMirage(hooks); @@ -31,7 +31,7 @@ module('Integration | Component | school competencies expanded', function (hooks this.set('school', schoolModel); await render( ); + await render(); assert.strictEqual(component.items.length, 3); assert.strictEqual(component.items[0].title.text, 'domain 0'); assert.strictEqual(component.items[0].pcrs.items.length, 1); diff --git a/packages/frontend/tests/integration/components/school-competencies-manager-test.gjs b/packages/frontend/tests/integration/components/school/competencies-manager-test.gjs similarity index 93% rename from packages/frontend/tests/integration/components/school-competencies-manager-test.gjs rename to packages/frontend/tests/integration/components/school/competencies-manager-test.gjs index c91f547f56..8eb79c9f16 100644 --- a/packages/frontend/tests/integration/components/school-competencies-manager-test.gjs +++ b/packages/frontend/tests/integration/components/school/competencies-manager-test.gjs @@ -2,11 +2,11 @@ import { module, test } from 'qunit'; import { setupRenderingTest } from 'frontend/tests/helpers'; import { render } from '@ember/test-helpers'; import { setupMirage } from 'frontend/tests/test-support/mirage'; -import { component } from 'frontend/tests/pages/components/school-competencies-manager'; -import SchoolCompetenciesManager from 'frontend/components/school-competencies-manager'; +import { component } from 'frontend/tests/pages/components/school/competencies-manager'; +import CompetenciesManager from 'frontend/components/school/competencies-manager'; import noop from 'ilios-common/helpers/noop'; -module('Integration | Component | school competencies manager', function (hooks) { +module('Integration | Component | school/competencies-manager', function (hooks) { setupRenderingTest(hooks); setupMirage(hooks); @@ -35,7 +35,7 @@ module('Integration | Component | school competencies manager', function (hooks) this.set('competencies', competencies); await render(