[Automation] Support `SingleGoodAllower.AllowedGood` or similar in producers.

[eliptus]

Building like the Water Pump and Lumber Mill only have one possible output. It would be useful to have a property like SingleGoodAllower.AllowedGood for those that could be used with the pre-processor.

Edit: Corrected Water Tank to Water Pump

[ihsoft]

It's already there:

{% (getstr SingleGoodAllower.AllowedGood) %}

[ihsoft]

I think we need a section in Wiki for getnum/getstr with the commonly used things. Feel free to update it: https://github.com/ihsoft/TimberbornMods/wiki/Automation-(scripting)#access-operators

[eliptus]

In my testing this neither works on the Water Pump or Lumber Mill. It only works on storage:

condition: (eq (sig Inventory.OutputGood.{% (getstr SingleGoodAllower.AllowedGood) %}) (sig Inventory.OutputGood.{% (getstr SingleGoodAllower.AllowedGood) %}))
action: (act Signals.Set 'Stockpile.yellow1' (sig Inventory.OutputGood.{% (getstr SingleGoodAllower.AllowedGood) %}))

[ihsoft]

In my testing this neither works on the Water Pump or Lumber Mill. It only works on storage:

It's because the component is only used on stockpiles. Not any building with inventory has a single good allower component. When you start using getXXX methods, you come into the buildings design world. The script only gives you access to the components on them, but you need to know which component does what.

[ihsoft]

Btw, Automation has a tool to print all component on a building. You need to switch to the dev mode to make it visible.

[eliptus]

This was a request to add something similar to SingleGoodAllower.AllowedGood to producers. I guess the answer is that this is just a pass-through to game properties, so I'd need to find an analagous property of producers.

[ihsoft]

You mean, you need a signal that would tell you the currently selected good and trigger when it's changed?

[eliptus]

No, I just need a property that tells me what a building produces that can be used with the preprocessor to create generic import scripts. Just like SingleGoodAllower.AllowedGood is used for storages.

[ihsoft]

What a workshop produces is defined via recipe. Inventory cannot be a reliable source of truth since workshops support multiple recipes, and all the produced goods will be listed as "output" in the inventory. So, there is no such thing as "allowed good" when it comes to workshops. What is the use case you're trying to address?

[eliptus]

Sorry, but I feel like I'm repeating myself here. The purpose is to make generic import scripts.

I keep referring to SingleGoodAllower.AllowedGood as an example, since you and others have used it as such. The goal is simply to be able to apply the same utility to buildings that simply produce one output. It doesn't have to be SingleGoodAllower.AllowedGood, just something similar.

I don't know how to provide a simpler example than the Water Pump and Lumber Mill. They each only produce one good. Being able to get the good id in the preprocessor means I don't have to maintain two separate scripts.

[ihsoft]

Sorry, but I feel like I'm repeating myself here. The purpose is to make generic import scripts.

My questions was more like "give me exact code which you're trying to build". There is a chance you may be looking in a wrong direction, and I can point the right one. Or take it as a valid use-case, and add the support.

Btw, have you tried this? It works just fine with any one-output building. It's how the emptying template is made.

(gt (sig Inventory.OutputGood.{% (getstr Inventory.OutputGoods 0) %}) 0)

It won't give good results on a multi-recipe building, though. Are you looking for such buildings too?

[eliptus]

Sorry, but I feel like I'm repeating myself here. The purpose is to make generic import scripts.

My questions was more like "give me exact code which you're trying to build". There is a chance you may be looking in a wrong direction, and I can point the right one. Or take it as a valid use-case, and add the support.

I've become reluctant to give exact code examples because you tend to hyperfocus on the example and ignore the larger picture.

I provided an example in #110 (comment), which I hypothetically wanted to apply to my Water Pump, but your simply responded that "the component is only used on stockpiles". This issue already acknowledges that this component is only used on stockpiles and I'm looking for something equivalent for producers.

Btw, have you tried this? It works just fine with any one-output building. It's how the emptying template is made.

(gt (sig Inventory.OutputGood.{% (getstr Inventory.OutputGoods 0) %}) 0)

No, I have not tried this because it hadn't been suggested, I haven't seen any such example, and I haven't decompiled the game to figure out what components exist yet.

In #110 (comment), I've acknowledged that I need to find what equivalent component is available for producers, but these aren't documented and I don't have decompiled game code for reference.

It won't give good results on a multi-recipe building, though. Are you looking for such buildings too?

Eventually.

[ihsoft]

I've become reluctant to give exact code examples because you tend to hyperfocus on the example and ignore the larger picture.

It may look "a larger picture" for you, but before I start working on it, I need to be convinced it is the large picture for me. Don't you think it's fair? I build my "pictures" by having the real life use-cases. I don't have enough spare time to implement a support for the features that will be used by 1-2 persons only. A pair of hands and 24 hours per a day is all I have. And I don't want to just reject any suggestion either! Tell me your task, I'll think if (how) it can be solved.

I haven't decompiled the game

1. If you don't know much knowledge about the game, I'd suggest starting from the existing tool blueprints studying. They are not for a regular player of TB, but you're definitely not a regular player :) The script code inside is a plain text. You don't need to understand the JSON file semantics.
2. Any get operator use would require you to understand the game. Sorry, nothing I can do here. This operator was made for those who knows the game. You can copy/paste the usage from the templates, but this may have side effects.