useEffectAsync doesn't support cleanup function.

[platoonic]

Hey.
Nice work with the library! Though useEffect is supposed to return a function as an equivalent to componentDidUnmount, this doesn't seem to be the case with useEffectAsync since the API you've provided doesn't allow passing a function for cleanup.

[ihabshea]

Hello,
Have you tried adding a return function with your cleanup operations like this:
return ( () => { unsubscribe(); });

[platoonic]

I haven't tried it yet tbh but looking how useEffectAsync is implemented, it doesn't seem to be handling the unmounting phase at all.

export default function useEffectAsync(effect, inputs) {
    useEffect(() => {
        effect();
    }, inputs);
}

Thing is, adding a line like this:

return effect();

Will trigger the same problem of useEffect not supporting a non-functional return type since it's returning a promise object. I think there should be some sort of API that handles passing those cleanup functions, one that's different from how the original useEffect handles it.
This package for example takes cleanup function as a second optional argument in its useAsyncEffect hook:
https://github.com/rauldeheer/use-async-effect