`through` association is not supported

[tamaskamaras]

Description

Time-travel uses the present object of the through association.

ref: #295

Models

class ActivityStep < ApplicationRecord
  include ChronoModel::TimeMachine

  belongs_to :activity_roadmap
end

class ActivityRoadmap < ApplicationRecord
  include ChronoModel::TimeMachine

  has_many :activity_steps, dependent: :destroy, inverse_of: :activity_roadmap
  belongs_to :activity_lot, optional: true
end

class ActivityLot < ApplicationRecord
  include ChronoModel::TimeMachine

  has_one :activity_roadmap, dependent: :destroy
  has_many :activity_steps, through: :activity_roadmap
end

Seeds

activity_lot = ActivityLot.create!
activity_roadmap1 = ActivityRoadmap.create!(activity_lot: activity_lot)
activity_step1 = ActivityStep.create!(activity_roadmap: activity_roadmap1)

Output in the present

CORRECT ✔️

activity_lot.activity_steps.ids
=> [111]

Creating a new :through Object

activity_roadmap1.destroy!
activity_roadmap2 = ActivityRoadmap.create!(activity_lot: activity_lot)
activity_step2 = ActivityStep.create!(activity_roadmap: activity_roadmap2)

Output in the present

CORRECT ✔️

activity_lot.activity_steps.ids
=> [222]

Output in history

WRONG ❌

activity_lot.as_of(1.second.ago).activity_steps.ids
=> []

Expected: [111] (the historical ids)

[tagliala]

This is not failing on master

Test (AI generated)

# frozen_string_literal: true

require 'bundler/inline'

gemfile(true) do
  source 'https://rubygems.org'

  # Test against latest Chronomodel:
  # gem 'chrono_model', github: 'ifad/chronomodel'

  gem 'activerecord'
  gem 'multi_json'
  gem 'pg'
end

require_relative 'lib/chrono_model'
require 'minitest/autorun'
require 'logger'

# Needs a database called `chronomodel_test`

ActiveRecord::Base.establish_connection(adapter: 'chronomodel', database: 'chronomodel_test')
ActiveRecord::Base.logger = Logger.new($stdout)

ActiveRecord::Schema.define do
  enable_extension :btree_gist

  create_table :activity_lots, force: true, temporal: true do |t|
    t.timestamps
  end

  create_table :activity_roadmaps, force: true, temporal: true do |t|
    t.integer :activity_lot_id
    t.timestamps
  end

  create_table :activity_steps, force: true, temporal: true do |t|
    t.integer :activity_roadmap_id
    t.timestamps
  end
end

class ActivityStep < ActiveRecord::Base
  include ChronoModel::TimeMachine

  belongs_to :activity_roadmap
end

class ActivityRoadmap < ActiveRecord::Base
  include ChronoModel::TimeMachine

  has_many :activity_steps, dependent: :destroy, inverse_of: :activity_roadmap
  belongs_to :activity_lot, optional: true
end

class ActivityLot < ActiveRecord::Base
  include ChronoModel::TimeMachine

  has_one :activity_roadmap, dependent: :destroy
  has_many :activity_steps, through: :activity_roadmap
end

class BugTest < Minitest::Test
  def test_through_association_time_travel
    # Create initial records
    activity_lot = ActivityLot.create!
    activity_roadmap1 = ActivityRoadmap.create!(activity_lot: activity_lot)
    activity_step1 = ActivityStep.create!(activity_roadmap: activity_roadmap1)

    # Verify present state is correct
    assert_equal [activity_step1.id], activity_lot.activity_steps.ids,
      "Present state should show activity_step1"

    # Capture timestamp and lot id before changes
    lot_id = activity_lot.id
    timestamp_before_change = Time.now

    # Sleep to ensure temporal difference
    sleep 2

    # Destroy the first roadmap and create a new one
    activity_roadmap1.destroy!
    activity_roadmap2 = ActivityRoadmap.create!(activity_lot: activity_lot)
    activity_step2 = ActivityStep.create!(activity_roadmap: activity_roadmap2)

    # Verify new present state is correct
    assert_equal [activity_step2.id], activity_lot.activity_steps.ids,
      "Present state should show activity_step2"

    # BUG: Time-travel should return historical activity_steps
    # Need to fetch the historical version of activity_lot
    historical_lot = ActivityLot.as_of(timestamp_before_change).find(lot_id)
    historical_ids = historical_lot.activity_steps.ids

    assert_equal [activity_step1.id], historical_ids,
      "EXPECTED: Historical state should show activity_step1 [#{activity_step1.id}], " \
      "but GOT: #{historical_ids.inspect}. " \
      "This demonstrates that `through` association is not supported in time-travel."
  end
end

master

Finished in 2.044324s, 0.4892 runs/s, 1.4675 assertions/s.

1 runs, 3 assertions, 0 failures, 0 errors, 0 skips

4.0.0

Finished in 2.055787s, 0.4864 runs/s, 1.4593 assertions/s.

  1) Failure:
BugTest#test_through_association_time_travel [test390.rb:95]:
EXPECTED: Historical state should show activity_step1 [1], but GOT: []. This demonstrates that `through` association is not supported in time-travel..
Expected: [1]
  Actual: []

1 runs, 3 assertions, 1 failures, 0 errors, 0 skips

This has been apparently fixed via 0b0546c