From db4e374af3ce278b1c2fb8283f7394f3cdfad727 Mon Sep 17 00:00:00 2001 From: Kristin Merbach Date: Tue, 17 Mar 2026 08:06:19 -0700 Subject: [PATCH 01/19] assister remove training, rename to organization, nice pundit messages --- .../insured/families_controller.rb | 4 ++++ .../exchanges/bulk_notices/preview.html.erb | 2 +- .../assisters/_assister_fields.html.erb | 4 ---- .../_attestation_agreement_fields.html.erb | 8 ------- .../v1/navs/_primary_nav.html.erb | 3 ++- .../profiles/registrations_controller.rb | 2 +- .../forms/assister_candidate.rb | 4 ++-- .../services/staff_role_service.rb | 8 +++---- .../_assister_registration_form.html.erb | 5 +---- .../forms/assister_candidate_spec.rb | 14 ++++++------ .../translations/en/dc/assister_agencies.rb | 22 +++++++++---------- .../translations/en/me/assister_agencies.rb | 22 +++++++++---------- db/seedfiles/translations/en/me/shared.rb | 1 + db/seedfiles/translations/en/me/user_roles.rb | 2 +- 14 files changed, 46 insertions(+), 55 deletions(-) delete mode 100644 app/views/ui-components/bs4/v1/forms/assister/_attestation_agreement_fields.html.erb diff --git a/app/controllers/insured/families_controller.rb b/app/controllers/insured/families_controller.rb index e424c03b979..ac71e229c1f 100644 --- a/app/controllers/insured/families_controller.rb +++ b/app/controllers/insured/families_controller.rb @@ -525,6 +525,8 @@ def delete_consumer_broker else redirect_to :action => "home", flash: {notice: "Unable to remove expert from this account"} end + rescue Pundit::NotAuthorizedError + redirect_to request.referrer, flash: {error: l10n("not_authorized")} end def delete_consumer_assister @@ -539,6 +541,8 @@ def delete_consumer_assister else redirect_to :action => "home", flash: {notice: "Unable to remove expert from this account"} end + rescue Pundit::NotAuthorizedError + redirect_to request.referrer, flash: {error: l10n("not_authorized")} end def transition_family_members diff --git a/app/views/exchanges/bulk_notices/preview.html.erb b/app/views/exchanges/bulk_notices/preview.html.erb index ec1c7741a0e..b42482f0341 100644 --- a/app/views/exchanges/bulk_notices/preview.html.erb +++ b/app/views/exchanges/bulk_notices/preview.html.erb @@ -66,7 +66,7 @@ Important:

<%= l10n("admin_actions.bulk_upload.new.description_sub_text") %>

<%= form_for(@bulk_notice, url: exchanges_bulk_notice_path(@bulk_notice)) do |f| %> - <%= f.select :audience_type, { 'Broker Agency' => :broker_agency, 'Assister Agency' => :assister_agency, 'Employer' => :employer, 'General Agency' => :general_agency, 'Employee' => :employee }, { selected: @bulk_notice.audience_type }, class: 'form-control col-2', data: { reflex: 'change->BulkNotice#audience_select' } %> + <%= f.select :audience_type, { 'Broker Agency' => :broker_agency, 'Assister Organization' => :assister_agency, 'Employer' => :employer, 'General Agency' => :general_agency, 'Employee' => :employee }, { selected: @bulk_notice.audience_type }, class: 'form-control col-2', data: { reflex: 'change->BulkNotice#audience_select' } %> diff --git a/app/views/shared/assisters/_assister_fields.html.erb b/app/views/shared/assisters/_assister_fields.html.erb index 568f1d9bd35..4531e165e4c 100644 --- a/app/views/shared/assisters/_assister_fields.html.erb +++ b/app/views/shared/assisters/_assister_fields.html.erb @@ -39,10 +39,6 @@
<%= f.fields_for :assister_role do |assister_role_fields| %> <% disabled = assister_or_staff_role.active? ? true : false %> - <%= assister_role_fields.text_area :reason, placeholder: "#{l10n('write_here')}...", rows: 6, disabled: disabled, id: "reason", class:"w-100" %> <% end %> diff --git a/app/views/ui-components/bs4/v1/forms/assister/_attestation_agreement_fields.html.erb b/app/views/ui-components/bs4/v1/forms/assister/_attestation_agreement_fields.html.erb deleted file mode 100644 index ba2da941f32..00000000000 --- a/app/views/ui-components/bs4/v1/forms/assister/_attestation_agreement_fields.html.erb +++ /dev/null @@ -1,8 +0,0 @@ -

<%= l10n("agreements") %>

- -
- <%= check_box_tag :all_marketplace_required_trainings, nil, false, class: "assister-attestation-field" %> - -
\ No newline at end of file diff --git a/app/views/ui-components/v1/navs/_primary_nav.html.erb b/app/views/ui-components/v1/navs/_primary_nav.html.erb index 7a0e5aac368..f3cc63db578 100644 --- a/app/views/ui-components/v1/navs/_primary_nav.html.erb +++ b/app/views/ui-components/v1/navs/_primary_nav.html.erb @@ -73,7 +73,8 @@ <% end %> diff --git a/components/benefit_sponsors/app/controllers/benefit_sponsors/profiles/registrations_controller.rb b/components/benefit_sponsors/app/controllers/benefit_sponsors/profiles/registrations_controller.rb index cff692c2832..cc62ec68644 100644 --- a/components/benefit_sponsors/app/controllers/benefit_sponsors/profiles/registrations_controller.rb +++ b/components/benefit_sponsors/app/controllers/benefit_sponsors/profiles/registrations_controller.rb @@ -83,7 +83,7 @@ def update flash[:notice] = 'Employer successfully Updated.' if is_employer_profile? flash[:notice] = 'Broker Agency Profile successfully Updated.' if is_broker_profile? flash[:notice] = 'General Agency Profile successfully Updated.' if is_general_agency_profile? - flash[:notice] = 'Assister Agency Profile successfully Updated.' if is_assister_profile? + flash[:notice] = 'Assister Organization Profile successfully Updated.' if is_assister_profile? else org_error_msg = @agency.errors.full_messages.join(",").humanize if @agency.errors.present? diff --git a/components/benefit_sponsors/app/models/benefit_sponsors/forms/assister_candidate.rb b/components/benefit_sponsors/app/models/benefit_sponsors/forms/assister_candidate.rb index 15058a62dc6..c72a9aace0a 100644 --- a/components/benefit_sponsors/app/models/benefit_sponsors/forms/assister_candidate.rb +++ b/components/benefit_sponsors/app/models/benefit_sponsors/forms/assister_candidate.rb @@ -71,9 +71,9 @@ def match_or_create_person def validate_assister_agency if self.assister_agency_id.blank? - errors.add(:base, "Please select your assister agency.") + errors.add(:base, "Please select your assister organization.") elsif BenefitSponsors::Organizations::AssisterAgencyProfile.find(self.assister_agency_id).blank? - errors.add(:base, "Unable to locate the assister agnecy. Please contact HBX.") + errors.add(:base, "Unable to locate the assister organization. Please contact HBX.") end end diff --git a/components/benefit_sponsors/app/models/benefit_sponsors/services/staff_role_service.rb b/components/benefit_sponsors/app/models/benefit_sponsors/services/staff_role_service.rb index a5568feb891..95f3bb48381 100644 --- a/components/benefit_sponsors/app/models/benefit_sponsors/services/staff_role_service.rb +++ b/components/benefit_sponsors/app/models/benefit_sponsors/services/staff_role_service.rb @@ -137,9 +137,9 @@ def persist_assister_agency_staff_role!(profile) terminated_assisters_with_same_profile.assister_agency_pending! [true, person] elsif pending_assisters_with_same_profile.present? - [false, "your application status was in pending with this Assister Agency"] + [false, "your application status was in pending with this Assister Organization"] elsif active_assisters_with_same_profile.present? - [false, "you are already associated with this Assister Agency"] + [false, "you are already associated with this Assister Organization"] else person.assister_agency_staff_roles << ::AssisterAgencyStaffRole.new({assister_agency_profile: profile}) person.save! @@ -289,10 +289,10 @@ def deactivate_assister_agency_staff_role(person_id, assister_agency_profile_id) (role.benefit_sponsors_assister_agency_profile_id.to_s || role.assister_agency_profile_id.to_s) == assister_agency_profile_id.to_s && role.is_open? end - return false, 'No matching Assister Agency Staff role' if assister_agency_staff_role.blank? + return false, 'No matching Assister Organization Staff role' if assister_agency_staff_role.blank? assister_agency_staff_role.assister_agency_terminate! - [true, 'Assister Agency Staff Role is inactive'] + [true, 'Assister Organization Staff Role is inactive'] end def deactivate_general_agency_staff_role(person_id, general_agency_profile_id) diff --git a/components/benefit_sponsors/app/views/benefit_sponsors/profiles/registrations/_assister_registration_form.html.erb b/components/benefit_sponsors/app/views/benefit_sponsors/profiles/registrations/_assister_registration_form.html.erb index 053ecdc5ca1..b093ce73538 100644 --- a/components/benefit_sponsors/app/views/benefit_sponsors/profiles/registrations/_assister_registration_form.html.erb +++ b/components/benefit_sponsors/app/views/benefit_sponsors/profiles/registrations/_assister_registration_form.html.erb @@ -16,9 +16,6 @@ <%= render partial: "benefit_sponsors/shared/profiles/broker_agency/bank_information", locals: {f: f} %> <% end %> <%= render partial: './ui-components/bs4/v1/forms/broker/contact_information/contact_info_fields', locals: { f: f, registration: true } %> - <% if EnrollRegistry.feature_enabled?(:broker_attestation_fields) %> - <%= render partial: './ui-components/bs4/v1/forms/assister/attestation_agreement_fields' %> - <% end %> <% if (aca_broker_routing_information && @agency.profile_type == "broker_agency") %>
<%= l10n("broker_agencies.broker_roles.broker_registration_text", site_short_name: site_short_name, site_brokers_agreement_path: site_brokers_agreement_path) %> @@ -29,7 +26,7 @@ <% if registration_recaptcha_enabled?(@profile_type) %> <%= recaptcha_tags %> <% end %> - <%= f.submit l10n('assister_agencies.new_assister_agency_form.create_assister_agency'), class: 'btn btn-primary', id: 'assister-btn', disabled: EnrollRegistry.feature_enabled?(:broker_attestation_fields) %> + <%= f.submit l10n('assister_agencies.new_assister_agency_form.create_assister_agency'), class: 'btn btn-primary', id: 'assister-btn' %> <% end %>