From 0ace7a682f2c1e120945963e85075773036bb69c Mon Sep 17 00:00:00 2001 From: Austin Henriksen Date: Thu, 12 Feb 2026 11:46:17 -0500 Subject: [PATCH 1/4] Improve error message about self-referential types. --- slicec/src/diagnostics/errors.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slicec/src/diagnostics/errors.rs b/slicec/src/diagnostics/errors.rs index 5e0fe61b..c8b0ab72 100644 --- a/slicec/src/diagnostics/errors.rs +++ b/slicec/src/diagnostics/errors.rs @@ -523,7 +523,7 @@ implement_diagnostic_functions!( ( "E047", InfiniteSizeCycle, - format!("self-referential type {type_id} has infinite size: {cycle}"), + format!("disallowed type cycle; type {type_id} references itself: {cycle}"), type_id, cycle ), ( From e8a503ca8b5410c993ed7d83a019c2d37a98a95c Mon Sep 17 00:00:00 2001 From: Austin Henriksen Date: Thu, 12 Feb 2026 12:10:45 -0500 Subject: [PATCH 2/4] Try to fix CI. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 47732750..ca4b5510 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -64,7 +64,7 @@ jobs: - name: ๐Ÿงช Test run: cargo test --no-default-features $FEATURES -p slice-codec - name: ๐Ÿ“‹ Check Soundness - run: cargo +nightly miri test --no-default-features $FEATURES -p slice-codec + run: CARGO_TARGET_DIR=miri-target cargo +nightly miri test --no-default-features $FEATURES -p slice-codec - name: ๐Ÿ”Ž Lint run: cargo clippy --all-targets --no-default-features $FEATURES --no-deps -p slice-codec - name: ๐Ÿ“š Generate Documentation From d047158c752a909dfe6aaacbeb97a09f03b7963b Mon Sep 17 00:00:00 2001 From: Austin Henriksen Date: Wed, 25 Feb 2026 10:07:09 -0500 Subject: [PATCH 3/4] Remove temporary workaround for Miri bug. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ca4b5510..47732750 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -64,7 +64,7 @@ jobs: - name: ๐Ÿงช Test run: cargo test --no-default-features $FEATURES -p slice-codec - name: ๐Ÿ“‹ Check Soundness - run: CARGO_TARGET_DIR=miri-target cargo +nightly miri test --no-default-features $FEATURES -p slice-codec + run: cargo +nightly miri test --no-default-features $FEATURES -p slice-codec - name: ๐Ÿ”Ž Lint run: cargo clippy --all-targets --no-default-features $FEATURES --no-deps -p slice-codec - name: ๐Ÿ“š Generate Documentation From 63ca19abaf103aca92fdbd301a9279fabfa1eacd Mon Sep 17 00:00:00 2001 From: Austin Henriksen Date: Wed, 25 Feb 2026 10:07:55 -0500 Subject: [PATCH 4/4] Simpler error message. --- slicec/src/diagnostics/errors.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slicec/src/diagnostics/errors.rs b/slicec/src/diagnostics/errors.rs index c8b0ab72..b0f592c8 100644 --- a/slicec/src/diagnostics/errors.rs +++ b/slicec/src/diagnostics/errors.rs @@ -523,7 +523,7 @@ implement_diagnostic_functions!( ( "E047", InfiniteSizeCycle, - format!("disallowed type cycle; type {type_id} references itself: {cycle}"), + format!("type {type_id} illegally references itself: {cycle}"), type_id, cycle ), (