Is this stable?

[huachuman]

I am amazed to see that this actually successfully opens a new window of the same vault. That is great news. But I worry about corruption or other weird things given that two windows are now accessing the same files. Is this safe to use? How much has this been tested?

Really interested in this plugin. Props. 👊

[ibash]

It has not been extensively tested. Unfortunately the only way I can see obsidian code is minified, so I can’t even reassure you that I’ve read through the code and know where it might lead to bugs.

That said I’ve used it a bit here and there, mostly when I want two documents side by side.

But I wouldn’t use it too long without an application restart, as weird state might accumulate.

[huachuman]

Thank you. I'll use it and try and provide useful feedback if I can. I backup my vault daily anyway so I'm not too worried.

[ibash]

Just tested on a new vault with no syncing setup. What I found:

What works:

1. Updating a file while open on new windows: there's some delay, but it seems to work
2. Deleting a file open on two windows: again, slight latency but seems to work fine
3. Creating new files works

Bugs:

1. Installing a new theme across two windows: doesn't propagate, but also for some reason the themes don't seem to apply instantly in the vault I set it in anyway (needs a refresh)
2. Installing a new plugin in one window doesn't show up in the other window (doing a force reload makes it work though)
3. Opening obsidian urls will only happen in a single window, even if they're clicked from the second window
4. If you close the original window and click an obsidian url, then a new window will be opened
5. For window state last write wins (whichever window was modified last, on restart that state will be restored)

[huachuman]

I also noticed that right click only works in one of the windows. In the other window, nothing happens on right click.

[ibash]

I also noticed that right click only works in one of the windows. In the other window, nothing happens on right click.

ooo thanks. Looks like after initializing the browser window obsidian adds a custom context menu handler:

obsidian-new-window/obsidian-main.js

Line 1189 in f204bc0

m.on('context-menu', (R, w) => {

Just did a quick experiment of assigning the context-menu handler from the original browser window to the new window and it lets the menu open, but it doesn't have all the same options, so requires more investigation.

Original window:

Quick hack:

For posterity I did that by

x = window.require('electron')
win = x.remote.BrowserWindow.getAllWindows()[0]
z = win.webContents._events['context-menu']
// win is the original window and z is the context menu event handler
// open a new window
win2 = x.remote.BrowserWindow.getAllWindows()[0]
// win2 is the second window, electron adds it to the start of the list (compare ids to verify)
win2.webContents.on('context-menu', z)