Sharing iP code quality feedback [for @iamtr] #1
Description
@iamtr We did an automated analysis of your code to detect potential areas to improve the code quality. We are sharing the results below, to help you improve the iP code further.
IMPORTANT: Note that the script looked for just a few easy-to-detect problems only, and at-most three example are given i.e., there can be other areas/places to improve.
Aspect: Tab Usage
No easy-to-detect issues 👍
Aspect: Naming boolean variables/methods
Example from src/main/java/Duke.java lines 42-42:
boolean commandIsBye = false;Suggestion: Follow the given naming convention for boolean variables/methods (e.g., use a boolean-sounding prefix).You may ignore the above if you think the name already follows the convention (the script can report false positives in some cases)
Aspect: Brace Style
No easy-to-detect issues 👍
Aspect: Package Name Style
No easy-to-detect issues 👍
Aspect: Class Name Style
No easy-to-detect issues 👍
Aspect: Dead Code
No easy-to-detect issues 👍
Aspect: Method Length
No easy-to-detect issues 👍
Aspect: Class size
No easy-to-detect issues 👍
Aspect: Header Comments
No easy-to-detect issues 👍
Aspect: Recent Git Commit Message
possible problems in commit 26e13eb:
Change parseCommand to return String
I am aware that this is not an ideal way of doing things, since parseCommand is not supposed to interact with UI directly or return anything. However, given the scope of the project and the amount of time I want to spend here, I believe this amendment is fine for now. It is not good practice.
- body not wrapped at 72 characters: e.g.,
I am aware that this is not an ideal way of doing things, since parseCommand is not supposed to interact with UI directly or return anything. However, given the scope of the project and the amount of time I want to spend here, I believe this amendment is fine for now. It is not good practice.
Suggestion: Follow the given conventions for Git commit messages for future commits (do not modify past commit messages as doing so will change the commit timestamp that we used to detect your commit timings).
Aspect: Binary files in repo
No easy-to-detect issues 👍
ℹ️ The bot account used to post this issue is un-manned. Do not reply to this post (as those replies will not be read). Instead, contact cs2103@comp.nus.edu.sg if you want to follow up on this post.