-
Notifications
You must be signed in to change notification settings - Fork 12
Description
Thank you for your warm welcome :)
I have just sent a PR. I added section numbers and a table of contents. I also corrected some spelling and punctuation errors.
You asked about clarity, and I have a few suggestions.
First, I would suggest rephrasing a couple of sentences to make them sound more straightforward. For example, “The author assigned to the article will be the name of the authenticated user.” could be put as “Your username will appear as the author of the article.”
Second, I think the deployment section could be structured a bit better. It’s a list of steps, but when you scroll through it, it is not clear. You need to read the details to understand what the paragraph is about. My suggestions would be to: change heading titles to start with a verb, use numbered lists, put prerequisites before the task description, and remove quote formatting.
Below is an example of what I mean. As it’s not what you asked, I created a separate branch in my forked repository to work on additional changes. For me, it’s always an exercise. Later I can send another PR, and you can see if it is something you’d like to apply.
2.2 Production mode
The production mode allows to deploy the application on the server. To use it, you will need:
dockerdocker-compose
a) Set up environment variables(.env file)
Before deploying the application, you need to set the environment variables as for development mode.
- From the root directory of the repository, do the following:
cp .env.example .env.productionb) Create SSL certificates
To set up HTTPS, you will need valid SSL certificates.
- If you deploy the app for the first time, follow these instructions:
- Comment or delete the whole server section about 443 in the
nginx/nginx.conf.templatefile.
- server {
- listen 443 default_server ssl http2;
- ...
- }This step is required because the certificates don't exist yet, so they cannot be loaded in the nginx configuration.
Originally posted by @OlaPom in #79 (comment)
Metadata
Metadata
Assignees
Labels
Type
Projects
Status