Fix type check in anyOf/oneOf error handlers

Author: jdesrosiers

src/error-handlers/anyOf.js

@@ -20,7 +20,7 @@ const anyOfErrorHandler = async (normalizedErrors, instance, localization) => {
     const instanceLocation = Instance.uri(instance);
 
     for (const alternative of anyOf) {
-      const typeErrors = alternative[instanceLocation]["https://json-schema.org/keyword/type"];
+      const typeErrors = alternative[instanceLocation]?.["https://json-schema.org/keyword/type"];
       const match = !typeErrors || Object.values(typeErrors).every((isValid) => isValid);
 
       if (match) {

src/error-handlers/oneOf.js

@@ -21,7 +21,7 @@ const oneOfErrorHandler = async (normalizedErrors, instance, localization) => {
     let matchCount = 0;
 
     for (const alternative of oneOf) {
-      const typeErrors = alternative[instanceLocation]["https://json-schema.org/keyword/type"];
+      const typeErrors = alternative[instanceLocation]?.["https://json-schema.org/keyword/type"];
       const match = !typeErrors || Object.values(typeErrors).every((isValid) => isValid);
 
       if (match) {

src/test-suite/tests/anyOf.json

@@ -207,6 +207,53 @@
           "schemaLocations": ["#/$defs/bar/maxLength"]
         }
       ]
+    },
+    {
+      "description": "anyOf with no declared type",
+      "schema": {
+        "anyOf": [
+          {
+            "properties": {
+              "foo": { "type": "string" }
+            }
+          },
+          {
+            "properties": {
+              "foo": { "type": "boolean" }
+            }
+          }
+        ]
+      },
+      "instance": { "foo": 42 },
+      "errors": [
+        {
+          "messageId": "anyOf-message",
+          "alternatives": [
+            [
+              {
+                "messageId": "type-message",
+                "messageParams": {
+                  "expectedTypes": { "or": ["string"] }
+                },
+                "instanceLocation": "#/foo",
+                "schemaLocations": ["https://example.com/main#/anyOf/0/properties/foo/type"]
+              }
+            ],
+            [
+              {
+                "messageId": "type-message",
+                "messageParams": {
+                  "expectedTypes": { "or": ["boolean"] }
+                },
+                "instanceLocation": "#/foo",
+                "schemaLocations": ["https://example.com/main#/anyOf/1/properties/foo/type"]
+              }
+            ]
+          ],
+          "instanceLocation": "#",
+          "schemaLocations": ["https://example.com/main#/anyOf"]
+        }
+      ]
     }
   ]
 }

src/test-suite/tests/oneOf.json

@@ -272,6 +272,56 @@
           ]
         }
       ]
+    },
+    {
+      "description": "oneOf with no declared type",
+      "schema": {
+        "oneOf": [
+          {
+            "properties": {
+              "foo": { "type": "string" }
+            }
+          },
+          {
+            "properties": {
+              "foo": { "type": "boolean" }
+            }
+          }
+        ]
+      },
+      "instance": { "foo": 42 },
+      "errors": [
+        {
+          "messageId": "oneOf-message",
+          "messageParams": {
+            "matchCount": 0
+          },
+          "alternatives": [
+            [
+              {
+                "messageId": "type-message",
+                "messageParams": {
+                  "expectedTypes": { "or": ["string"] }
+                },
+                "instanceLocation": "#/foo",
+                "schemaLocations": ["https://example.com/main#/oneOf/0/properties/foo/type"]
+              }
+            ],
+            [
+              {
+                "messageId": "type-message",
+                "messageParams": {
+                  "expectedTypes": { "or": ["boolean"] }
+                },
+                "instanceLocation": "#/foo",
+                "schemaLocations": ["https://example.com/main#/oneOf/1/properties/foo/type"]
+              }
+            ]
+          ],
+          "instanceLocation": "#",
+          "schemaLocations": ["https://example.com/main#/oneOf"]
+        }
+      ]
     }
   ]
 }