Skip to content

Commit 4eff9a3

Browse files
authored
Merge pull request #106 from hyeonjiroh/feat/#22/sidebar-pagenation
refactor: #99/할 일 카드 모달 리팩토링
2 parents d06b649 + 0a26a26 commit 4eff9a3

3 files changed

Lines changed: 16 additions & 31 deletions

File tree

src/components/modal/task-detail/TaskContentSection.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ export default function TaskContentSection({
1515
}) {
1616
return (
1717
<>
18-
<div className="flex items-start flex-1 min-w-0 max-h-[26px] tablet:max-h-[28px]">
19-
<div className="flex items-center pr-3 tablet:pr-5">
18+
<div className="flex items-start w-[290px] tablet:w-[420px] pc:w-[445px] max-h-[26px] tablet:max-h-[28px]">
19+
<div className="flex items-center shrink-0">
2020
<ColumnNameTag />
21-
<div className="shrink-0 w-[1px] h-4 bg-gray-400 ml-3 tablet:ml-5" />
21+
<div className="shrink-0 w-[1px] h-4 bg-gray-400 mx-3 tablet:mx-5" />
2222
</div>
23-
<div className="flex-nowrap w-full min-w-0 overflow-x-auto scrollbar-hide max-w-[205px] tablet:max-w-[315px] pc:max-w-[340px]">
23+
<div className="flex-grow min-h-0 overflow-x-auto whitespace-nowrap scrollbar-hide">
2424
<TagList tags={tags} />
2525
</div>
2626
</div>

src/components/modal/task-detail/TaskDetailModal.tsx

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,22 +11,28 @@ import TaskCommentSection from "./TaskCommentSection";
1111
export default function TaskDetailModal() {
1212
const { selectedTaskId } = useTaskStore();
1313
const [data, setData] = useState<TaskCardDetail | null>(null);
14+
const [isLoading, setIsLoading] = useState(false);
1415

15-
useEffect(() => {
16+
const handleLoad = async () => {
1617
if (!selectedTaskId) return;
18+
if (isLoading) return;
19+
setIsLoading(true);
1720

18-
const getData = async () => {
21+
try {
1922
const res = await fetchTaskCardDetail({
2023
token: TOKEN_1,
2124
id: selectedTaskId,
2225
});
2326
setData(res);
24-
};
27+
} finally {
28+
setIsLoading(false);
29+
}
30+
};
2531

26-
getData();
27-
}, [selectedTaskId]);
32+
useEffect(() => {
33+
handleLoad();
34+
}, []);
2835

29-
if (!selectedTaskId) return;
3036
if (!data) return;
3137

3238
const {

src/lib/utils/colorUtils.ts

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)