refactor: improve api validations and types

Author: dnechay

packages/apps/reputation-oracle/server/src/modules/reputation/reputation.dto.ts

@@ -95,7 +95,6 @@ export class ReputationGetAllQueryDto {
 
 export class ReputationGetParamsDto {
   @ApiProperty()
-  @IsString()
   @IsEthereumAddress()
   public address: string;
 }
@@ -112,7 +111,6 @@ export class ReputationDto {
   chainId: ChainId;
 
   @ApiProperty()
-  @IsString()
   @IsEthereumAddress()
   address: string;
 

packages/apps/reputation-oracle/server/src/modules/user/user.controller.ts

@@ -31,7 +31,7 @@ import {
   RegisterLabelerResponseDto,
   EnableOperatorDto,
   RegistrationInExchangeOracleDto,
-  RegistrationInExchangeOraclesDto,
+  RegistrationInExchangeOraclesResponseDto,
   RegistrationInExchangeOracleResponseDto,
 } from './user.dto';
 import { UserService } from './user.service';
@@ -201,7 +201,7 @@ export class UserController {
   @ApiResponse({
     status: 200,
     description: 'List of registered oracles retrieved successfully',
-    type: RegistrationInExchangeOraclesDto,
+    type: RegistrationInExchangeOraclesResponseDto,
   })
   @ApiResponse({
     status: 401,
@@ -210,7 +210,7 @@ export class UserController {
   @Get('/exchange-oracle-registration')
   async getRegistrationInExchangeOracles(
     @Req() request: RequestWithUser,
-  ): Promise<RegistrationInExchangeOraclesDto> {
+  ): Promise<RegistrationInExchangeOraclesResponseDto> {
     const oracleAddresses =
       await this.userService.getRegistrationInExchangeOracles(request.user);
 

packages/apps/reputation-oracle/server/src/modules/user/user.dto.ts

@@ -13,7 +13,7 @@ export class RegisterLabelerResponseDto {
 
 export class RegisterAddressRequestDto {
   @ApiProperty()
-  @IsString()
+  @IsEthereumAddress()
   address: string;
 
   @ApiProperty()
@@ -35,12 +35,10 @@ export class DisableOperatorDto {
 
 export class SignatureBodyDto {
   @ApiProperty()
-  @IsString()
   @IsEthereumAddress()
   from: string;
 
   @ApiProperty()
-  @IsString()
   @IsEthereumAddress()
   to: string;
 
@@ -56,7 +54,6 @@ export class SignatureBodyDto {
 
 export class PrepareSignatureDto {
   @ApiProperty()
-  @IsString()
   @IsEthereumAddress()
   address: string;
 
@@ -87,7 +84,7 @@ export class RegistrationInExchangeOracleResponseDto {
   oracleAddress: string;
 }
 
-export class RegistrationInExchangeOraclesDto {
+export class RegistrationInExchangeOraclesResponseDto {
   @ApiProperty({ name: 'oracle_addresses' })
   oracleAddresses: string[];
 }