From 67b2ae94736181bdf11429c0178f4b8b994db24d Mon Sep 17 00:00:00 2001 From: Yacklin Wong Date: Thu, 6 Nov 2025 17:55:33 -0400 Subject: [PATCH 1/2] Remove the comments that pollute library_import_path in _download_additional_modules and correct import_library_name for "absl" --- metrics/rouge/rouge.py | 4 ++-- src/evaluate/loading.py | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/metrics/rouge/rouge.py b/metrics/rouge/rouge.py index 353301cca..843738279 100644 --- a/metrics/rouge/rouge.py +++ b/metrics/rouge/rouge.py @@ -14,9 +14,9 @@ """ ROUGE metric from Google Research github repo. """ # The dependencies in https://github.com/google-research/google-research/blob/master/rouge/requirements.txt -import absl # Here to have a nice missing dependency error message early on +import absl import datasets -import nltk # Here to have a nice missing dependency error message early on +import nltk import numpy # Here to have a nice missing dependency error message early on import six # Here to have a nice missing dependency error message early on from rouge_score import rouge_scorer, scoring diff --git a/src/evaluate/loading.py b/src/evaluate/loading.py index a9cbbe60d..b06e9b56e 100644 --- a/src/evaluate/loading.py +++ b/src/evaluate/loading.py @@ -260,6 +260,7 @@ def _download_additional_modules( lib = importlib.import_module(library_import_name) # noqa F841 except ImportError: library_import_name = "scikit-learn" if library_import_name == "sklearn" else library_import_name + library_import_name = "absl-py" if library_import_name == "absl-py" else library_import_name needs_to_be_installed.add((library_import_name, library_import_path)) if needs_to_be_installed: raise ImportError( From 43328d48f4ac9d146226ba449d46f2f7c334ad2c Mon Sep 17 00:00:00 2001 From: Yacklin Wong Date: Thu, 6 Nov 2025 18:13:40 -0400 Subject: [PATCH 2/2] some updates --- src/evaluate/loading.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/evaluate/loading.py b/src/evaluate/loading.py index b06e9b56e..dc6d91fb3 100644 --- a/src/evaluate/loading.py +++ b/src/evaluate/loading.py @@ -260,7 +260,8 @@ def _download_additional_modules( lib = importlib.import_module(library_import_name) # noqa F841 except ImportError: library_import_name = "scikit-learn" if library_import_name == "sklearn" else library_import_name - library_import_name = "absl-py" if library_import_name == "absl-py" else library_import_name + library_import_name = "absl-py" if library_import_name == "absl" else library_import_name + library_import_path = "absl-py" if library_import_path == "absl" else library_import_path needs_to_be_installed.add((library_import_name, library_import_path)) if needs_to_be_installed: raise ImportError(