-
Notifications
You must be signed in to change notification settings - Fork 54
Open
Description
When using fargo as go get github.com/hudl/fargo the Instance struct has a field InstanceId. However, this field is missing when declaring the dependency using dep. A few other fields are different as well. Below is the struct definition in each case.
Using go get:
// Instance [de]serializeable [to|from] Eureka [XML|JSON].
type Instance struct {
InstanceId string `xml:"instanceId" json:"instanceId"`
HostName string `xml:"hostName" json:"hostName"`
App string `xml:"app" json:"app"`
IPAddr string `xml:"ipAddr" json:"ipAddr"`
VipAddress string `xml:"vipAddress" json:"vipAddress"`
SecureVipAddress string `xml:"secureVipAddress" json:"secureVipAddress"`
Status StatusType `xml:"status" json:"status"`
Overriddenstatus StatusType `xml:"overriddenstatus" json:"overriddenstatus"`
Port int `xml:"-" json:"-"`
PortEnabled bool `xml:"-" json:"-"`
SecurePort int `xml:"-" json:"-"`
SecurePortEnabled bool `xml:"-" json:"-"`
HomePageUrl string `xml:"homePageUrl" json:"homePageUrl"`
StatusPageUrl string `xml:"statusPageUrl" json:"statusPageUrl"`
HealthCheckUrl string `xml:"healthCheckUrl" json:"healthCheckUrl"`
CountryId int64 `xml:"countryId" json:"countryId"`
DataCenterInfo DataCenterInfo `xml:"dataCenterInfo" json:"dataCenterInfo"`
LeaseInfo LeaseInfo `xml:"leaseInfo" json:"leaseInfo"`
Metadata InstanceMetadata `xml:"metadata" json:"metadata"`
UniqueID func(i Instance) string `xml:"-" json:"-"`
}
Using dep
// Instance [de]serializeable [to|from] Eureka XML.
type Instance struct {
XMLName struct{} `xml:"instance" json:"-"`
HostName string `xml:"hostName" json:"hostName"`
App string `xml:"app" json:"app"`
IPAddr string `xml:"ipAddr" json:"ipAddr"`
VipAddress string `xml:"vipAddress" json:"vipAddress"`
SecureVipAddress string `xml:"secureVipAddress" json:"secureVipAddress"`
Status StatusType `xml:"status" json:"status"`
Overriddenstatus StatusType `xml:"overriddenstatus" json:"overriddenstatus"`
Port int `xml:"port" json:"-"`
PortJ Port `json:"port" xml:"-"`
SecurePort int `xml:"securePort" json:"-"`
SecurePortJ Port `json:"securePort" xml:"-"`
HomePageUrl string `xml:"homePageUrl" json:"homePageUrl"`
StatusPageUrl string `xml:"statusPageUrl" json:"statusPageUrl"`
HealthCheckUrl string `xml:"healthCheckUrl" json:"healthCheckUrl"`
CountryId int64 `xml:"countryId" json:"countryId"`
DataCenterInfo DataCenterInfo `xml:"dataCenterInfo" json:"dataCenterInfo"`
LeaseInfo LeaseInfo `xml:"leaseInfo" json:"leaseInfo"`
Metadata InstanceMetadata `xml:"metadata" json:"metadata"`
UniqueID func(i Instance) string `xml:"-" json:"-"`
}
The Gopkg.toml snippet is
.....
[[constraint]]
name = "github.com/hudl/fargo"
version = "1.3.1"
.....
Which of these is the correct one and should be used?
Metadata
Metadata
Assignees
Labels
No labels