From 81eb13e43fb4b2671467ca4591ff617e06269fc8 Mon Sep 17 00:00:00 2001 From: zhangyongding <59941594@qq.com> Date: Mon, 20 Oct 2025 18:13:44 +0800 Subject: [PATCH] fix oracle limit bug --- select.go | 1 - select_test.go | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/select.go b/select.go index 4662c56..eaae582 100644 --- a/select.go +++ b/select.go @@ -580,7 +580,6 @@ func (sb *SelectBuilder) BuildWithFlavor(flavor Flavor, initialArg ...interface{ } else { buf.WriteString("1 AND ") buf.WriteString(sb.limitVar) - buf.WriteString(" + 1") } } else { // As oraclePage is true, sb.offsetVar must not be empty. diff --git a/select_test.go b/select_test.go index 1c1bcc6..b9b9d0e 100644 --- a/select_test.go +++ b/select_test.go @@ -263,7 +263,7 @@ func ExampleSelectBuilder_limit_offset() { // #1: SELECT * FROM user // #2: SELECT * FROM (SELECT ROWNUM r, * FROM (SELECT * FROM user) user) WHERE r >= :1 + 1 // #3: SELECT * FROM (SELECT ROWNUM r, * FROM (SELECT * FROM user) user) WHERE r BETWEEN :1 + 1 AND :2 + :3 - // #4: SELECT * FROM (SELECT ROWNUM r, * FROM (SELECT * FROM user) user) WHERE r BETWEEN 1 AND :1 + 1 + // #4: SELECT * FROM (SELECT ROWNUM r, * FROM (SELECT * FROM user) user) WHERE r BETWEEN 1 AND :1 // #5: SELECT * FROM (SELECT ROWNUM r, * FROM (SELECT * FROM user ORDER BY id) user) WHERE r BETWEEN :1 + 1 AND :2 + :3 // // Informix