From 512b64bd322129dd83850a5f9aa4ba1dd504b413 Mon Sep 17 00:00:00 2001 From: Michael Albano Date: Thu, 2 Dec 2021 11:13:06 +0800 Subject: [PATCH] Create code-review-comments.txt --- code-review-comments.txt | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 code-review-comments.txt diff --git a/code-review-comments.txt b/code-review-comments.txt new file mode 100644 index 0000000..ebac257 --- /dev/null +++ b/code-review-comments.txt @@ -0,0 +1,20 @@ +Code Review Comments from Michelle and Mike + +Good points +- presentation was awesome +- good use of APIs (calendar, google gantt chart) +- index.js - good comments, clean organization. nothing weird. :D +- css is beautiful. + +Points to improve +- update your README.md (it still says Rocket Academy Coding Bootcamp: Base Node App) +- very long functions need to be commented more, e.g. renderAddSchedule. +- // this loop is what I'm proudest of in this whole project. + - good to also say how it works in the comments. +- routes.js + - lines 143-150, look very similar to 164-161. Could this be refactored into a function? +- gantt-chart.ejs + - it's weird that the script for drawing the gantt, is above the html... we think maybe it should be below. +- calendar.ejs + - lines 22, and 23 contain /head and body tags. but these are already in the header and footer... something weird here. +