From ac91aa18578445563e79f988649238a123358c9e Mon Sep 17 00:00:00 2001 From: "kian.kwa" Date: Wed, 4 Mar 2026 14:04:09 +0000 Subject: [PATCH 1/3] Add flag for subscription trigger --- .../pip/model/publication/ListType.java | 26 ++++++++++++++----- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/src/main/java/uk/gov/hmcts/reform/pip/model/publication/ListType.java b/src/main/java/uk/gov/hmcts/reform/pip/model/publication/ListType.java index ae374c6..b6caefd 100644 --- a/src/main/java/uk/gov/hmcts/reform/pip/model/publication/ListType.java +++ b/src/main/java/uk/gov/hmcts/reform/pip/model/publication/ListType.java @@ -27,13 +27,13 @@ @AllArgsConstructor public enum ListType { SJP_PUBLIC_LIST(NATIONAL, List.of(PI_AAD), ALL_VERIFIED_THIRD_PARTY_PRESS_ROLES, null, - "SJP Public List (Full list)", true, false, false), + "SJP Public List (Full list)", true, false, true, false), SJP_DELTA_PUBLIC_LIST(NATIONAL, List.of(PI_AAD), ALL_VERIFIED_THIRD_PARTY_PRESS_ROLES, SJP_PUBLIC_LIST, - "SJP Public List (New cases)", true, false, false), + "SJP Public List (New cases)", true, false, true, false), SJP_PRESS_LIST(NATIONAL, List.of(PI_AAD), ALL_VERIFIED_THIRD_PARTY_PRESS_ROLES, null, - "SJP Press List (Full list)", true, false, false), + "SJP Press List (Full list)", true, false, true, false), SJP_DELTA_PRESS_LIST(NATIONAL, List.of(PI_AAD), ALL_VERIFIED_THIRD_PARTY_PRESS_ROLES, SJP_PRESS_LIST, - "SJP Press List (New cases)", true, false, false), + "SJP Press List (New cases)", true, false, true, false), SJP_PRESS_REGISTER(NATIONAL, List.of(PI_AAD), ALL_VERIFIED_THIRD_PARTY_PRESS_ROLES), CROWN_DAILY_LIST(VENUE, List.of(CRIME_IDAM), ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, true), CROWN_FIRM_LIST(VENUE, List.of(CRIME_IDAM), ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, true), @@ -121,7 +121,7 @@ public enum ListType { SSCS_MIDLANDS_DAILY_HEARING_LIST, "London Social Security and Child Support Tribunal Daily Hearing List"), MENTAL_HEALTH_TRIBUNAL_HEARING_LIST(NATIONAL, List.of(PI_AAD), ALL_VERIFIED_THIRD_PARTY_PRESS_ROLES, null, - "Mental Health Tribunal Daily Hearing List", true, false, false), + "Mental Health Tribunal Daily Hearing List", true, false, true, false), LONDON_ADMINISTRATIVE_COURT_DAILY_CAUSE_LIST(NATIONAL, List.of(CFT_IDAM), ALL_VERIFIED_THIRD_PARTY_CFT_ROLES), COUNTY_COURT_LONDON_CIVIL_DAILY_CAUSE_LIST(NATIONAL, List.of(CFT_IDAM), ALL_VERIFIED_THIRD_PARTY_CFT_ROLES, "County Court at Central London Civil Daily Cause List"), @@ -193,11 +193,11 @@ public enum ListType { "First-tier Tribunal (Special Educational Needs and Disability) Daily Hearing List"), CIC_WEEKLY_HEARING_LIST(NATIONAL, List.of(CFT_IDAM), ALL_VERIFIED_THIRD_PARTY_CFT_ROLES), MAGISTRATES_ADULT_COURT_LIST_DAILY(VENUE, List.of(CRIME_IDAM), ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, - "Magistrates Adult Court List - Daily"), + "Magistrates Adult Court List - Daily", false), MAGISTRATES_ADULT_COURT_LIST_FUTURE(VENUE, List.of(CRIME_IDAM), ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, MAGISTRATES_ADULT_COURT_LIST_DAILY, "Magistrates Adult Court List - Future"), MAGISTRATES_PUBLIC_ADULT_COURT_LIST_DAILY(VENUE, List.of(CRIME_IDAM), - ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, "Magistrates Public Adult Court List - Daily"), + ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, "Magistrates Public Adult Court List - Daily", false), MAGISTRATES_PUBLIC_ADULT_COURT_LIST_FUTURE(VENUE, List.of(CRIME_IDAM), ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, MAGISTRATES_PUBLIC_ADULT_COURT_LIST_DAILY,"Magistrates Public Adult Court List - Future"), CROWN_DAILY_PDDA_LIST(VENUE, List.of(CRIME_IDAM, PI_AAD), ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, @@ -248,6 +248,12 @@ public enum ListType { @Accessors(fluent = true) private boolean hasAdditionalPdf = true; + /** + * Flag to indicate whether subscription is triggered immediately after upload, or if it is triggered by a + * scheduled task at a later time + */ + private boolean triggerSubscriptionFromUpload = true; + /** * Flag to indicate whether the list type is deprecated and no longer in use. */ @@ -272,6 +278,12 @@ public enum ListType { this.friendlyName = friendlyName; } + ListType(LocationType listLocationLevel, List allowedProvenances, + List allowedThirdPartyRoles, String friendlyName, boolean triggerSubscriptionFromUpload) { + this(listLocationLevel, allowedProvenances, allowedThirdPartyRoles); + this.triggerSubscriptionFromUpload = triggerSubscriptionFromUpload; + } + ListType(LocationType listLocationLevel, List allowedProvenances, List allowedThirdPartyRoles, ListType parentListType, String friendlyName) { this(listLocationLevel, allowedProvenances, allowedThirdPartyRoles, friendlyName); From b7697d3cb99041b653f361e8dc2c535c32e5828c Mon Sep 17 00:00:00 2001 From: "kian.kwa" Date: Wed, 4 Mar 2026 14:11:24 +0000 Subject: [PATCH 2/3] Fix checkstyle --- .../uk/gov/hmcts/reform/pip/model/publication/ListType.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/uk/gov/hmcts/reform/pip/model/publication/ListType.java b/src/main/java/uk/gov/hmcts/reform/pip/model/publication/ListType.java index b6caefd..d94a0dc 100644 --- a/src/main/java/uk/gov/hmcts/reform/pip/model/publication/ListType.java +++ b/src/main/java/uk/gov/hmcts/reform/pip/model/publication/ListType.java @@ -250,7 +250,7 @@ public enum ListType { /** * Flag to indicate whether subscription is triggered immediately after upload, or if it is triggered by a - * scheduled task at a later time + * scheduled task at a later time. */ private boolean triggerSubscriptionFromUpload = true; From 8fb43a865165c98e5670b28a2ae7d619af5b2ba9 Mon Sep 17 00:00:00 2001 From: "kian.kwa" Date: Wed, 4 Mar 2026 15:59:16 +0000 Subject: [PATCH 3/3] Update flag name --- .../pip/model/publication/ListType.java | 25 +++++++++---------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/src/main/java/uk/gov/hmcts/reform/pip/model/publication/ListType.java b/src/main/java/uk/gov/hmcts/reform/pip/model/publication/ListType.java index d94a0dc..487b03f 100644 --- a/src/main/java/uk/gov/hmcts/reform/pip/model/publication/ListType.java +++ b/src/main/java/uk/gov/hmcts/reform/pip/model/publication/ListType.java @@ -27,13 +27,13 @@ @AllArgsConstructor public enum ListType { SJP_PUBLIC_LIST(NATIONAL, List.of(PI_AAD), ALL_VERIFIED_THIRD_PARTY_PRESS_ROLES, null, - "SJP Public List (Full list)", true, false, true, false), + "SJP Public List (Full list)", true, false, false, false), SJP_DELTA_PUBLIC_LIST(NATIONAL, List.of(PI_AAD), ALL_VERIFIED_THIRD_PARTY_PRESS_ROLES, SJP_PUBLIC_LIST, - "SJP Public List (New cases)", true, false, true, false), + "SJP Public List (New cases)", true, false, false, false), SJP_PRESS_LIST(NATIONAL, List.of(PI_AAD), ALL_VERIFIED_THIRD_PARTY_PRESS_ROLES, null, - "SJP Press List (Full list)", true, false, true, false), + "SJP Press List (Full list)", true, false, false, false), SJP_DELTA_PRESS_LIST(NATIONAL, List.of(PI_AAD), ALL_VERIFIED_THIRD_PARTY_PRESS_ROLES, SJP_PRESS_LIST, - "SJP Press List (New cases)", true, false, true, false), + "SJP Press List (New cases)", true, false, false, false), SJP_PRESS_REGISTER(NATIONAL, List.of(PI_AAD), ALL_VERIFIED_THIRD_PARTY_PRESS_ROLES), CROWN_DAILY_LIST(VENUE, List.of(CRIME_IDAM), ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, true), CROWN_FIRM_LIST(VENUE, List.of(CRIME_IDAM), ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, true), @@ -121,7 +121,7 @@ public enum ListType { SSCS_MIDLANDS_DAILY_HEARING_LIST, "London Social Security and Child Support Tribunal Daily Hearing List"), MENTAL_HEALTH_TRIBUNAL_HEARING_LIST(NATIONAL, List.of(PI_AAD), ALL_VERIFIED_THIRD_PARTY_PRESS_ROLES, null, - "Mental Health Tribunal Daily Hearing List", true, false, true, false), + "Mental Health Tribunal Daily Hearing List", true, false, false, false), LONDON_ADMINISTRATIVE_COURT_DAILY_CAUSE_LIST(NATIONAL, List.of(CFT_IDAM), ALL_VERIFIED_THIRD_PARTY_CFT_ROLES), COUNTY_COURT_LONDON_CIVIL_DAILY_CAUSE_LIST(NATIONAL, List.of(CFT_IDAM), ALL_VERIFIED_THIRD_PARTY_CFT_ROLES, "County Court at Central London Civil Daily Cause List"), @@ -193,11 +193,11 @@ public enum ListType { "First-tier Tribunal (Special Educational Needs and Disability) Daily Hearing List"), CIC_WEEKLY_HEARING_LIST(NATIONAL, List.of(CFT_IDAM), ALL_VERIFIED_THIRD_PARTY_CFT_ROLES), MAGISTRATES_ADULT_COURT_LIST_DAILY(VENUE, List.of(CRIME_IDAM), ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, - "Magistrates Adult Court List - Daily", false), + "Magistrates Adult Court List - Daily", true), MAGISTRATES_ADULT_COURT_LIST_FUTURE(VENUE, List.of(CRIME_IDAM), ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, MAGISTRATES_ADULT_COURT_LIST_DAILY, "Magistrates Adult Court List - Future"), MAGISTRATES_PUBLIC_ADULT_COURT_LIST_DAILY(VENUE, List.of(CRIME_IDAM), - ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, "Magistrates Public Adult Court List - Daily", false), + ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, "Magistrates Public Adult Court List - Daily", true), MAGISTRATES_PUBLIC_ADULT_COURT_LIST_FUTURE(VENUE, List.of(CRIME_IDAM), ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, MAGISTRATES_PUBLIC_ADULT_COURT_LIST_DAILY,"Magistrates Public Adult Court List - Future"), CROWN_DAILY_PDDA_LIST(VENUE, List.of(CRIME_IDAM, PI_AAD), ALL_VERIFIED_THIRD_PARTY_CRIME_ROLES, @@ -249,10 +249,9 @@ public enum ListType { private boolean hasAdditionalPdf = true; /** - * Flag to indicate whether subscription is triggered immediately after upload, or if it is triggered by a - * scheduled task at a later time. + * Flag to indicate whether subscription is triggered by a scheduled job, or by an upload of a publication. */ - private boolean triggerSubscriptionFromUpload = true; + private boolean isScheduledSubscription; /** * Flag to indicate whether the list type is deprecated and no longer in use. @@ -279,9 +278,9 @@ public enum ListType { } ListType(LocationType listLocationLevel, List allowedProvenances, - List allowedThirdPartyRoles, String friendlyName, boolean triggerSubscriptionFromUpload) { - this(listLocationLevel, allowedProvenances, allowedThirdPartyRoles); - this.triggerSubscriptionFromUpload = triggerSubscriptionFromUpload; + List allowedThirdPartyRoles, String friendlyName, boolean isScheduledSubscription) { + this(listLocationLevel, allowedProvenances, allowedThirdPartyRoles, friendlyName); + this.isScheduledSubscription = isScheduledSubscription; } ListType(LocationType listLocationLevel, List allowedProvenances,