Skip to content

Fix missing export definitions when building shared dll for Windows #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aidinabedi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix missing export definitions when building shared dll for Windows #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d411f3a
fix shared dll issue on windows not exporting definitions
aidinabedi Aug 16, 2018
a6de667
add shared library binary in install and package
aidinabedi Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@ else()

set_target_properties(freespace PROPERTIES PREFIX "lib")

if (LIBFREESPACE_LIB_TYPE STREQUAL "SHARED")
add_definitions(-DLIBFREESPACE_EXPORTS)
set_target_properties(freespace PROPERTIES IMPORT_PREFIX "lib")
endif()

IF (CMAKE_SIZEOF_VOID_P EQUAL 8) # Means we are using 64-bit
set(_hid ${WINDDK_WIN7_X64_HID_LIB})
Expand Down Expand Up @@ -244,6 +248,9 @@ add_subdirectory(doc)
if (NOT LIBFREESPACE_CUSTOM_INSTALL_RULES)
if (NOT LIBFREESPACE_CODECS_ONLY)
install(TARGETS freespace LIBRARY DESTINATION lib ARCHIVE DESTINATION lib)
if (LIBFREESPACE_LIB_TYPE STREQUAL "SHARED")
install(TARGETS freespace RUNTIME DESTINATION bin LIBRARY DESTINATION bin)
endif()
set_target_properties(freespace PROPERTIES
VERSION ${PROJECT_VERSION_STRING}
SOVERSION ${PROJECT_VERSION_MAJOR} )
Expand Down