Skip to content
This repository was archived by the owner on Jun 18, 2025. It is now read-only.
This repository was archived by the owner on Jun 18, 2025. It is now read-only.

seperating image.tag from image.repository is a good practice #34

@abdennour

Description

@abdennour

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

imageK8S: "hashicorp/terraform-k8s:1.0.0"

this line shows that the image value is not divided into repository and tag.
Dividing image value into 2 parts has the following advantages:

  1. Ability to override repository value (if i have proxy registry) while relying on the default value of "tag"
  2. within the same chart, Defaulting "tag" (if not assigned a value from user) to .Chart.AppVersion.
  3. being consistent with community charts

Potential Helm Configuration

global:
  imageK8S:
     repository: hashicorp/terraform-k8s
     tag: 1.0.0 # better make it empty string, and put this value under Chart.yaml ( appVersion)

References

imageK8S: "hashicorp/terraform-k8s:1.0.0"

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions