I *think* the nomad systemd files are slightly wrong

[jkugler]

I am a systemd novice, but reading other systemd .target and .service files, and some docs, I think the files here are slightly wrong: https://github.com/hashicorp/guides-configuration/tree/master/nomad/init/systemd

If one looks in https://github.com/hashicorp/guides-configuration/tree/master/consul/init/systemd there is this pattern:

consul-online.service is WantedBy consul-online.target

So, I understand that as "once consul-online-service succeeds, we will have arrived at consul-online.target

However, looking at https://github.com/hashicorp/guides-configuration/blob/master/nomad/init/systemd/

I see in nomad-vault.service this line: Requires=consul-online.target vault-token-ready.target

However, in vault-token-ready.service I see:

WantedBy=vault-ready.target multi-user.target

There is no vault-ready.target in https://github.com/hashicorp/guides-configuration/tree/master/vault/init/systemd, so I am assuming the line in vault-token-ready.service should be WantedBy=vault-token-ready.target multi-user.target

Am I understanding these files and systemd correctly?