-
Notifications
You must be signed in to change notification settings - Fork 4
Description
This would prevent naming clashes between register names and group/bit mask names, and avoid device maintainers going out of their way renaming enums to avoid clashes.
Note that from an object-oriented point of view, the Device is the object, and the registers are its properties and events (this is also explicit in how the JSON schema is structured, registers are explicit properties of the Device model).
If Device was an object with properties, there would be no clashes between property names and group/bit mask names, since property names do not clash with type names (i.e. properties can have the same name as a type of a property).
Previously the argument was that from a drop-down and XML perspective the registers would be more readable in the toolbox and .bonsai files if just the register name was shown. Fortunately this can be kept, using DisplayName and XmlType attributes.
It would be worth revisiting this in the generators, as it may be possible to keep all features backwards-compatible while finally removing this awkward constraint.