From 601f57a470fe450689bc53e3ea18a73d7c6f0abc Mon Sep 17 00:00:00 2001 From: JuneMinazuki Date: Mon, 6 Apr 2026 18:25:33 +0800 Subject: [PATCH 1/2] Fix course card leading to wrong course Course card lead to current course setting instead of the one user picked --- app/javascript/controllers/overlay_controller.js | 2 +- app/views/courses/_copy_course_overlay.html.erb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/javascript/controllers/overlay_controller.js b/app/javascript/controllers/overlay_controller.js index 9ad64033..3909b6e4 100644 --- a/app/javascript/controllers/overlay_controller.js +++ b/app/javascript/controllers/overlay_controller.js @@ -68,7 +68,7 @@ export default class extends Controller { } selectSetting(event) { - const sourceCourseId = event.params.courseId; + const sourceCourseId = event.params.sourceId; const targetCourseId = this.targetCourseIdValue; const mode = this.modeValue; diff --git a/app/views/courses/_copy_course_overlay.html.erb b/app/views/courses/_copy_course_overlay.html.erb index 88b05b04..06294bcf 100644 --- a/app/views/courses/_copy_course_overlay.html.erb +++ b/app/views/courses/_copy_course_overlay.html.erb @@ -18,7 +18,7 @@ <% if @courses.present? %>
<% @courses.each do |course_item| %> -
From 289a09bee112e695bc56887e768329a0d67f377b Mon Sep 17 00:00:00 2001 From: JuneMinazuki Date: Mon, 6 Apr 2026 18:29:27 +0800 Subject: [PATCH 2/2] Fix goBack() error Back button in course details cannot redirected back to the course list page --- app/javascript/controllers/overlay_controller.js | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/app/javascript/controllers/overlay_controller.js b/app/javascript/controllers/overlay_controller.js index 3909b6e4..e223fd49 100644 --- a/app/javascript/controllers/overlay_controller.js +++ b/app/javascript/controllers/overlay_controller.js @@ -137,4 +137,20 @@ export default class extends Controller { this.close(event); } + + goBack(event) { + if (event) event.preventDefault(); + this.returnToList(); + } + + returnToList() { + this.containerTarget.removeAttribute("src"); + this.containerTarget.removeAttribute("complete"); + + if (this.initialContent) { + this.containerTarget.innerHTML = this.initialContent; + } else { + this.containerTarget.innerHTML = ""; + } + } }