Failed test output improvement suggestion for called.withArg(arg) & called.withArgs(arg)

[jamesmorgan]

It would be great if when using called.withArg(arg) & called.withArgs(arg) it produced output which was not expected true but was false.

Ideally it would be nice if the output was what it was actually call with.

[jamlen]

If you called it many times should it output all the calls?

var logger = deride.stub(['info']);
//...
logger.info('Something', { message: 'a message', code: 123}, {a: 123, b: 'a long string in here'});
logger.info('Another call to Info', { message: 'another message', code: 123456}, {a: 123234, b: 'another long string in here'});
// many other calls to logger.info
//...
logger.info('talula');
logger.expect.info.called.withArgs('talula');

What should it output?

[jamesmorgan]

Maybe something like this: expected the 2nd call to have been invoked with X and not Y ...?

[jamlen]

Well you could use:

https://github.com/guzzlerio/deride#provide-access-to-individual-calls-to-a-method

var bob = deride.wrap(bob);
bob.greet('jack', 'alice');
bob.greet('bob');
bob.expect.greet.invocation(0).withArg('alice');
bob.expect.greet.invocation(1).withArg('bob');

[jamesmorgan]

Ye that would work, it would be still be nice to give better feedback on failure when using withArg[s]() 👍

[jamlen]

For something that gets called once, twice or a relatively small number it would be good to say:

Expected <method> to be called with arg: <arg> but was called with:

0: 'bob',
1: 'talula',
2: { a: 123, b: 'weqrewr'}

but if you have something that is called a lot of times like a logger that would spam the output....

So after 5 distinct calls collapse into logger was called 165 times with different values

How about that?

[jamesmorgan]

Ye sounds like a good plan. 👍