Skip to content

mdgriffith/elm-markup@3.0.1 does not compile in guida #115

@decioferreira

Description

@decioferreira

This relates to #111 (comment).

When trying to compile mdgriffith/elm-markup@3.0.1, it looks like there is an issue in the elm compiler that allows for the wrong operation. The following change seems to fix the issue on both guida and elm:

diff --git a/src/Mark/Edit.elm b/src/Mark/Edit.elm
index 0df7c1f..1b6f9fb 100644
--- a/src/Mark/Edit.elm
+++ b/src/Mark/Edit.elm
@@ -815,7 +815,7 @@ editListNested cursor lsNested =
 
                             EditMade maybeSeed maybePush newChild ->
                                 ( EditMade maybeSeed maybePush []
-                                , newChild :: pastChildren
+                                , newChild ++ pastChildren
                                 )
             )
             ( NoIdFound, [] )

As part of this ticket we should make sure to mention this fact, when converting a project from Elm to Guida. This should also be part of any script that does the conversion.

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions