-
Notifications
You must be signed in to change notification settings - Fork 567
Description
See #26338 (comment) - back in November 2017, #18364 & #18365 introduced the /lite.json representation of fronts:
Lines 36 to 39 in 8bc978e
| GET /*path/lite.json controllers.FaciaController.renderFrontJsonMinimal(path) | |
| GET /*path.emailjson controllers.FaciaController.renderFrontJson(path) | |
| GET /*path.emailtxt controllers.FaciaController.renderFrontJson(path) | |
| GET /*path.json controllers.FaciaController.renderFrontJson(path) |
The lite.json versions are actually not significantly smaller:
% aws --profile frontend s3 ls s3://aws-frontend-store/PROD/frontsapi/pressed/live/uk/fapi/
2024-05-14 12:38:40 501886 pressed.v2.adfree.json
2024-05-14 12:38:39 508012 pressed.v2.json
2024-05-14 12:38:40 352779 pressed.v2.lite.adfree.json
2024-05-14 12:38:39 358778 pressed.v2.lite.json
...and having 2 versions actually takes up additional memory that we could free up. Consequently I believe the the 'lite' versions should be completely removed.
Things to check...
See if the output of the endpoints that use the 'lite' versions (renderFrontHeadline(), renderFrontPressResult() & renderFrontJsonMinimal()) stays the same, depending whether they perform their own trimming that will work on the full versions of PressedPage, or if were relying on the trimmed nature of the 'lite' version at all.
Reactions are currently unavailable