Skip to content

Create a CDK style guide #1801

@marsavar

Description

@marsavar

Opening this issue as a result of a conversation with the DevX team.

CDK is extremely versatile, which means there are several approaches to solving any given problem, each with its own advantages and disadvantages. The purpose of a style guide would be provide guidance on the recommended way to solve common problems for consistency across the library.

Ultimately, there is a clear benefit to GuCDK consumers if resources follow the same patterns, not only in terms of API, but also in terms of usability, e.g. knowing where to look in the AWS console once a resource has been created.
Benefits of having a a style guide include: steering contributors towards the right direction, lessen the burden of PR reviewers (i.e. point contributors to the style guide instead of explaining things from scratch), help avoid having the same conversations once a consensus has been reached on how to solve an issue, etc.

Some ideas on what the style guide could include:

  • Recommended way to create policies (managed policies vs inline)
  • Recommended way to name a resource id
  • Recommended way to fix issues (i.e. introducing a breaking change vs fixing forward)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions