Balls sometimes stick together instead of bouncing.

[martinodb]

Hello!

Very nice little ball collision simulator :)
I noticed that sometimes the balls stick together instead of bouncing. Take it with a grain of salt, but I think it's because the way you defined the "approaching" function, so that sometimes the balls are not approaching (they are already going past each other) but the function thinks they are approaching, because it only depends on the velocities. I changed the definition and it seems to work better, the balls don't seem to get stuck any more. Shall I open a pull request? Sorry, I'm new to Github, I don't know how this works ;)
Here's my fork.

[gtrak]

I've noticed that too :-). PR sounds good!

…

On Sun, Apr 2, 2017 at 12:18 PM martinodb ***@***.***> wrote: Hello! Very nice little ball collision simulator :) I noticed that sometimes the balls stick together instead of bouncing. Take it with a grain of salt, but I think it's because the way you defined the "approaching" function, so that sometimes the balls are not approaching (they are already going past each other) but the function thinks they are approaching, because it only depends on the velocities. I changed the definition and it seems to work better, the balls don't seem to get stuck any more. Shall I open a pull request? Sorry, I'm new to Github, I don't know how this works ;) Here's my fork <https://github.com/martinodb/quilltest>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0CunK6HwKUhi5F8yoHztFf0FKQQ33Aks5rr8pGgaJpZM4Mw2R8> .