Code not working

[der-schmelle2]

Hello,
I'm trying to get your code for the PID controller to work.
The following problems occur:

1. your script ‘pico-pid.py’ is looking for a file named ‘picolcd.py’ to load the class ‘LCD_0inch96’. But there is only the file ‘pico-lcd-0.96.py’. I renamed the latter without further ado so that the error disappears.
2. your script ‘pico-pid.py’ is looking for a file named ‘pid.py’ to load the class ‘PID’. Unfortunately, this is not available in your repository.

Which code did you use for the PID? I can only find the code ‘micropython-simple-pid’. However, it throws errors in line 95 and line 233.

Can you possibly help me here?

Thank you very much
Peter

[grunkyb]

Hi Peter,

I think you're right about the micropython-simple-pid dependency, but I can't work out which repo I used. Please could you paste the full traceback?

In the meantime, I'll locate the device that I used for this project so I can find any additional imports that are missing from this repo.

Chris

[der-schmelle2]

Hi Chris,
the output is as follows:

Traceback (most recent call last):
  File "<stdin>", line 295, in <module>
  File "<stdin>", line 108, in mainloop
  File "pid.py", line 95, in __init__
  File "pid.py", line 242, in output_limits
TypeError: 'int' object isn't iterable

I'm using the attached files.

Thanks
Peter

Pico-LCD-PID.zip

[grunkyb]

Hi Peter,
I located the original Pico. It looks like I did a lot of development separate from VS Code. I've now synced the code, including the bits you spotted as missing. Let me know if this works, otherwise I will re-assemble all the pieces and getting it working on my end again.
Chris

[der-schmelle2]

Hi Chris,
your code is mostly working as expected. Only one problem is left.
When I press "A" to start and then "B" to activate autotune, your mainloop crashes with the following message:

Traceback (most recent call last):
  File "<stdin>", line 315, in <module>
  File "<stdin>", line 265, in mainloop
TypeError: 'dict' object isn't callable

When I press only "B", the mainloop crashes too.

Could you please fix this?

Thank you so much
Peter

[der-schmelle2]

Any Update Chris?