Skip to content

Utilized min function for verbosity line 25 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fisayoadabs wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Utilized min function for verbosity line 25 #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58f801f
commit test of changes in branch for classes (#12)
growlf Feb 11, 2024
23db7e9
Utilized min function for verbosity line 25
fisayoadabs Feb 13, 2024
475329f
Done
fisayoadabs Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Copy link
Owner

@growlf growlf Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is from an existing branch and is not needed here - once that branch is merged.

Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,11 @@ Some possible tasks to add-to/replace the default options:
- setup a reverse proxy for remote shell (outbond from container host to remote support system)
- create a container project from defined template


## Use with Portainer

Use the `portainer-compose.yml` file and modify to your hearts content.

## Notes

- https://ohmyz.sh/#install
Expand Down
3 changes: 0 additions & 3 deletions docker-compose.yml
View file
Open in desktop
Copy link
Owner

@growlf growlf Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will actually remove useful code. Please look at the other service definitions in this file.

Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ services:
tty: true
command: ["/bin/zsh"]
volumes:
- ${HOME}/.gitconfig:/home/ubuntu/.gitconfig
- ${HOME}/.ssh:/home/ubuntu/.ssh
- ${PWD}:/app
Comment on lines -16 to -18
Copy link
Owner

@growlf growlf Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for local credentials and allows development entirely within the safety of the container.

- /var/run/docker.sock:/var/run/docker.sock
network_mode: "host"

Expand Down
4 changes: 2 additions & 2 deletions src/tasks.py
View file
Open in desktop
Copy link
Owner

@growlf growlf Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes!!

Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def _set_log_level(verbose=0) -> None:
log_levels = ["CRITICAL", "ERROR", "WARNING", "INFO", "DEBUG"]

# Ensure verbosity stays within the tollerances
verbose = 4 if verbose > 4 else verbose
verbose = min(4, verbose)

# Actually set the logging level
logging.basicConfig(level=log_levels[verbose])
Expand Down Expand Up @@ -68,7 +68,7 @@ def hello(c, name="world", verbose=0):
_set_log_level(verbose)
logger.debug("Set loglevel.")

print("Hello {}!".format(name))
print(f"Hello {name}!")
logger.debug("Said hello.")


Expand Down