Configuring runtime test log for minitest through rake task

[Ben3eeE]

I am trying to even test group runtimes for minitest. We have two different CI jobs for minitest and we call this gems rake task in them. Because we have two different jobs running different tests I would want them to write a different runtime log.

I tried passing the --runtime-log argument in the rake task like this to write the log to a different filename.

      task unit: :environment do
        ci_db_setup
        Rake::Task['parallel:test'].invoke(nil, '^test/unit', nil, '--runtime-log tmp/parallel_runtime_unit.log')
      end

      task functional: :environment do
        ci_db_setup
        Rake::Task['parallel:test'].invoke(nil, '^test/functional', nil, '--runtime-log tmp/parallel_runtime_functional.log')
      end

But the setting is not respected and it still writes to the default location.

Is there some other way this can be configured?

[grosser]

the tests specifically test that this works, so seems strange :/

task type, [:count, :pattern, :options, :pass_through]

so your usage seems correct

under the hood it just calls abort unless system(*command)
so maybe call abort unless system('parallel-test ^test/unit --runtime-log tmp/parallel_runtime_unit.log')
and see how that goes

or bundle open parallel_tests and make it print the command it executes under the hood to maybe find a bug

[Ben3eeE]

The command on that line is this:

["/Users/...../parallel_tests-5.4.0/bin/parallel_test",
 "test",
 "--type",
 "test",
 "--pattern",
 "^test/functional",
 "--runtime-log",
 "tmp/parallel_runtime_functional.log"]

But still it writes tmp/parallel_runtime_test.log.

Seems that it is using tmp/parallel_runtime_functional.log for the runner In runner.rb runtimes method but the setting is not respected for writing the log. This method has the default logfile even when a custom one is supplied with the --runtime-log parameter:

parallel_tests/lib/parallel_tests/test/runtime_logger.rb

Lines 21 to 33 in 2c97ebe

	def unique_log
	with_locked_log do |logfile|
	separator = "\n"
	groups = logfile.read.split(separator).map { |line| line.split(":") }.group_by(&:first)
	lines = groups.map do |file, times|
	time = "%.2f" % times.map(&:last).map(&:to_f).sum
	"#{file}:#{time}"
	end
	logfile.rewind
	logfile.write(lines.join(separator) + separator)
	logfile.truncate(logfile.pos)
	end
	end

I am a bit unclear if I am reading the instructions correctly, because the README only mentions this CLI option for RSpec. I pass both this CLI option as shown and added this require to my test helper:

require 'parallel_tests/test/runtime_logger' if ENV['RECORD_RUNTIME']

And I run this command RECORD_RUNTIME=true PARALLEL_TEST_PROCESSORS=4 RAILS_ENV=test bundle exec rake ci:test:functional resulting in the above command.

[grosser]

yeah that's a bug :/

#1023

[grosser]

lmk if that makes it better

[Ben3eeE]

Tested the changes out and they work great. Thank you 🙇