Skip to content

fix: avoid "literal string will be frozen" warnings #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juseveno wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: avoid "literal string will be frozen" warnings #62

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
127ede2
fix dashes in elements names
juseveno Dec 7, 2022
efc5303
more concise
juseveno Dec 7, 2022
21f0615
fix: avoid literal string will be frozen warnings
juseveno Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/mediainfo.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,13 @@ def self.from_uri(input)

def self.set_singleton_method(object,name,parameters)
# Handle parameters with invalid characters (instance_variable_set throws error)
name.gsub!('.','_') if name.include?('.') ## period in name
name.downcase!
method_name = name.gsub('.', '_').gsub('-', '_').downcase

# Create singleton_method
object.instance_variable_set("@#{name}",parameters)
object.define_singleton_method name do
object.instance_variable_get "@#{name}"
object.instance_variable_set("@#{method_name}",parameters)
object.define_singleton_method method_name do
object.instance_variable_get "@#{method_name}"
object.instance_variable_get "@#{method_name}"
end
end

Expand Down