Skip to content

Commit 4d8ecb0

Browse files
committed
Disable HTTP server if metrics not specified
Currently HTTP server is needed only to serve prometheus metrics. Also, node will no longer crash when HTTP server crashes unexpectedly, as it is not necessary for properly functioning node.
1 parent 483e3b8 commit 4d8ecb0

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

lean_client/src/main.rs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ use fork_choice::{
1212
};
1313
use http_api::HttpServerConfig;
1414
use libp2p_identity::Keypair;
15-
use metrics::{METRICS, Metrics, MetricsServerConfig};
15+
use metrics::{METRICS, Metrics};
1616
use networking::gossipsub::config::GossipsubConfig;
1717
use networking::gossipsub::topic::get_topics;
1818
use networking::network::{NetworkService, NetworkServiceConfig};
@@ -377,9 +377,11 @@ async fn main() -> Result<()> {
377377

378378
let chain_outbound_sender = outbound_p2p_sender.clone();
379379

380-
let http_handle = task::spawn(async move {
381-
if let Err(err) = http_api::run_server(args.http_config).await {
382-
error!("HTTP Server failed with error: {err:?}");
380+
task::spawn(async move {
381+
if args.http_config.metrics_enabled() {
382+
if let Err(err) = http_api::run_server(args.http_config).await {
383+
error!("HTTP Server failed with error: {err:?}");
384+
}
383385
}
384386
});
385387

@@ -606,9 +608,6 @@ async fn main() -> Result<()> {
606608
_ = chain_handle => {
607609
info!("Chain service finished.");
608610
}
609-
_ = http_handle => {
610-
info!("Http service finished.");
611-
}
612611
}
613612

614613
info!("Main async task exiting...");

0 commit comments

Comments
 (0)