-
Notifications
You must be signed in to change notification settings - Fork 38
Fix instanceof Observable check #28
Copy link
Copy link
Open
Description
The current instanceof Observable check that is used in the implementation of lifted component relies on the class instance check, which in turn requires that the instance be checked against the same constructor it was created with.
However it is possible that user-created Observables come from a different version or just a different instance of the rxjs package. In that case the instanceof Observable check will always fail.
It seems that the issue of several rxjs packages in a bundle should not be affecting Focal, or if it does there should be a quick way to diagnose the issue.
One solution that I see is the adoption of symbol-observable check like it's done in Redux, etc.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels