From 2ac253263c067033bb5f755b53dafa4025fcd879 Mon Sep 17 00:00:00 2001 From: Minh Nguyen Date: Sat, 15 Nov 2025 15:38:07 +0800 Subject: [PATCH] Try/catch in TaskManager to prevent configuration failure --- .gitignore | 3 +++ .../kotlin/com/grab/plugin/sizer/TaskManager.kt | 15 ++++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index d698140..2f23d24 100644 --- a/.gitignore +++ b/.gitignore @@ -15,3 +15,6 @@ build/ # Idea non-crucial project fileS *.iws .java-version + +# Documentation folder - contains drafts, AI-generated content, and other private content not intended for public repo +docs/ diff --git a/sizer-gradle-plugin/src/main/kotlin/com/grab/plugin/sizer/TaskManager.kt b/sizer-gradle-plugin/src/main/kotlin/com/grab/plugin/sizer/TaskManager.kt index 53b3329..fcf0d4e 100644 --- a/sizer-gradle-plugin/src/main/kotlin/com/grab/plugin/sizer/TaskManager.kt +++ b/sizer-gradle-plugin/src/main/kotlin/com/grab/plugin/sizer/TaskManager.kt @@ -142,9 +142,13 @@ internal class TaskManager( ) { when { project.isAndroidLibrary -> { - val variant = variantExtractor.findMatchVariant(project) - if (variant is AndroidAppSizeVariant) { - task.dependsOn(variant.baseVariant.assembleProvider) + try { + val variant = variantExtractor.findMatchVariant(project) + if (variant is AndroidAppSizeVariant) { + task.dependsOn(variant.baseVariant.assembleProvider) + } + } catch (e: RuntimeException) { + project.logger.warn("Could not find matching variant for Android library project ${project.name}: ${e.message}") } } @@ -159,6 +163,11 @@ internal class TaskManager( project.isKotlinMultiplatform -> { task.dependsOn(project.tasks.named(KMP_JAR_TASK)) } + + else -> { + // Skip unsupported project types to avoid variant extraction errors + project.logger.debug("Skipping variant extraction for unsupported project type: ${project.name}") + } } }