Merge pull request #23 from gowerc/hotfix_rng

Hotfix rng

Author: gowerc

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: diffdf
 Type: Package
 Title: Dataframe Difference Tool
-Version: 1.0.2
+Version: 1.0.3
 Authors@R: c( 
     person("Craig" ,"Gower" , email = "craig.gower@roche.com" , role = c("cre","aut")),
     person("Kieran", "Martin" , email = "kieran.martin@roche.com" , role = "aut")

NEWS.md

@@ -1,3 +1,8 @@
+# diffdf 1.0.3
+
+- No new functionality
+- Update to make package compatible with the changes made to sampling within core R
+
 # diffdf 1.0.2
 
 - No new functionality
@@ -10,7 +15,6 @@
 - Added Travis 
 - Added CodeCov
 
-
 # diffdf 1.0.0 
 
 - Initial Release !!

cran-comments.md

@@ -1,11 +1,10 @@
 ## Release summary
 In this version I have:
-- Updated the package to be compatible with tibble 2.0.0 to fix the related automated test errors
+- Updated the package to use suppressWarnings(RNGversion("3.5.0")) wherever set.seed() has been used to make sure test results and vignette results are consistent after the planned changes to the random number generator 
 
 ## Test environments
-- local Windows 10 R 3.5.1
-- local Ubuntu 18.04.1 LTS R 3.5.2
-- Win-Builder R-devel
+- local Mac OS Mojave R 3.5.2
+- Win-Builder R-release
 - Debian Linux R-release (via rhub)
 
 ## R CMD check results

man/cast_variables.Rd

@@ -4,6 +4,7 @@ library(diffdf)
 library(purrr)
 library(tibble)
 
+suppressWarnings(RNGversion("3.5.0"))
 set.seed(20202)
 
 LENGTH <- 20 

tests/testthat/helper-create_test_data.R

@@ -7,7 +7,7 @@ context("Testing entire function")
 #
 # Set up testing datasets
 #
-
+suppressWarnings(RNGversion("3.5.0"))
 set.seed(101010223)
 
 

tests/testthat/test-core.R

@@ -1,6 +1,8 @@
 library(dplyr)
 library(diffdf)
 
+suppressWarnings(RNGversion("3.5.0"))
+
 benchmark <- function(nrow, ncol, seedin, same = T){
   set.seed(seedin)
   data1 <- rnorm(nrow*ncol)

utils/benchmarks/benchmark.R

@@ -29,7 +29,10 @@ Here we show the basic functionality of `diffdf` using a dummy data set.
 library(diffdf)
 
 LENGTH = 30
+
+suppressWarnings(RNGversion("3.5.0"))
 set.seed(12334)
+
 test_data <- tibble::tibble( 
     ID          = 1:LENGTH,
     GROUP1      = rep( c(1,2) , each = LENGTH/2),