diff --git a/lib/tasks/submissions.rake b/lib/tasks/submissions.rake index a5ab727c7..11ee31576 100644 --- a/lib/tasks/submissions.rake +++ b/lib/tasks/submissions.rake @@ -254,6 +254,8 @@ namespace :submissions do submission.answers.each_pair do |question_id, answer| next unless answer.include?("original_filename") && answer["original_filename"].blank? && answer["uploaded_file_key"].present? + Rails.logger.info "Updating blank original_filename for answer to question #{question_id} in submission with reference #{submission.reference}" + question = submission.form.page_by_id(question_id) extension = ::File.extname(answer["uploaded_file_key"]) filename = "#{question.position}-#{question.question_text.parameterize}#{extension}" @@ -263,8 +265,9 @@ namespace :submissions do submission.save! if submission.answers_previously_changed? - Rails.logger.info "Re-delivering submission with reference #{submission.reference}" - SendSubmissionJob.perform_later(submission) + Rails.logger.info "Submission for reference #{submission.reference} has been updated, retry submission with jobs:retry_failed" + else + Rails.logger.info "No filenames missing, nothing to do" end end end diff --git a/spec/lib/tasks/submissions.rake_spec.rb b/spec/lib/tasks/submissions.rake_spec.rb index adaaead17..7c1744457 100644 --- a/spec/lib/tasks/submissions.rake_spec.rb +++ b/spec/lib/tasks/submissions.rake_spec.rb @@ -775,11 +775,6 @@ "original_filename" => "1-upload-your-evidence.jpg", ) end - - it "reschedules the submission" do - task.invoke(submission.reference) - expect(SendSubmissionJob).to have_been_enqueued - end end context "when original filename is present" do