Fix organisation name when form is not in group

Author: lfdebrux

app/helpers/report_helper.rb

@@ -72,7 +72,7 @@ def report_questions_table_rows(questions)
   def report_forms_table_row(form)
     [
       govuk_link_to(form["content"]["name"], live_form_pages_path(form_id: form["form_id"])),
-      form["group"]["organisation"]["name"],
+      form.dig("group", "organisation", "name") || "",
     ]
   end
 

spec/helpers/report_helpers_spec.rb

@@ -136,6 +136,20 @@
         "Department for Testing",
       ]
     end
+
+    context "when form is not in a group" do
+      let(:forms) do
+        [
+          { "form_id" => 1, "content" => { "name" => "All question types form" }, "group" => nil },
+        ]
+      end
+
+      it "returns the empty string for the organisation name" do
+        expect(helper.report_forms_table_rows(forms).map(&:second)).to eq [
+          "",
+        ]
+      end
+    end
   end
 
   describe "#report_forms_with_routes_table_head" do
@@ -188,6 +202,20 @@
         1
       ]
     end
+
+    context "when form is not in a group" do
+      let(:forms) do
+        [
+          { "form_id" => 1, "content" => { "name" => "All question types form" }, "group" => nil },
+        ]
+      end
+
+      it "returns the empty string for the organisation name" do
+        expect(helper.report_forms_table_rows(forms).map(&:second)).to eq [
+          "",
+        ]
+      end
+    end
   end
 
   describe "#report_questions_table_head" do
@@ -228,5 +256,19 @@
         "What’s your email address?",
       ]
     end
+
+    context "when form is not in a group" do
+      let(:questions) do
+        [
+          { "type" => "question_page", "data" => { "question_text" => "Email address" }, "form" => { "form_id" => 1, "content" => { "name" => "All question types form" }, "group" => nil } },
+        ]
+      end
+
+      it "returns the empty string for the organisation name" do
+        expect(helper.report_questions_table_rows(questions).map(&:second)).to eq [
+          "",
+        ]
+      end
+    end
   end
 end