Reference Trello cards from TODO comments

Author: DavidBiddle

app/components/page_list_component/error_summary/view.rb

@@ -12,6 +12,7 @@ def self.error_id(number)
 
       def self.generate_error_message(error_name, condition:, page:)
         # TODO: route_number is hardcoded as 1 here because we know there can be only two conditions. It will need to change in future
+        # https://trello.com/c/BfkZEIgM/3446-set-route-count-dynamically-instead-of-hard-coding-it
         route_number = condition.secondary_skip? ? I18n.t("errors.page_conditions.route_number_for_any_other_answer") : 1
 
         interpolation_variables = { question_number: page.position, route_number: }

app/controllers/group_members_controller.rb

@@ -32,7 +32,8 @@ def set_group
   end
 
   def group_member_params
-    ## TODO: We are passing in host here because the admin doesn't know it's own URL to use in emails
+    # TODO: We are passing in host here because the admin doesn't know it's own URL to use in emails
+    # https://trello.com/c/HkT90mFt/3447-configure-rails-apps-to-know-their-own-urls
     params.require(:group_member_input).permit(:member_email_address).merge(role: new_member_role, group: @group, creator: current_user, host: request.host)
   end
 

app/controllers/pages/conditions_controller.rb

@@ -31,6 +31,7 @@ def create
         redirect_to new_exit_page_path(current_form.id, page.id, answer_value: condition_input.answer_value)
       else
         # TODO: Route number is hardcoded whilst we can only have one value for it
+        # https://trello.com/c/BfkZEIgM/3446-set-route-count-dynamically-instead-of-hard-coding-it
         redirect_to show_routes_path(form_id: current_form.id, page_id: page.id), success: t("banner.success.route_created", route_number: 1)
       end
     else

app/controllers/pages/exit_page_controller.rb

@@ -13,6 +13,7 @@ def create
 
     if exit_page_input.submit
       # TODO: Route number is hardcoded whilst we can only have one value for it
+      # https://trello.com/c/BfkZEIgM/3446-set-route-count-dynamically-instead-of-hard-coding-it
       redirect_to show_routes_path(form_id: current_form.id, page_id: page.id), success: t("banner.success.exit_page_created")
     else
       render template: "pages/exit_page/new", locals: { exit_page_input:, preview_html: preview_html(exit_page_input), check_preview_validation: true }, status: :unprocessable_content

app/input_objects/pages/question_input.rb

@@ -1,7 +1,8 @@
 class Pages::QuestionInput < BaseInput
   attr_accessor :question_text, :hint_text, :is_optional, :answer_type, :draft_question, :is_repeatable, :form_id
 
-  # TODO: We could lose these attributes once we have a Check your answers page
+  # TODO: We could lose these attributes once we have a 'Check your question' page
+  # https://trello.com/c/uSkzB4Sl/3-create-check-your-question-page
   attr_accessor :answer_settings, :page_heading, :guidance_markdown
 
   attr_reader :selection_options # only used for displaying error

app/models/form.rb

@@ -229,6 +229,7 @@ def update_draft_form_document
 
   def task_status_service
     # TODO: refactor this in favour of dependency injection
+    # https://trello.com/c/TVN9BNxQ/3448-refactor-formtaskstatusservice-to-use-dependency-injection
     # it can also lead to use of `allow_any_instance_of` in testing
     @task_status_service ||= TaskStatusService.new(form: self)
   end

app/models/page.rb

@@ -166,6 +166,7 @@ def destroy_secondary_skip_conditions
     # We want to delete the secondary skip for the page at the start of the route
     # That association isn't in the database, so we need to dig it out
     # TODO: what if the page owning the routes has more than two routes?
+    # https://trello.com/c/ZPFCV1C7/3462-rewrite-destroysecondaryskipconditions-to-handle-a-routing-page-with-more-than-two-routes
     goto_conditions
       .filter { |condition| condition.check_page_id == condition.routing_page_id }
       .map(&:check_page)

app/validators/allowed_email_domain_validator.rb

@@ -5,6 +5,7 @@ def validate_each(record, attribute, value)
 
       # TODO: we might not want to check against current user domain
       # when we have a proper allow list?
+      # https://trello.com/c/NQj6zljA/3449-make-email-domain-validation-check-against-allowed-domains-rather-than-just-govuk-and-the-users-current-domain
       if record.respond_to?(:current_user) && record.current_user.present?
         user_domain_with_at = record.current_user.email
           .then { |email| email[email.rindex("@")..] }

app/views/layouts/base.html.erb

@@ -15,6 +15,7 @@
     <link rel="apple-touch-icon" href="<%= vite_asset_path "#{govuk_assets_path}/images/govuk-icon-180.png"%>">
     <%# This manifest file and the icons it references are currently being served from the `public` folder. %>
     <%# TODO: update the build to either generate the manifest with references to fingerprinted assets, or automatically copy the manifest and its dependencies to `public`. %>
+    <%# https://trello.com/c/zXttaPrR/3450-update-frontend-build-to-handle-manifestjson-automatically %>
     <link rel="manifest" href="/manifest.json">
     <meta property="og:image" content="<%= vite_asset_path "#{govuk_assets_path}/images/govuk-opengraph-image.png" %>">
 

app/views/pages/conditions/edit.html.erb

@@ -1,4 +1,5 @@
 <%# TODO: route_number is hardcoded as 1 here because we know there can be only two conditions. It will need to change in the future %>
+<%# https://trello.com/c/BfkZEIgM/3446-set-route-count-dynamically-instead-of-hard-coding-it %>
 <% set_page_title(title_with_error_prefix(t('page_titles.routing_page_edit', question_number: condition_input.page.position, route_number: 1), condition_input.errors&.any?)) %>
 <% content_for :back_link, govuk_back_link_to(show_routes_path(condition_input.form.id, page_id: condition_input.page.id), t(".back_link", question_number: condition_input.page.position)) %>
 
@@ -30,31 +31,31 @@
           <option value=<%= option.id %> <% if condition_input.record.goto_page_id == option.id || (condition_input.record.skip_to_end? && option.id == "check_your_answers") %>selected<% end %>>
           <%= option.question_text %>
           </option>
-        <% end %>
-        <% unless condition_input.secondary_skip? %>
-          <optgroup label="<%= I18n.t("page_conditions.exit_page_label") %>">
-            <% if condition_input.record.exit_page? %>
-              <option value="exit_page" <% if condition_input.record.exit_page? %>selected<% end %>>
+          <% end %>
+          <% unless condition_input.secondary_skip? %>
+            <optgroup label="<%= I18n.t("page_conditions.exit_page_label") %>">
+              <% if condition_input.record.exit_page? %>
+                <option value="exit_page" <% if condition_input.record.exit_page? %>selected<% end %>>
               <%= condition_input.record.exit_page_heading %>
               </option>
-            <% else %>
-              <option value="create_exit_page">
-              <%= I18n.t("page_conditions.exit_page") %>
-              </option>
+                <% else %>
+                  <option value="create_exit_page">
+                    <%= I18n.t("page_conditions.exit_page") %>
+                  </option>
+                <% end %>
+              </optgroup>
             <% end %>
-          </optgroup>
-        <% end %>
-      <% end %>
+          <% end %>
 
-      <% if condition_input.record.exit_page? %>
-        <p class="govuk-body">
-          <%= govuk_link_to t("page_conditions.edit_exit_page", exit_page_heading: condition_input.record.exit_page_heading), edit_exit_page_path(condition_input.form.id, condition_input.page.id, condition_input.record.id) %>
-        </p>
-      <% end %>
+          <% if condition_input.record.exit_page? %>
+            <p class="govuk-body">
+              <%= govuk_link_to t("page_conditions.edit_exit_page", exit_page_heading: condition_input.record.exit_page_heading), edit_exit_page_path(condition_input.form.id, condition_input.page.id, condition_input.record.id) %>
+            </p>
+          <% end %>
 
-      <%= f.govuk_submit t("save_and_continue") do
+          <%= f.govuk_submit t("save_and_continue") do
         govuk_button_link_to "Delete route", delete_condition_path(condition_input.form.id, condition_input.page.id, condition_input.record.id), warning: true
       end %>
-    <% end %>
-  </div>
-</div>
+        <% end %>
+      </div>
+    </div>