Add whether a question has branch routes to the questions CSV report

Author: lfdebrux

app/services/reports/form_documents_service.rb

@@ -34,6 +34,12 @@ def count_secondary_skip_routes(form_document)
       secondary_skip_conditions(form_document).count
     end
 
+    def step_has_secondary_skip_route?(form_document, step)
+      secondary_skip_conditions(form_document).any? do |condition|
+        condition["check_page_id"] == step["id"]
+      end
+    end
+
     def has_payments?(form_document)
       form_document["content"]["payment_url"].present?
     end

app/services/reports/questions_csv_report_service.rb

@@ -19,6 +19,7 @@ class Reports::QuestionsCsvReportService
     "Is optional?",
     IS_REPEATABLE,
     "Has routes?",
+    "Has branch routes?",
     "Answer settings - Input type",
     "Selection settings - Only one option?",
     "Selection settings - Number of options",
@@ -68,6 +69,7 @@ def question_row(step)
       step["data"]["is_optional"],
       step["data"]["is_repeatable"],
       step["routing_conditions"].present?,
+      Reports::FormDocumentsService.step_has_secondary_skip_route?(form, step),
       step.dig("data", "answer_settings", "input_type"),
       step.dig("data", "answer_settings", "only_one_option").presence.try { |o| o.to_s == "true" },
       step.dig("data", "answer_settings", "selection_options")&.length,

spec/services/reports/form_documents_service_spec.rb

@@ -162,4 +162,35 @@ def response_headers(total, offset, limit)
       it { is_expected.to eq 0 }
     end
   end
+
+  describe ".step_has_secondary_skip_route?" do
+    let(:form_documents) { JSON.load_file file_fixture("form_documents_response.json") }
+
+    context "when step is check page for secondary skip condition" do
+      let(:form_document) { branch_route_form }
+      let(:step) { form_document["content"]["steps"][0] }
+
+      it "returns true" do
+        expect(described_class.step_has_secondary_skip_route?(form_document, step)).to be true
+      end
+    end
+
+    context "when step is not check page for secondary skip condition" do
+      let(:form_document) { branch_route_form }
+      let(:step) { form_document["content"]["steps"][3] }
+
+      it "returns false" do
+        expect(described_class.step_has_secondary_skip_route?(form_document, step)).to be false
+      end
+    end
+
+    context "when form has no secondary skip conditions" do
+      let(:form_document) { skip_route_form }
+      let(:step) { form_document["content"]["steps"][0] }
+
+      it "returns false" do
+        expect(described_class.step_has_secondary_skip_route?(form_document, step)).to be false
+      end
+    end
+  end
 end

spec/services/reports/questions_csv_report_service_spec.rb

@@ -45,6 +45,7 @@
         "false",
         "true",
         "false",
+        "false",
         "single_line",
         nil,
         nil,
@@ -74,6 +75,7 @@
         "true",
         "false",
         "false",
+        "false",
         nil,
         "false",
         "3",
@@ -103,6 +105,7 @@
         "false",
         "false",
         "false",
+        "false",
         "full_name",
         nil,
         nil,
@@ -112,6 +115,36 @@
     end
 
     it "has expected values for question with routing conditions" do
+      csv = csv_reports_service.csv
+      rows = CSV.parse(csv)
+      routing_question_row = rows.detect { |row| row.include? "Would you like to submit anonymously?" }
+      expect(routing_question_row).to eq([
+        "4",
+        "live",
+        "Skip route form",
+        group.organisation.name,
+        group.organisation.id.to_s,
+        group.name,
+        group.external_id,
+        "1",
+        "Would you like to submit anonymously?",
+        "selection",
+        nil,
+        nil,
+        nil,
+        "false",
+        "false",
+        "true",
+        "false",
+        nil,
+        "true",
+        "2",
+        nil,
+        "{\"only_one_option\" => \"true\", \"selection_options\" => [{\"name\" => \"Yes\"}, {\"name\" => \"No\"}]}",
+      ])
+    end
+
+    it "has expected values for question with branch routing conditions" do
       csv = csv_reports_service.csv
       rows = CSV.parse(csv)
       routing_question_row = rows.detect { |row| row.include? "How many times have you filled out this form?" }
@@ -132,6 +165,7 @@
         "false",
         "false",
         "true",
+        "true",
         nil,
         "true",
         "2",