Rename csv methods

Author: lfdebrux

app/controllers/reports_controller.rb

@@ -24,7 +24,7 @@ def questions_with_add_another_answer
     questions = Reports::FeatureReportService.new(forms).questions_with_add_another_answer
 
     if params[:format] == "csv"
-      send_data Reports::QuestionsCsvReportService.new(questions).questions_csv,
+      send_data Reports::QuestionsCsvReportService.new(questions).csv,
                 type: "text/csv; charset=iso-8859-1",
                 disposition: "attachment; filename=#{csv_filename('live_questions_with_add_another_answer_report')}"
     else
@@ -37,7 +37,7 @@ def forms_with_routes
     forms = Reports::FeatureReportService.new(forms).forms_with_routes
 
     if params[:format] == "csv"
-      send_data Reports::FormsCsvReportService.new(forms).forms_csv,
+      send_data Reports::FormsCsvReportService.new(forms).csv,
                 type: "text/csv; charset=iso-8859-1",
                 disposition: "attachment; filename=#{csv_filename('live_forms_with_routes_report')}"
     else
@@ -50,7 +50,7 @@ def forms_with_payments
     forms = Reports::FeatureReportService.new(forms).forms_with_payments
 
     if params[:format] == "csv"
-      send_data Reports::FormsCsvReportService.new(forms).forms_csv,
+      send_data Reports::FormsCsvReportService.new(forms).csv,
                 type: "text/csv; charset=iso-8859-1",
                 disposition: "attachment; filename=#{csv_filename('live_forms_with_payments_report')}"
     else
@@ -63,7 +63,7 @@ def forms_with_csv_submission_enabled
     forms = Reports::FeatureReportService.new(forms).forms_with_csv_submission_enabled
 
     if params[:format] == "csv"
-      send_data Reports::FormsCsvReportService.new(forms).forms_csv,
+      send_data Reports::FormsCsvReportService.new(forms).csv,
                 type: "text/csv; charset=iso-8859-1",
                 disposition: "attachment; filename=#{csv_filename('live_forms_with_csv_submission_enabled_report')}"
     else
@@ -114,7 +114,7 @@ def csv_downloads; end
   def live_forms_csv
     forms = Reports::FormDocumentsService.live_form_documents
 
-    send_data Reports::FormsCsvReportService.new(forms).forms_csv,
+    send_data Reports::FormsCsvReportService.new(forms).csv,
               type: "text/csv; charset=iso-8859-1",
               disposition: "attachment; filename=#{csv_filename('live_forms_report')}"
   end
@@ -128,7 +128,7 @@ def live_questions_csv
                   Reports::FeatureReportService.new(forms).questions
                 end
 
-    send_data Reports::QuestionsCsvReportService.new(questions).questions_csv,
+    send_data Reports::QuestionsCsvReportService.new(questions).csv,
               type: "text/csv; charset=iso-8859-1",
               disposition: "attachment; filename=#{questions_csv_filename(answer_type)}"
   end

app/services/reports/forms_csv_report_service.rb

@@ -30,7 +30,7 @@ def initialize(form_documents)
     @form_documents = form_documents
   end
 
-  def forms_csv
+  def csv
     CSV.generate do |csv|
       csv << FORM_CSV_HEADERS
 

app/services/reports/questions_csv_report_service.rb

@@ -34,7 +34,7 @@ def initialize(question_page_documents)
     @question_page_documents = question_page_documents
   end
 
-  def questions_csv
+  def csv
     CSV.generate do |csv|
       csv << QUESTIONS_CSV_HEADERS
 

spec/services/reports/forms_csv_report_service_spec.rb

@@ -16,15 +16,15 @@
     GroupForm.create!(form_id: 4, group:)
   end
 
-  describe "#forms_csv" do
+  describe "#csv" do
     it "returns a CSV with a header row and a row for each form" do
-      csv = csv_reports_service.forms_csv
+      csv = csv_reports_service.csv
       rows = CSV.parse(csv)
       expect(rows.length).to eq 5
     end
 
     it "has expected values" do
-      csv = csv_reports_service.forms_csv
+      csv = csv_reports_service.csv
       rows = CSV.parse(csv)
       expect(rows[1]).to eq([
         "1",

spec/services/reports/questions_csv_report_service_spec.rb

@@ -17,15 +17,15 @@
     GroupForm.create!(form_id: 4, group:)
   end
 
-  describe "#questions_csv" do
+  describe "#csv" do
     it "returns a CSV with a header row and a rows for each question" do
-      csv = csv_reports_service.questions_csv
+      csv = csv_reports_service.csv
       rows = CSV.parse(csv)
       expect(rows.length).to eq 18
     end
 
     it "has expected values for text question" do
-      csv = csv_reports_service.questions_csv
+      csv = csv_reports_service.csv
       rows = CSV.parse(csv)
       text_question_row = rows.detect { |row| row.include? "Single line of text" }
       expect(text_question_row).to eq([
@@ -54,7 +54,7 @@
     end
 
     it "has expected values for selection question" do
-      csv = csv_reports_service.questions_csv
+      csv = csv_reports_service.csv
       rows = CSV.parse(csv)
       selection_question_row = rows.detect { |row| row.include? "Selection from a list of options" }
       expect(selection_question_row).to eq([
@@ -83,7 +83,7 @@
     end
 
     it "has expected values for name question" do
-      csv = csv_reports_service.questions_csv
+      csv = csv_reports_service.csv
       rows = CSV.parse(csv)
       name_question_row = rows.detect { |row| row.include? "What’s your name?" }
       expect(name_question_row).to eq([
@@ -112,7 +112,7 @@
     end
 
     it "has expected values for question with routing conditions" do
-      csv = csv_reports_service.questions_csv
+      csv = csv_reports_service.csv
       rows = CSV.parse(csv)
       routing_question_row = rows.detect { |row| row.include? "How many times have you filled out this form?" }
       expect(routing_question_row).to eq([