Change questions_with_answer_type page download CSV link to go to self

Rather than going to the reports#live_csv_questions action for the CSV
of questions with answer type, we should use the same pattern as for the
other feature reports and use the same URL but with a `.csv` appended
for the CSV download link on the questions with answer type report page.

This commit updates the #questions_with_answer_type action to accept
format `csv` as well as `html`, same as the other feature report
actions, and uses that in the view template. We can then also simplify
the live_questions_csv action.

This probably should have been done in PR #1976, but it was missed.

Author: lfdebrux

app/controllers/reports_controller.rb

@@ -16,7 +16,13 @@ def questions_with_answer_type
     forms = Reports::FormDocumentsService.live_form_documents
     questions = Reports::FeatureReportService.new(forms).questions_with_answer_type(answer_type)
 
-    render template: "reports/questions_with_answer_type", locals: { answer_type:, questions: }
+    if params[:format] == "csv"
+      send_data Reports::QuestionsCsvReportService.new(questions).csv,
+                type: "text/csv; charset=iso-8859-1",
+                disposition: "attachment; filename=#{questions_csv_filename(answer_type)}"
+    else
+      render template: "reports/questions_with_answer_type", locals: { answer_type:, questions: }
+    end
   end
 
   def questions_with_add_another_answer
@@ -120,17 +126,12 @@ def live_forms_csv
   end
 
   def live_questions_csv
-    answer_type = params[:answer_type]
     forms = Reports::FormDocumentsService.live_form_documents
-    questions = if answer_type
-                  Reports::FeatureReportService.new(forms).questions_with_answer_type(answer_type)
-                else
-                  Reports::FeatureReportService.new(forms).questions
-                end
+    questions = Reports::FeatureReportService.new(forms).questions
 
     send_data Reports::QuestionsCsvReportService.new(questions).csv,
               type: "text/csv; charset=iso-8859-1",
-              disposition: "attachment; filename=#{questions_csv_filename(answer_type)}"
+              disposition: "attachment; filename=#{csv_filename('live_questions_report')}"
   end
 
 private

app/views/reports/questions_with_answer_type.html.erb

@@ -4,7 +4,7 @@
   <div class="govuk-grid-column-two-thirds">
     <h1 class="govuk-heading-l"><%= t(".heading", answer_type: t("helpers.label.page.answer_type_options.names.#{answer_type}").downcase) %></h1>
 
-    <p><%=govuk_link_to(t(".download_csv"), report_live_questions_csv_path(answer_type:))%></p>
+    <p><%=govuk_link_to(t(".download_csv"), url_for(format: :csv))%></p>
   </div>
 
   <div class="govuk-grid-column-full">

spec/requests/reports_controller_spec.rb

@@ -828,6 +828,28 @@
       end
     end
 
+    describe "#questions_with_answer_type as csv" do
+      before do
+        login_as_super_admin_user
+
+        travel_to Time.utc(2025, 5, 15, 15, 31, 57)
+
+        get report_questions_with_answer_type_path(answer_type: "text", format: :csv)
+      end
+
+      it_behaves_like "csv response"
+
+      it "responds with an attachment content-disposition header" do
+        expect(response.headers["content-disposition"]).to match("attachment; filename=live_questions_report_text_answer_type-2025-05-15 15:31:57 UTC.csv")
+      end
+
+      it "has expected response body" do
+        csv = CSV.parse(response.body, headers: true)
+        expect(csv.headers).to eq Reports::QuestionsCsvReportService::QUESTIONS_CSV_HEADERS
+        expect(csv.length).to eq 5
+      end
+    end
+
     describe "#questions_with_add_another_answer as csv" do
       before do
         login_as_super_admin_user

spec/views/reports/questions_with_answer_type.html.erb_spec.rb

@@ -8,8 +8,12 @@
     ]
   end
 
+  let(:answer_type) { "email" }
+
   before do
-    render locals: { answer_type: "email", questions: }
+    controller.request.path_parameters[:answer_type] = answer_type
+
+    render locals: { answer_type:, questions: }
   end
 
   describe "page title" do
@@ -23,7 +27,7 @@
   end
 
   it "has a link to download the CSV" do
-    expect(rendered).to have_link("Download all questions in live forms with this answer type as a CSV file", href: report_live_questions_csv_path(answer_type: "email"))
+    expect(rendered).to have_link("Download all questions in live forms with this answer type as a CSV file", href: report_questions_with_answer_type_path(answer_type: "email", format: :csv))
   end
 
   describe "questions table" do