diff --git a/CHANGELOG.md b/CHANGELOG.md index 9f9709af9..ce4278331 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -279,7 +279,7 @@ - Prefer https URLs for cloning from GitHub, add SYNTHTOOL_USE_SSH to use ssh ([#120](https://github.com/googleapis/synthtool/pull/120)) - Drop the PR template for nodejs ([#117](https://github.com/googleapis/synthtool/pull/117)) - Update github issue templates ([#116](https://github.com/googleapis/synthtool/pull/116)) -- Incude build/ in eslint ignore ([#115](https://github.com/googleapis/synthtool/pull/115)) +- Include build/ in eslint ignore ([#115](https://github.com/googleapis/synthtool/pull/115)) - feat: make npm link work for system tests ([#114](https://github.com/googleapis/synthtool/pull/114)) - fix: update nodejs issue templates ([#112](https://github.com/googleapis/synthtool/pull/112)) - feat(node): add node11 test env ([#110](https://github.com/googleapis/synthtool/pull/110)) @@ -437,7 +437,7 @@ ### New Features - add template for .circleci config for node libraries (#6, #7, #17) -- Warn when copy/move/replace can not find any sources (#4) +- Warn when copy/move/replace cannot find any sources (#4) - Add warning for non-replacement - Add an update checker. - added get_workflow_name.py (#15) diff --git a/setup.py b/setup.py index a52340abd..5893e0ac3 100644 --- a/setup.py +++ b/setup.py @@ -55,7 +55,7 @@ 'Operating System :: OS Independent', 'Topic :: Internet', ], - platforms='Posix; MacOS X; Windows', + platforms='POSIX; MacOS X; Windows', packages=packages, install_requires=dependencies, include_package_data=True, diff --git a/synthtool/README.md b/synthtool/README.md index 325fd26a5..0d376bbcc 100644 --- a/synthtool/README.md +++ b/synthtool/README.md @@ -1,6 +1,6 @@ # SynthTool (for client libraries) -![Diagram of relationship between Autosynth, Synthtool, and Github](../images/flow.png) +![Diagram of relationship between Autosynth, Synthtool, and GitHub](../images/flow.png) This tool helps to generate and layout cloud client libraries. Synthtool runs the [GAPIC (Generated API Client) Generator][GAPIC] via [Google API Artifact Manager (artman)][artman]. diff --git a/synthtool/gcp/common.py b/synthtool/gcp/common.py index f6a26c2eb..a3aabd840 100644 --- a/synthtool/gcp/common.py +++ b/synthtool/gcp/common.py @@ -298,7 +298,7 @@ def py_library(self, **kwargs) -> Path: # Add kwargs to signal that UPGRADING.md should be included in docs/index.rst if it exists if Path("docs/UPGRADING.md").exists() or Path("docs/UPGRADING.rst").exists(): - kwargs["include_uprading_doc"] = True + kwargs["include_upgrading_doc"] = True # If the directory `google/cloud` exists, add kwargs to signal that the client library is for a Cloud API if Path("google/cloud").exists(): @@ -439,7 +439,7 @@ def detect_versions( default_first: Optional[bool] = None, ) -> List[str]: """ - Detects the versions a library has, based on distinct folders + Detects the versions of a library, based on distinct folders within path. This is based on the fact that our GAPIC libraries are structured as follows: @@ -531,7 +531,7 @@ def _load_repo_metadata( * `api_id` - The API ID associated with the service. Fully qualified identifier use to enable a service in the cloud platform (e.g. monitoring.googleapis.com) * `requires_billing` - Whether or not the API requires billing to be configured on the - customer's acocunt + customer's account Args: metadata_file (str, optional): Path to the metadata json file @@ -555,7 +555,7 @@ def _get_default_branch_name(repository_name: str) -> str: First checks environment variable DEFAULT_BRANCH_PATH. If found, it reads the contents of the file at DEFAULT_BRANCH_PATH and returns it. - Then checks environment varabile DEFAULT_BRANCH, and returns it if found. + Then checks environment variable DEFAULT_BRANCH, and returns it if found. """ default_branch_path = os.getenv("DEFAULT_BRANCH_PATH") if default_branch_path: diff --git a/synthtool/gcp/gapic_microgenerator.py b/synthtool/gcp/gapic_microgenerator.py index ff799227b..44c48b13e 100644 --- a/synthtool/gcp/gapic_microgenerator.py +++ b/synthtool/gcp/gapic_microgenerator.py @@ -140,7 +140,7 @@ def _generate_code( sep = os.path.sep # try to figure out user ID and stay compatible. - # If there is no `os.getuid()`, fallback to `getpass.getuser()` + # If there is no `os.getuid()`, fall back to `getpass.getuser()` getuid = getattr(os, "getuid", None) if getuid: user = str(getuid()) diff --git a/synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/bug_report.yml b/synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/bug_report.yml index 435800444..655627fa7 100644 --- a/synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/bug_report.yml @@ -63,7 +63,7 @@ body: - type: input attributes: label: > - Link to the code that reproduces this issue. A link to a **public** Github Repository or gist with a minimal + Link to the code that reproduces this issue. A link to a **public** GitHub Repository or gist with a minimal reproduction. description: > **Skipping this or providing an invalid link will result in the issue being closed** diff --git a/synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/documentation_request.yml b/synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/documentation_request.yml index 3a439195e..0b5db6f87 100644 --- a/synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/documentation_request.yml +++ b/synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/documentation_request.yml @@ -5,7 +5,7 @@ body: attributes: value: > Please use this issue type to log documentation requests against the library itself. - These requests should involve documentation on Github (`.md` files), and should relate to the library + These requests should involve documentation on GitHub (`.md` files), and should relate to the library itself. If you have questions or documentation requests for an API, please reach out to the API tracker itself. diff --git a/synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/processs_request.md b/synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/process_request.md similarity index 100% rename from synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/processs_request.md rename to synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/process_request.md diff --git a/synthtool/gcp/templates/node_library/.github/scripts/fixtures/invalidIssueBody.txt b/synthtool/gcp/templates/node_library/.github/scripts/fixtures/invalidIssueBody.txt index 504bd6690..8572ad67c 100644 --- a/synthtool/gcp/templates/node_library/.github/scripts/fixtures/invalidIssueBody.txt +++ b/synthtool/gcp/templates/node_library/.github/scripts/fixtures/invalidIssueBody.txt @@ -13,7 +13,7 @@ N/A -### Link to the code that reproduces this issue. A link to a **public** Github Repository or gist with a minimal reproduction. +### Link to the code that reproduces this issue. A link to a **public** GitHub Repository or gist with a minimal reproduction. not-a-link diff --git a/synthtool/gcp/templates/node_library/.github/scripts/fixtures/validIssueBody.txt b/synthtool/gcp/templates/node_library/.github/scripts/fixtures/validIssueBody.txt index 6e0ace338..29fcc58bc 100644 --- a/synthtool/gcp/templates/node_library/.github/scripts/fixtures/validIssueBody.txt +++ b/synthtool/gcp/templates/node_library/.github/scripts/fixtures/validIssueBody.txt @@ -13,7 +13,7 @@ N/A -### Link to the code that reproduces this issue. A link to a **public** Github Repository or gist with a minimal reproduction. +### Link to the code that reproduces this issue. A link to a **public** GitHub Repository or gist with a minimal reproduction. https://gist.github.com/orgads/13cbf44c91923da27d8772b5f10489c9 diff --git a/synthtool/gcp/templates/node_library/.github/scripts/fixtures/validIssueBodyDifferentLinkLocation.txt b/synthtool/gcp/templates/node_library/.github/scripts/fixtures/validIssueBodyDifferentLinkLocation.txt index 984a420e3..9854491c3 100644 --- a/synthtool/gcp/templates/node_library/.github/scripts/fixtures/validIssueBodyDifferentLinkLocation.txt +++ b/synthtool/gcp/templates/node_library/.github/scripts/fixtures/validIssueBodyDifferentLinkLocation.txt @@ -40,7 +40,7 @@ TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or at addChunk (node:internal/streams/readable:559:12) { code: 'ERR_INVALID_ARG_TYPE' -### Link to the code that reproduces this issue. A link to a **public** Github Repository with a minimal reproduction. +### Link to the code that reproduces this issue. A link to a **public** GitHub Repository with a minimal reproduction. https://gist.github.com/orgads/13cbf44c91923da27d8772b5f10489c9 diff --git a/synthtool/gcp/templates/node_library/.kokoro/samples-test.sh b/synthtool/gcp/templates/node_library/.kokoro/samples-test.sh index e07413af6..7f14fb5c9 100755 --- a/synthtool/gcp/templates/node_library/.kokoro/samples-test.sh +++ b/synthtool/gcp/templates/node_library/.kokoro/samples-test.sh @@ -16,7 +16,7 @@ set -eo pipefail -# Ensure the npm global directory is writable, otherwise rebuild `npm` +# Ensure the npm global directory is writable; otherwise, rebuild `npm` mkdir -p $NPM_CONFIG_PREFIX npm config -g ls || npm i -g npm@`npm --version` diff --git a/synthtool/gcp/templates/node_library/.kokoro/trampoline.sh b/synthtool/gcp/templates/node_library/.kokoro/trampoline.sh index f693a1ce7..370da3608 100755 --- a/synthtool/gcp/templates/node_library/.kokoro/trampoline.sh +++ b/synthtool/gcp/templates/node_library/.kokoro/trampoline.sh @@ -13,7 +13,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -# This file is not used any more, but we keep this file for making it +# This file is not used anymore, but we keep this file for making it # easy to roll back. # TODO: Remove this file from the template. diff --git a/synthtool/gcp/templates/node_library/.kokoro/trampoline_v2.sh b/synthtool/gcp/templates/node_library/.kokoro/trampoline_v2.sh index 5d6cfcca5..8ab590c8f 100755 --- a/synthtool/gcp/templates/node_library/.kokoro/trampoline_v2.sh +++ b/synthtool/gcp/templates/node_library/.kokoro/trampoline_v2.sh @@ -119,7 +119,7 @@ TRAMPOLINE_WORKSPACE="${TRAMPOLINE_WORKSPACE:-/workspace}" pass_down_envvars=( # TRAMPOLINE_V2 variables. - # Tells scripts whether they are running as part of CI or not. + # Tells scripts whether or not they are running as part of CI. "RUNNING_IN_CI" # Indicates which CI system we're in. "TRAMPOLINE_CI" @@ -241,7 +241,7 @@ function repo_root() { } # Detect the project root. In CI builds, we assume the script is in -# the git tree and traverse from there, otherwise, traverse from `pwd` +# the git tree and traverse from there; otherwise, traverse from `pwd` # to find `.git` directory. if [[ "${RUNNING_IN_CI:-}" == "true" ]]; then PROGRAM_PATH="$(realpath "$0")" @@ -394,7 +394,7 @@ docker_flags=( # Use the host network. "--network=host" - # Run in priviledged mode. We are not using docker for sandboxing or + # Run in privileged mode. We are not using docker for sandboxing or # isolation, just for packaging our dev tools. "--privileged" @@ -444,7 +444,7 @@ do done # If arguments are given, all arguments will become the commands run -# in the container, otherwise run TRAMPOLINE_BUILD_FILE. +# in the container; otherwise, run TRAMPOLINE_BUILD_FILE. if [[ $# -ge 1 ]]; then log_yellow "Running the given commands '" "${@:1}" "' in the container." readonly commands=("${@:1}") diff --git a/synthtool/gcp/templates/python_library/.kokoro/test-samples-impl.sh b/synthtool/gcp/templates/python_library/.kokoro/test-samples-impl.sh index 53e365bc4..b45cfafff 100755 --- a/synthtool/gcp/templates/python_library/.kokoro/test-samples-impl.sh +++ b/synthtool/gcp/templates/python_library/.kokoro/test-samples-impl.sh @@ -36,7 +36,7 @@ env | grep KOKORO # `virtualenv==20.26.6` is added for Python 3.7 compatibility python3.9 -m pip install --upgrade --quiet nox virtualenv==20.26.6 -# Use secrets acessor service account to get secrets +# Use secrets assessor service account to get secrets if [[ -f "${KOKORO_GFILE_DIR}/secrets_viewer_service_account.json" ]]; then gcloud auth activate-service-account \ --key-file="${KOKORO_GFILE_DIR}/secrets_viewer_service_account.json" \ diff --git a/synthtool/gcp/templates/python_library/.kokoro/trampoline_v2.sh b/synthtool/gcp/templates/python_library/.kokoro/trampoline_v2.sh index 35fa52923..66c1436cf 100755 --- a/synthtool/gcp/templates/python_library/.kokoro/trampoline_v2.sh +++ b/synthtool/gcp/templates/python_library/.kokoro/trampoline_v2.sh @@ -118,7 +118,7 @@ TRAMPOLINE_WORKSPACE="${TRAMPOLINE_WORKSPACE:-/workspace}" pass_down_envvars=( # TRAMPOLINE_V2 variables. - # Tells scripts whether they are running as part of CI or not. + # Tells scripts whether or not they are running as part of CI. "RUNNING_IN_CI" # Indicates which CI system we're in. "TRAMPOLINE_CI" @@ -238,7 +238,7 @@ function repo_root() { } # Detect the project root. In CI builds, we assume the script is in -# the git tree and traverse from there, otherwise, traverse from `pwd` +# the git tree and traverse from there; otherwise, traverse from `pwd` # to find `.git` directory. if [[ "${RUNNING_IN_CI:-}" == "true" ]]; then PROGRAM_PATH="$(realpath "$0")" @@ -391,7 +391,7 @@ docker_flags=( # Use the host network. "--network=host" - # Run in priviledged mode. We are not using docker for sandboxing or + # Run in privileged mode. We are not using docker for sandboxing or # isolation, just for packaging our dev tools. "--privileged" @@ -441,7 +441,7 @@ do done # If arguments are given, all arguments will become the commands run -# in the container, otherwise run TRAMPOLINE_BUILD_FILE. +# in the container; otherwise, run TRAMPOLINE_BUILD_FILE. if [[ $# -ge 1 ]]; then log_yellow "Running the given commands '" "${@:1}" "' in the container." readonly commands=("${@:1}") diff --git a/synthtool/gcp/templates/python_library/README.rst b/synthtool/gcp/templates/python_library/README.rst index cc9ace4e3..992839980 100644 --- a/synthtool/gcp/templates/python_library/README.rst +++ b/synthtool/gcp/templates/python_library/README.rst @@ -191,7 +191,7 @@ Logging details logger from the `google`-level logger. If you need the events to be propagated to the root logger, you must explicitly set :code:`logging.getLogger("google").propagate = True` in your code. #. You can mix the different logging configurations above for different Google modules. For example, you may want use a code-based logging configuration for - one library, but decide you need to also set up environment-based logging configuration for another library. + one library, but decide you also need to set up environment-based logging configuration for another library. #. If you attempt to use both code-based and environment-based configuration for the same module, the environment-based configuration will be ineffectual if the code -based configuration gets applied first. diff --git a/synthtool/gcp/templates/python_library/docs/index.rst b/synthtool/gcp/templates/python_library/docs/index.rst index e1aa6c7bb..08bf98fd6 100644 --- a/synthtool/gcp/templates/python_library/docs/index.rst +++ b/synthtool/gcp/templates/python_library/docs/index.rst @@ -14,7 +14,7 @@ API Reference {{ version }}/services_ {{ version }}/types_ {% endfor %} -{% if include_uprading_doc %} +{% if include_upgrading_doc %} Migration Guide --------------- diff --git a/synthtool/gcp/templates/python_mono_repo_library/README.rst b/synthtool/gcp/templates/python_mono_repo_library/README.rst index 75ce38875..6658c8ebf 100644 --- a/synthtool/gcp/templates/python_mono_repo_library/README.rst +++ b/synthtool/gcp/templates/python_mono_repo_library/README.rst @@ -191,7 +191,7 @@ Logging details logger from the `google`-level logger. If you need the events to be propagated to the root logger, you must explicitly set :code:`logging.getLogger("google").propagate = True` in your code. #. You can mix the different logging configurations above for different Google modules. For example, you may want use a code-based logging configuration for - one library, but decide you need to also set up environment-based logging configuration for another library. + one library, but decide you also need to set up environment-based logging configuration for another library. #. If you attempt to use both code-based and environment-based configuration for the same module, the environment-based configuration will be ineffectual if the code -based configuration gets applied first. diff --git a/synthtool/gcp/templates/python_mono_repo_library/docs/index.rst b/synthtool/gcp/templates/python_mono_repo_library/docs/index.rst index dce5fc83b..23398b1b2 100644 --- a/synthtool/gcp/templates/python_mono_repo_library/docs/index.rst +++ b/synthtool/gcp/templates/python_mono_repo_library/docs/index.rst @@ -14,7 +14,7 @@ API Reference {{ version }}/services_ {{ version }}/types_ {% endfor %} -{% if include_uprading_doc %} +{% if include_upgrading_doc %} Migration Guide --------------- diff --git a/synthtool/gcp/templates/python_samples/README.md b/synthtool/gcp/templates/python_samples/README.md index 570259ebb..565638e6f 100644 --- a/synthtool/gcp/templates/python_samples/README.md +++ b/synthtool/gcp/templates/python_samples/README.md @@ -3,7 +3,7 @@ ## Python Samples for {{ metadata['repo']['name_pretty'] }} -This directory contains samples for {{ metadata['repo']['name_pretty'] }}, which may be used as a refererence for how to use this product. {% if metadata['repo']['custom_content'] is defined %} +This directory contains samples for {{ metadata['repo']['name_pretty'] }}, which may be used as a reference for how to use this product. {% if metadata['repo']['custom_content'] is defined %} {{ metadata['repo']['custom_content']}}{% endif %}{% if metadata['repo']['samples']|length %} Samples, quickstarts, and other documentation are available at cloud.google.com. {% for sample in range(metadata['repo']['samples']|length) %} @@ -18,7 +18,7 @@ Samples, quickstarts, and other documentation are available at Dict[str, Any]: Returns: Dictionary of metadata. Includes the entire parsed contents of the package.json file if present. Other expected fields: - * quickstart (str): Contents of the quickstart snippet if available, otherwise, "" + * quickstart (str): Contents of the quickstart snippet if available; otherwise, "" * samples (List[Dict[str, str]]): List of available samples. See synthtool.gcp.samples.all_samples() """ metadata = {} @@ -404,7 +404,7 @@ def walk_through_owlbot_dirs(dir: Path, search_for_changed_files: bool): if search_for_changed_files: try: # Need to run this step first in the post processor since we only clone - # the branch the PR is on in the Docker container + # the branch that the PR is on in the Docker container output = subprocess.run( ["git", "fetch", "origin", "main:main", "--deepen=200"] ) diff --git a/synthtool/languages/python_mono_repo.py b/synthtool/languages/python_mono_repo.py index c53706d48..e075b68e5 100644 --- a/synthtool/languages/python_mono_repo.py +++ b/synthtool/languages/python_mono_repo.py @@ -158,7 +158,7 @@ def apply_client_specific_post_processing( - replacement: paths: [] before: "The string to search for in the specified paths" - after: "The string to replace in the the specified paths", + after: "The string to replace in the specified paths", count: ``` diff --git a/synthtool/protos/README.md b/synthtool/protos/README.md index 2e6ee77c1..a0ed5a473 100644 --- a/synthtool/protos/README.md +++ b/synthtool/protos/README.md @@ -1,6 +1,6 @@ # Synthtool and Autosynth Protocol -**Synthtool** generates client library source code according to the currrent +**Synthtool** generates client library source code according to the current state of the source repo, and upstream repos like [googleapis/googleapis](https://github.com/googleapis/googleapis). diff --git a/synthtool/py_templating_instructions/README.md b/synthtool/py_templating_instructions/README.md index ecf293620..c5fae4b79 100644 --- a/synthtool/py_templating_instructions/README.md +++ b/synthtool/py_templating_instructions/README.md @@ -25,5 +25,5 @@ Each sample in `samples` has the attributes: - `file` : The main file associated with this sample - `runnable` (Optional) : Either True/False, depending on whether this sample is made to be run by running the above file name, or not. - `custom_content` (Optional) : This is custom content that appears after all other information generated about the sample -- `override_path` (Optional): If you would like to have a seperate README generate for this file in a different folder within the directory that holds the samples, ex. a folder named `quickstart`, specify that relative path here. +- `override_path` (Optional): If you would like to have a separate README generate for this file in a different folder within the directory that holds the samples, ex. a folder named `quickstart`, specify that relative path here. If multiple samples have the same override path, the README in that folder will contain info for all those samples. diff --git a/synthtool/sources/git.py b/synthtool/sources/git.py index 55c3e2b61..0cbe050eb 100644 --- a/synthtool/sources/git.py +++ b/synthtool/sources/git.py @@ -80,7 +80,7 @@ def clone( """Clones a remote git repo. Will not actually clone the repo if it's already local via two ways: - 1. It's in the cache (the default destitination). + 1. It's in the cache (the default destination). 2. It was supplied via the preconfig file. Arguments: diff --git a/synthtool/transforms.py b/synthtool/transforms.py index 0961e73d6..7bafe2f31 100644 --- a/synthtool/transforms.py +++ b/synthtool/transforms.py @@ -77,8 +77,8 @@ def _merge_file( source_path: Path, dest_path: Path, merge: Callable[[str, str, Path], str] ): """ - Writes to the destination the result of merging the source with the - existing destination contents, using the given merge function. + Writes the result of merging the source with the existing destination + contents using the given merge function to the destination. The merge function must take three arguments: the source contents, the old destination contents, and a Path to the file to be written. @@ -159,11 +159,11 @@ def dont_overwrite( files. """ - def merge(source_text: str, destinaton_text: str, file_path: Path) -> str: + def merge(source_text: str, destination_text: str, file_path: Path) -> str: for pattern in patterns: if file_path.match(str(pattern)): logger.debug(f"Preserving existing contents of {file_path}.") - return destinaton_text + return destination_text return source_text return merge diff --git a/tests/fixtures/nodejs-dlp-with-staging/.kokoro/release/publish.cfg b/tests/fixtures/nodejs-dlp-with-staging/.kokoro/release/publish.cfg index 061f3c242..2e6cc2760 100644 --- a/tests/fixtures/nodejs-dlp-with-staging/.kokoro/release/publish.cfg +++ b/tests/fixtures/nodejs-dlp-with-staging/.kokoro/release/publish.cfg @@ -27,7 +27,7 @@ before_action { } } -# Fetch magictoken to use with Magic Github Proxy +# Fetch magictoken to use with Magic GitHub Proxy before_action { fetch_keystore { keystore_resource { @@ -37,7 +37,7 @@ before_action { } } -# Fetch api key to use with Magic Github Proxy +# Fetch api key to use with Magic GitHub Proxy before_action { fetch_keystore { keystore_resource { diff --git a/tests/fixtures/nodejs-dlp-with-staging/.kokoro/trampoline.sh b/tests/fixtures/nodejs-dlp-with-staging/.kokoro/trampoline.sh index f693a1ce7..370da3608 100755 --- a/tests/fixtures/nodejs-dlp-with-staging/.kokoro/trampoline.sh +++ b/tests/fixtures/nodejs-dlp-with-staging/.kokoro/trampoline.sh @@ -13,7 +13,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -# This file is not used any more, but we keep this file for making it +# This file is not used anymore, but we keep this file for making it # easy to roll back. # TODO: Remove this file from the template. diff --git a/tests/fixtures/nodejs-dlp-with-staging/.kokoro/trampoline_v2.sh b/tests/fixtures/nodejs-dlp-with-staging/.kokoro/trampoline_v2.sh index 4d0311212..56c02ce62 100755 --- a/tests/fixtures/nodejs-dlp-with-staging/.kokoro/trampoline_v2.sh +++ b/tests/fixtures/nodejs-dlp-with-staging/.kokoro/trampoline_v2.sh @@ -119,7 +119,7 @@ TRAMPOLINE_WORKSPACE="${TRAMPOLINE_WORKSPACE:-/workspace}" pass_down_envvars=( # TRAMPOLINE_V2 variables. - # Tells scripts whether they are running as part of CI or not. + # Tells scripts whether or not they are running as part of CI. "RUNNING_IN_CI" # Indicates which CI system we're in. "TRAMPOLINE_CI" @@ -241,7 +241,7 @@ function repo_root() { } # Detect the project root. In CI builds, we assume the script is in -# the git tree and traverse from there, otherwise, traverse from `pwd` +# the git tree and traverse from there; otherwise, traverse from `pwd` # to find `.git` directory. if [[ "${RUNNING_IN_CI:-}" == "true" ]]; then PROGRAM_PATH="$(realpath "$0")" @@ -394,7 +394,7 @@ docker_flags=( # Use the host network. "--network=host" - # Run in priviledged mode. We are not using docker for sandboxing or + # Run in privileged mode. We are not using docker for sandboxing or # isolation, just for packaging our dev tools. "--privileged" @@ -444,7 +444,7 @@ do done # If arguments are given, all arguments will become the commands run -# in the container, otherwise run TRAMPOLINE_BUILD_FILE. +# in the container; otherwise, run TRAMPOLINE_BUILD_FILE. if [[ $# -ge 1 ]]; then log_yellow "Running the given commands '" "${@:1}" "' in the container." readonly commands=("${@:1}") diff --git a/tests/fixtures/nodejs-dlp-with-staging/CHANGELOG.md b/tests/fixtures/nodejs-dlp-with-staging/CHANGELOG.md index b20038d83..1cfbab2b6 100644 --- a/tests/fixtures/nodejs-dlp-with-staging/CHANGELOG.md +++ b/tests/fixtures/nodejs-dlp-with-staging/CHANGELOG.md @@ -220,7 +220,7 @@ ### Features -* auto-generate READMEs, add .repo-metdata.json ([#293](https://www.github.com/googleapis/nodejs-dlp/issues/293)) ([6895e23](https://www.github.com/googleapis/nodejs-dlp/commit/6895e23)) +* auto-generate READMEs, add .repo-metadata.json ([#293](https://www.github.com/googleapis/nodejs-dlp/issues/293)) ([6895e23](https://www.github.com/googleapis/nodejs-dlp/commit/6895e23)) ## [1.0.0](https://www.github.com/googleapis/nodejs-dlp/compare/v0.12.0...v1.0.0) (2019-05-20) @@ -298,7 +298,7 @@ Greetings! This release has a few new features, bug fixes, and doc updates. En 01-04-2019 15:04 PST ### New Features -- feat: add excluded field field for storage ([#169](https://github.com/googleapis/nodejs-dlp/pull/169)) +- feat: add excluded field for storage ([#169](https://github.com/googleapis/nodejs-dlp/pull/169)) - feat: add support for storedInfoTypes ([#157](https://github.com/googleapis/nodejs-dlp/pull/157)) - feat: add CloudStorageRegexFileSet ([#153](https://github.com/googleapis/nodejs-dlp/pull/153)) - feat: add sorting and ordering of results ([#147](https://github.com/googleapis/nodejs-dlp/pull/147)) diff --git a/tests/fixtures/nodejs-dlp-with-staging/api-extractor.json b/tests/fixtures/nodejs-dlp-with-staging/api-extractor.json index de228294b..abda90dbc 100644 --- a/tests/fixtures/nodejs-dlp-with-staging/api-extractor.json +++ b/tests/fixtures/nodejs-dlp-with-staging/api-extractor.json @@ -292,7 +292,7 @@ */ "default": { /** - * Specifies whether the message should be written to the the tool's output log. Note that + * Specifies whether the message should be written to the tool's output log. Note that * the "addToApiReportFile" property may supersede this option. * * Possible values: "error", "warning", "none" diff --git a/tests/fixtures/nodejs-dlp-with-staging/owl-bot-staging/v2/protos/google/privacy/dlp/v2/dlp.proto b/tests/fixtures/nodejs-dlp-with-staging/owl-bot-staging/v2/protos/google/privacy/dlp/v2/dlp.proto index 3fb0c2193..74558aeb6 100644 --- a/tests/fixtures/nodejs-dlp-with-staging/owl-bot-staging/v2/protos/google/privacy/dlp/v2/dlp.proto +++ b/tests/fixtures/nodejs-dlp-with-staging/owl-bot-staging/v2/protos/google/privacy/dlp/v2/dlp.proto @@ -981,7 +981,7 @@ message ContentLocation { // * Datastore namespace: {namespace} // // Nested names could be absent if the embedded object has no string - // identifier (for an example an image contained within a document). + // identifier (for example, an image contained within a document). string container_name = 1; // Type of the container within the file with location of the finding. @@ -1051,9 +1051,9 @@ message RecordLocation { message TableLocation { // The zero-based index of the row where the finding is located. Only // populated for resources that have a natural ordering, not BigQuery. In - // BigQuery, to identify the row a finding came from, populate + // BigQuery, to identify the source row of a finding, populate // BigQueryOptions.identifying_fields with your primary key column names and - // when you store the findings the value of those columns will be stored + // when you store the findings, the value of those columns will be stored // inside of Finding. int64 row_index = 1; } @@ -1342,7 +1342,7 @@ message ReidentifyContentRequest { string location_id = 7; } -// Results of re-identifying a item. +// Results of re-identifying an item. message ReidentifyContentResponse { // The re-identified item. ContentItem item = 1; @@ -2056,7 +2056,7 @@ message AnalyzeDataSourceRiskDetails { // K-anonymity result KAnonymityResult k_anonymity_result = 5; - // L-divesity result + // L-diversity result LDiversityResult l_diversity_result = 6; // K-map result @@ -2181,7 +2181,7 @@ message TransformationErrorHandling { // Skips the data without modifying it if the requested transformation would // cause an error. For example, if a `DateShift` transformation were applied - // an an IP address, this mode would leave the IP address unchanged in the + // to an IP address, this mode would leave the IP address unchanged in the // response. message LeaveUntransformed { @@ -2536,7 +2536,7 @@ message CryptoReplaceFfxFpeConfig { // applied to both structured and non-structured `ContentItem`s. // Currently, the referenced field may be of value type integer or string. // - // The tweak is constructed as a sequence of bytes in big endian byte order + // The tweak is constructed as a sequence of bytes in big-endian byte order // such that: // // - a 64 bit integer is encoded followed by a single byte of value 1 @@ -3006,7 +3006,7 @@ message JobTrigger { // Trigger is temporarily paused. PAUSED = 2; - // Trigger is cancelled and can not be resumed. + // Trigger is cancelled and cannot be resumed. CANCELLED = 3; } diff --git a/tests/fixtures/nodejs-dlp-with-staging/owl-bot-staging/v2/protos/google/privacy/dlp/v2/storage.proto b/tests/fixtures/nodejs-dlp-with-staging/owl-bot-staging/v2/protos/google/privacy/dlp/v2/storage.proto index 6ded28b16..3a0ac9d18 100644 --- a/tests/fixtures/nodejs-dlp-with-staging/owl-bot-staging/v2/protos/google/privacy/dlp/v2/storage.proto +++ b/tests/fixtures/nodejs-dlp-with-staging/owl-bot-staging/v2/protos/google/privacy/dlp/v2/storage.proto @@ -619,7 +619,7 @@ message BigQueryKey { // Complete BigQuery table reference. BigQueryTable table_reference = 1; - // Row number inferred at the time the table was scanned. This value is + // Row number inferred at the time that the table was scanned. This value is // nondeterministic, cannot be queried, and may be null for inspection // jobs. To locate findings within a table, specify // `inspect_job.storage_config.big_query_options.identifying_fields` in diff --git a/tests/fixtures/nodejs-dlp-with-staging/protos/google/privacy/dlp/v2/dlp.proto b/tests/fixtures/nodejs-dlp-with-staging/protos/google/privacy/dlp/v2/dlp.proto index 3fb0c2193..74558aeb6 100644 --- a/tests/fixtures/nodejs-dlp-with-staging/protos/google/privacy/dlp/v2/dlp.proto +++ b/tests/fixtures/nodejs-dlp-with-staging/protos/google/privacy/dlp/v2/dlp.proto @@ -981,7 +981,7 @@ message ContentLocation { // * Datastore namespace: {namespace} // // Nested names could be absent if the embedded object has no string - // identifier (for an example an image contained within a document). + // identifier (for example, an image contained within a document). string container_name = 1; // Type of the container within the file with location of the finding. @@ -1051,9 +1051,9 @@ message RecordLocation { message TableLocation { // The zero-based index of the row where the finding is located. Only // populated for resources that have a natural ordering, not BigQuery. In - // BigQuery, to identify the row a finding came from, populate + // BigQuery, to identify the source row of a finding, populate // BigQueryOptions.identifying_fields with your primary key column names and - // when you store the findings the value of those columns will be stored + // when you store the findings, the value of those columns will be stored // inside of Finding. int64 row_index = 1; } @@ -1342,7 +1342,7 @@ message ReidentifyContentRequest { string location_id = 7; } -// Results of re-identifying a item. +// Results of re-identifying an item. message ReidentifyContentResponse { // The re-identified item. ContentItem item = 1; @@ -2056,7 +2056,7 @@ message AnalyzeDataSourceRiskDetails { // K-anonymity result KAnonymityResult k_anonymity_result = 5; - // L-divesity result + // L-diversity result LDiversityResult l_diversity_result = 6; // K-map result @@ -2181,7 +2181,7 @@ message TransformationErrorHandling { // Skips the data without modifying it if the requested transformation would // cause an error. For example, if a `DateShift` transformation were applied - // an an IP address, this mode would leave the IP address unchanged in the + // to an IP address, this mode would leave the IP address unchanged in the // response. message LeaveUntransformed { @@ -2536,7 +2536,7 @@ message CryptoReplaceFfxFpeConfig { // applied to both structured and non-structured `ContentItem`s. // Currently, the referenced field may be of value type integer or string. // - // The tweak is constructed as a sequence of bytes in big endian byte order + // The tweak is constructed as a sequence of bytes in big-endian byte order // such that: // // - a 64 bit integer is encoded followed by a single byte of value 1 @@ -3006,7 +3006,7 @@ message JobTrigger { // Trigger is temporarily paused. PAUSED = 2; - // Trigger is cancelled and can not be resumed. + // Trigger is cancelled and cannot be resumed. CANCELLED = 3; } diff --git a/tests/fixtures/nodejs-dlp-with-staging/protos/google/privacy/dlp/v2/storage.proto b/tests/fixtures/nodejs-dlp-with-staging/protos/google/privacy/dlp/v2/storage.proto index 6ded28b16..3a0ac9d18 100644 --- a/tests/fixtures/nodejs-dlp-with-staging/protos/google/privacy/dlp/v2/storage.proto +++ b/tests/fixtures/nodejs-dlp-with-staging/protos/google/privacy/dlp/v2/storage.proto @@ -619,7 +619,7 @@ message BigQueryKey { // Complete BigQuery table reference. BigQueryTable table_reference = 1; - // Row number inferred at the time the table was scanned. This value is + // Row number inferred at the time that the table was scanned. This value is // nondeterministic, cannot be queried, and may be null for inspection // jobs. To locate findings within a table, specify // `inspect_job.storage_config.big_query_options.identifying_fields` in diff --git a/tests/fixtures/nodejs-dlp/.kokoro/release/publish.cfg b/tests/fixtures/nodejs-dlp/.kokoro/release/publish.cfg index 061f3c242..2e6cc2760 100644 --- a/tests/fixtures/nodejs-dlp/.kokoro/release/publish.cfg +++ b/tests/fixtures/nodejs-dlp/.kokoro/release/publish.cfg @@ -27,7 +27,7 @@ before_action { } } -# Fetch magictoken to use with Magic Github Proxy +# Fetch magictoken to use with Magic GitHub Proxy before_action { fetch_keystore { keystore_resource { @@ -37,7 +37,7 @@ before_action { } } -# Fetch api key to use with Magic Github Proxy +# Fetch api key to use with Magic GitHub Proxy before_action { fetch_keystore { keystore_resource { diff --git a/tests/fixtures/nodejs-dlp/.kokoro/trampoline.sh b/tests/fixtures/nodejs-dlp/.kokoro/trampoline.sh index f693a1ce7..370da3608 100644 --- a/tests/fixtures/nodejs-dlp/.kokoro/trampoline.sh +++ b/tests/fixtures/nodejs-dlp/.kokoro/trampoline.sh @@ -13,7 +13,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -# This file is not used any more, but we keep this file for making it +# This file is not used anymore, but we keep this file for making it # easy to roll back. # TODO: Remove this file from the template. diff --git a/tests/fixtures/nodejs-dlp/.kokoro/trampoline_v2.sh b/tests/fixtures/nodejs-dlp/.kokoro/trampoline_v2.sh index 4d0311212..56c02ce62 100644 --- a/tests/fixtures/nodejs-dlp/.kokoro/trampoline_v2.sh +++ b/tests/fixtures/nodejs-dlp/.kokoro/trampoline_v2.sh @@ -119,7 +119,7 @@ TRAMPOLINE_WORKSPACE="${TRAMPOLINE_WORKSPACE:-/workspace}" pass_down_envvars=( # TRAMPOLINE_V2 variables. - # Tells scripts whether they are running as part of CI or not. + # Tells scripts whether or not they are running as part of CI. "RUNNING_IN_CI" # Indicates which CI system we're in. "TRAMPOLINE_CI" @@ -241,7 +241,7 @@ function repo_root() { } # Detect the project root. In CI builds, we assume the script is in -# the git tree and traverse from there, otherwise, traverse from `pwd` +# the git tree and traverse from there; otherwise, traverse from `pwd` # to find `.git` directory. if [[ "${RUNNING_IN_CI:-}" == "true" ]]; then PROGRAM_PATH="$(realpath "$0")" @@ -394,7 +394,7 @@ docker_flags=( # Use the host network. "--network=host" - # Run in priviledged mode. We are not using docker for sandboxing or + # Run in privileged mode. We are not using docker for sandboxing or # isolation, just for packaging our dev tools. "--privileged" @@ -444,7 +444,7 @@ do done # If arguments are given, all arguments will become the commands run -# in the container, otherwise run TRAMPOLINE_BUILD_FILE. +# in the container; otherwise, run TRAMPOLINE_BUILD_FILE. if [[ $# -ge 1 ]]; then log_yellow "Running the given commands '" "${@:1}" "' in the container." readonly commands=("${@:1}") diff --git a/tests/fixtures/nodejs-dlp/CHANGELOG.md b/tests/fixtures/nodejs-dlp/CHANGELOG.md index b20038d83..1cfbab2b6 100644 --- a/tests/fixtures/nodejs-dlp/CHANGELOG.md +++ b/tests/fixtures/nodejs-dlp/CHANGELOG.md @@ -220,7 +220,7 @@ ### Features -* auto-generate READMEs, add .repo-metdata.json ([#293](https://www.github.com/googleapis/nodejs-dlp/issues/293)) ([6895e23](https://www.github.com/googleapis/nodejs-dlp/commit/6895e23)) +* auto-generate READMEs, add .repo-metadata.json ([#293](https://www.github.com/googleapis/nodejs-dlp/issues/293)) ([6895e23](https://www.github.com/googleapis/nodejs-dlp/commit/6895e23)) ## [1.0.0](https://www.github.com/googleapis/nodejs-dlp/compare/v0.12.0...v1.0.0) (2019-05-20) @@ -298,7 +298,7 @@ Greetings! This release has a few new features, bug fixes, and doc updates. En 01-04-2019 15:04 PST ### New Features -- feat: add excluded field field for storage ([#169](https://github.com/googleapis/nodejs-dlp/pull/169)) +- feat: add excluded field for storage ([#169](https://github.com/googleapis/nodejs-dlp/pull/169)) - feat: add support for storedInfoTypes ([#157](https://github.com/googleapis/nodejs-dlp/pull/157)) - feat: add CloudStorageRegexFileSet ([#153](https://github.com/googleapis/nodejs-dlp/pull/153)) - feat: add sorting and ordering of results ([#147](https://github.com/googleapis/nodejs-dlp/pull/147)) diff --git a/tests/fixtures/nodejs-dlp/api-extractor.json b/tests/fixtures/nodejs-dlp/api-extractor.json index de228294b..abda90dbc 100644 --- a/tests/fixtures/nodejs-dlp/api-extractor.json +++ b/tests/fixtures/nodejs-dlp/api-extractor.json @@ -292,7 +292,7 @@ */ "default": { /** - * Specifies whether the message should be written to the the tool's output log. Note that + * Specifies whether the message should be written to the tool's output log. Note that * the "addToApiReportFile" property may supersede this option. * * Possible values: "error", "warning", "none" diff --git a/tests/fixtures/nodejs-dlp/protos/google/privacy/dlp/v2/dlp.proto b/tests/fixtures/nodejs-dlp/protos/google/privacy/dlp/v2/dlp.proto index 3fb0c2193..74558aeb6 100644 --- a/tests/fixtures/nodejs-dlp/protos/google/privacy/dlp/v2/dlp.proto +++ b/tests/fixtures/nodejs-dlp/protos/google/privacy/dlp/v2/dlp.proto @@ -981,7 +981,7 @@ message ContentLocation { // * Datastore namespace: {namespace} // // Nested names could be absent if the embedded object has no string - // identifier (for an example an image contained within a document). + // identifier (for example, an image contained within a document). string container_name = 1; // Type of the container within the file with location of the finding. @@ -1051,9 +1051,9 @@ message RecordLocation { message TableLocation { // The zero-based index of the row where the finding is located. Only // populated for resources that have a natural ordering, not BigQuery. In - // BigQuery, to identify the row a finding came from, populate + // BigQuery, to identify the source row of a finding, populate // BigQueryOptions.identifying_fields with your primary key column names and - // when you store the findings the value of those columns will be stored + // when you store the findings, the value of those columns will be stored // inside of Finding. int64 row_index = 1; } @@ -1342,7 +1342,7 @@ message ReidentifyContentRequest { string location_id = 7; } -// Results of re-identifying a item. +// Results of re-identifying an item. message ReidentifyContentResponse { // The re-identified item. ContentItem item = 1; @@ -2056,7 +2056,7 @@ message AnalyzeDataSourceRiskDetails { // K-anonymity result KAnonymityResult k_anonymity_result = 5; - // L-divesity result + // L-diversity result LDiversityResult l_diversity_result = 6; // K-map result @@ -2181,7 +2181,7 @@ message TransformationErrorHandling { // Skips the data without modifying it if the requested transformation would // cause an error. For example, if a `DateShift` transformation were applied - // an an IP address, this mode would leave the IP address unchanged in the + // to an IP address, this mode would leave the IP address unchanged in the // response. message LeaveUntransformed { @@ -2536,7 +2536,7 @@ message CryptoReplaceFfxFpeConfig { // applied to both structured and non-structured `ContentItem`s. // Currently, the referenced field may be of value type integer or string. // - // The tweak is constructed as a sequence of bytes in big endian byte order + // The tweak is constructed as a sequence of bytes in big-endian byte order // such that: // // - a 64 bit integer is encoded followed by a single byte of value 1 @@ -3006,7 +3006,7 @@ message JobTrigger { // Trigger is temporarily paused. PAUSED = 2; - // Trigger is cancelled and can not be resumed. + // Trigger is cancelled and cannot be resumed. CANCELLED = 3; } diff --git a/tests/fixtures/nodejs-dlp/protos/google/privacy/dlp/v2/storage.proto b/tests/fixtures/nodejs-dlp/protos/google/privacy/dlp/v2/storage.proto index 6ded28b16..3a0ac9d18 100644 --- a/tests/fixtures/nodejs-dlp/protos/google/privacy/dlp/v2/storage.proto +++ b/tests/fixtures/nodejs-dlp/protos/google/privacy/dlp/v2/storage.proto @@ -619,7 +619,7 @@ message BigQueryKey { // Complete BigQuery table reference. BigQueryTable table_reference = 1; - // Row number inferred at the time the table was scanned. This value is + // Row number inferred at the time that the table was scanned. This value is // nondeterministic, cannot be queried, and may be null for inspection // jobs. To locate findings within a table, specify // `inspect_job.storage_config.big_query_options.identifying_fields` in diff --git a/tests/fixtures/nodejs_mono_repo_esm/.kokoro/release/publish.cfg b/tests/fixtures/nodejs_mono_repo_esm/.kokoro/release/publish.cfg index 061f3c242..2e6cc2760 100644 --- a/tests/fixtures/nodejs_mono_repo_esm/.kokoro/release/publish.cfg +++ b/tests/fixtures/nodejs_mono_repo_esm/.kokoro/release/publish.cfg @@ -27,7 +27,7 @@ before_action { } } -# Fetch magictoken to use with Magic Github Proxy +# Fetch magictoken to use with Magic GitHub Proxy before_action { fetch_keystore { keystore_resource { @@ -37,7 +37,7 @@ before_action { } } -# Fetch api key to use with Magic Github Proxy +# Fetch api key to use with Magic GitHub Proxy before_action { fetch_keystore { keystore_resource { diff --git a/tests/fixtures/nodejs_mono_repo_esm/.kokoro/samples-test.sh b/tests/fixtures/nodejs_mono_repo_esm/.kokoro/samples-test.sh index c6551d57d..edf7ee6cc 100644 --- a/tests/fixtures/nodejs_mono_repo_esm/.kokoro/samples-test.sh +++ b/tests/fixtures/nodejs_mono_repo_esm/.kokoro/samples-test.sh @@ -16,7 +16,7 @@ set -eo pipefail -# Ensure the npm global directory is writable, otherwise rebuild `npm` +# Ensure the npm global directory is writable; otherwise, rebuild `npm` mkdir -p $NPM_CONFIG_PREFIX npm config -g ls || npm i -g npm@`npm --version` diff --git a/tests/fixtures/nodejs_mono_repo_esm/.kokoro/trampoline.sh b/tests/fixtures/nodejs_mono_repo_esm/.kokoro/trampoline.sh index f693a1ce7..370da3608 100644 --- a/tests/fixtures/nodejs_mono_repo_esm/.kokoro/trampoline.sh +++ b/tests/fixtures/nodejs_mono_repo_esm/.kokoro/trampoline.sh @@ -13,7 +13,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -# This file is not used any more, but we keep this file for making it +# This file is not used anymore, but we keep this file for making it # easy to roll back. # TODO: Remove this file from the template. diff --git a/tests/fixtures/nodejs_mono_repo_esm/.kokoro/trampoline_v2.sh b/tests/fixtures/nodejs_mono_repo_esm/.kokoro/trampoline_v2.sh index 4d0311212..56c02ce62 100644 --- a/tests/fixtures/nodejs_mono_repo_esm/.kokoro/trampoline_v2.sh +++ b/tests/fixtures/nodejs_mono_repo_esm/.kokoro/trampoline_v2.sh @@ -119,7 +119,7 @@ TRAMPOLINE_WORKSPACE="${TRAMPOLINE_WORKSPACE:-/workspace}" pass_down_envvars=( # TRAMPOLINE_V2 variables. - # Tells scripts whether they are running as part of CI or not. + # Tells scripts whether or not they are running as part of CI. "RUNNING_IN_CI" # Indicates which CI system we're in. "TRAMPOLINE_CI" @@ -241,7 +241,7 @@ function repo_root() { } # Detect the project root. In CI builds, we assume the script is in -# the git tree and traverse from there, otherwise, traverse from `pwd` +# the git tree and traverse from there; otherwise, traverse from `pwd` # to find `.git` directory. if [[ "${RUNNING_IN_CI:-}" == "true" ]]; then PROGRAM_PATH="$(realpath "$0")" @@ -394,7 +394,7 @@ docker_flags=( # Use the host network. "--network=host" - # Run in priviledged mode. We are not using docker for sandboxing or + # Run in privileged mode. We are not using docker for sandboxing or # isolation, just for packaging our dev tools. "--privileged" @@ -444,7 +444,7 @@ do done # If arguments are given, all arguments will become the commands run -# in the container, otherwise run TRAMPOLINE_BUILD_FILE. +# in the container; otherwise, run TRAMPOLINE_BUILD_FILE. if [[ $# -ge 1 ]]; then log_yellow "Running the given commands '" "${@:1}" "' in the container." readonly commands=("${@:1}") diff --git a/tests/fixtures/nodejs_mono_repo_esm/packages/dlp/CHANGELOG.md b/tests/fixtures/nodejs_mono_repo_esm/packages/dlp/CHANGELOG.md index b20038d83..1cfbab2b6 100644 --- a/tests/fixtures/nodejs_mono_repo_esm/packages/dlp/CHANGELOG.md +++ b/tests/fixtures/nodejs_mono_repo_esm/packages/dlp/CHANGELOG.md @@ -220,7 +220,7 @@ ### Features -* auto-generate READMEs, add .repo-metdata.json ([#293](https://www.github.com/googleapis/nodejs-dlp/issues/293)) ([6895e23](https://www.github.com/googleapis/nodejs-dlp/commit/6895e23)) +* auto-generate READMEs, add .repo-metadata.json ([#293](https://www.github.com/googleapis/nodejs-dlp/issues/293)) ([6895e23](https://www.github.com/googleapis/nodejs-dlp/commit/6895e23)) ## [1.0.0](https://www.github.com/googleapis/nodejs-dlp/compare/v0.12.0...v1.0.0) (2019-05-20) @@ -298,7 +298,7 @@ Greetings! This release has a few new features, bug fixes, and doc updates. En 01-04-2019 15:04 PST ### New Features -- feat: add excluded field field for storage ([#169](https://github.com/googleapis/nodejs-dlp/pull/169)) +- feat: add excluded field for storage ([#169](https://github.com/googleapis/nodejs-dlp/pull/169)) - feat: add support for storedInfoTypes ([#157](https://github.com/googleapis/nodejs-dlp/pull/157)) - feat: add CloudStorageRegexFileSet ([#153](https://github.com/googleapis/nodejs-dlp/pull/153)) - feat: add sorting and ordering of results ([#147](https://github.com/googleapis/nodejs-dlp/pull/147)) diff --git a/tests/fixtures/nodejs_mono_repo_esm/packages/dlp/api-extractor.json b/tests/fixtures/nodejs_mono_repo_esm/packages/dlp/api-extractor.json index de228294b..abda90dbc 100644 --- a/tests/fixtures/nodejs_mono_repo_esm/packages/dlp/api-extractor.json +++ b/tests/fixtures/nodejs_mono_repo_esm/packages/dlp/api-extractor.json @@ -292,7 +292,7 @@ */ "default": { /** - * Specifies whether the message should be written to the the tool's output log. Note that + * Specifies whether the message should be written to the tool's output log. Note that * the "addToApiReportFile" property may supersede this option. * * Possible values: "error", "warning", "none" diff --git a/tests/fixtures/nodejs_mono_repo_with_staging/owl-bot-staging/dlp/v2/protos/google/privacy/dlp/v2/dlp.proto b/tests/fixtures/nodejs_mono_repo_with_staging/owl-bot-staging/dlp/v2/protos/google/privacy/dlp/v2/dlp.proto index 3fb0c2193..74558aeb6 100644 --- a/tests/fixtures/nodejs_mono_repo_with_staging/owl-bot-staging/dlp/v2/protos/google/privacy/dlp/v2/dlp.proto +++ b/tests/fixtures/nodejs_mono_repo_with_staging/owl-bot-staging/dlp/v2/protos/google/privacy/dlp/v2/dlp.proto @@ -981,7 +981,7 @@ message ContentLocation { // * Datastore namespace: {namespace} // // Nested names could be absent if the embedded object has no string - // identifier (for an example an image contained within a document). + // identifier (for example, an image contained within a document). string container_name = 1; // Type of the container within the file with location of the finding. @@ -1051,9 +1051,9 @@ message RecordLocation { message TableLocation { // The zero-based index of the row where the finding is located. Only // populated for resources that have a natural ordering, not BigQuery. In - // BigQuery, to identify the row a finding came from, populate + // BigQuery, to identify the source row of a finding, populate // BigQueryOptions.identifying_fields with your primary key column names and - // when you store the findings the value of those columns will be stored + // when you store the findings, the value of those columns will be stored // inside of Finding. int64 row_index = 1; } @@ -1342,7 +1342,7 @@ message ReidentifyContentRequest { string location_id = 7; } -// Results of re-identifying a item. +// Results of re-identifying an item. message ReidentifyContentResponse { // The re-identified item. ContentItem item = 1; @@ -2056,7 +2056,7 @@ message AnalyzeDataSourceRiskDetails { // K-anonymity result KAnonymityResult k_anonymity_result = 5; - // L-divesity result + // L-diversity result LDiversityResult l_diversity_result = 6; // K-map result @@ -2181,7 +2181,7 @@ message TransformationErrorHandling { // Skips the data without modifying it if the requested transformation would // cause an error. For example, if a `DateShift` transformation were applied - // an an IP address, this mode would leave the IP address unchanged in the + // to an IP address, this mode would leave the IP address unchanged in the // response. message LeaveUntransformed { @@ -2536,7 +2536,7 @@ message CryptoReplaceFfxFpeConfig { // applied to both structured and non-structured `ContentItem`s. // Currently, the referenced field may be of value type integer or string. // - // The tweak is constructed as a sequence of bytes in big endian byte order + // The tweak is constructed as a sequence of bytes in big-endian byte order // such that: // // - a 64 bit integer is encoded followed by a single byte of value 1 @@ -3006,7 +3006,7 @@ message JobTrigger { // Trigger is temporarily paused. PAUSED = 2; - // Trigger is cancelled and can not be resumed. + // Trigger is cancelled and cannot be resumed. CANCELLED = 3; } diff --git a/tests/fixtures/nodejs_mono_repo_with_staging/owl-bot-staging/dlp/v2/protos/google/privacy/dlp/v2/storage.proto b/tests/fixtures/nodejs_mono_repo_with_staging/owl-bot-staging/dlp/v2/protos/google/privacy/dlp/v2/storage.proto index 6ded28b16..3a0ac9d18 100644 --- a/tests/fixtures/nodejs_mono_repo_with_staging/owl-bot-staging/dlp/v2/protos/google/privacy/dlp/v2/storage.proto +++ b/tests/fixtures/nodejs_mono_repo_with_staging/owl-bot-staging/dlp/v2/protos/google/privacy/dlp/v2/storage.proto @@ -619,7 +619,7 @@ message BigQueryKey { // Complete BigQuery table reference. BigQueryTable table_reference = 1; - // Row number inferred at the time the table was scanned. This value is + // Row number inferred at the time that the table was scanned. This value is // nondeterministic, cannot be queried, and may be null for inspection // jobs. To locate findings within a table, specify // `inspect_job.storage_config.big_query_options.identifying_fields` in diff --git a/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/CHANGELOG.md b/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/CHANGELOG.md index b20038d83..1cfbab2b6 100644 --- a/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/CHANGELOG.md +++ b/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/CHANGELOG.md @@ -220,7 +220,7 @@ ### Features -* auto-generate READMEs, add .repo-metdata.json ([#293](https://www.github.com/googleapis/nodejs-dlp/issues/293)) ([6895e23](https://www.github.com/googleapis/nodejs-dlp/commit/6895e23)) +* auto-generate READMEs, add .repo-metadata.json ([#293](https://www.github.com/googleapis/nodejs-dlp/issues/293)) ([6895e23](https://www.github.com/googleapis/nodejs-dlp/commit/6895e23)) ## [1.0.0](https://www.github.com/googleapis/nodejs-dlp/compare/v0.12.0...v1.0.0) (2019-05-20) @@ -298,7 +298,7 @@ Greetings! This release has a few new features, bug fixes, and doc updates. En 01-04-2019 15:04 PST ### New Features -- feat: add excluded field field for storage ([#169](https://github.com/googleapis/nodejs-dlp/pull/169)) +- feat: add excluded field for storage ([#169](https://github.com/googleapis/nodejs-dlp/pull/169)) - feat: add support for storedInfoTypes ([#157](https://github.com/googleapis/nodejs-dlp/pull/157)) - feat: add CloudStorageRegexFileSet ([#153](https://github.com/googleapis/nodejs-dlp/pull/153)) - feat: add sorting and ordering of results ([#147](https://github.com/googleapis/nodejs-dlp/pull/147)) diff --git a/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/api-extractor.json b/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/api-extractor.json index de228294b..abda90dbc 100644 --- a/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/api-extractor.json +++ b/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/api-extractor.json @@ -292,7 +292,7 @@ */ "default": { /** - * Specifies whether the message should be written to the the tool's output log. Note that + * Specifies whether the message should be written to the tool's output log. Note that * the "addToApiReportFile" property may supersede this option. * * Possible values: "error", "warning", "none" diff --git a/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/protos/google/privacy/dlp/v2/dlp.proto b/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/protos/google/privacy/dlp/v2/dlp.proto index 3fb0c2193..74558aeb6 100644 --- a/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/protos/google/privacy/dlp/v2/dlp.proto +++ b/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/protos/google/privacy/dlp/v2/dlp.proto @@ -981,7 +981,7 @@ message ContentLocation { // * Datastore namespace: {namespace} // // Nested names could be absent if the embedded object has no string - // identifier (for an example an image contained within a document). + // identifier (for example, an image contained within a document). string container_name = 1; // Type of the container within the file with location of the finding. @@ -1051,9 +1051,9 @@ message RecordLocation { message TableLocation { // The zero-based index of the row where the finding is located. Only // populated for resources that have a natural ordering, not BigQuery. In - // BigQuery, to identify the row a finding came from, populate + // BigQuery, to identify the source row of a finding, populate // BigQueryOptions.identifying_fields with your primary key column names and - // when you store the findings the value of those columns will be stored + // when you store the findings, the value of those columns will be stored // inside of Finding. int64 row_index = 1; } @@ -1342,7 +1342,7 @@ message ReidentifyContentRequest { string location_id = 7; } -// Results of re-identifying a item. +// Results of re-identifying an item. message ReidentifyContentResponse { // The re-identified item. ContentItem item = 1; @@ -2056,7 +2056,7 @@ message AnalyzeDataSourceRiskDetails { // K-anonymity result KAnonymityResult k_anonymity_result = 5; - // L-divesity result + // L-diversity result LDiversityResult l_diversity_result = 6; // K-map result @@ -2181,7 +2181,7 @@ message TransformationErrorHandling { // Skips the data without modifying it if the requested transformation would // cause an error. For example, if a `DateShift` transformation were applied - // an an IP address, this mode would leave the IP address unchanged in the + // to an IP address, this mode would leave the IP address unchanged in the // response. message LeaveUntransformed { @@ -2536,7 +2536,7 @@ message CryptoReplaceFfxFpeConfig { // applied to both structured and non-structured `ContentItem`s. // Currently, the referenced field may be of value type integer or string. // - // The tweak is constructed as a sequence of bytes in big endian byte order + // The tweak is constructed as a sequence of bytes in big-endian byte order // such that: // // - a 64 bit integer is encoded followed by a single byte of value 1 @@ -3006,7 +3006,7 @@ message JobTrigger { // Trigger is temporarily paused. PAUSED = 2; - // Trigger is cancelled and can not be resumed. + // Trigger is cancelled and cannot be resumed. CANCELLED = 3; } diff --git a/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/protos/google/privacy/dlp/v2/storage.proto b/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/protos/google/privacy/dlp/v2/storage.proto index 6ded28b16..3a0ac9d18 100644 --- a/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/protos/google/privacy/dlp/v2/storage.proto +++ b/tests/fixtures/nodejs_mono_repo_with_staging/packages/dlp/protos/google/privacy/dlp/v2/storage.proto @@ -619,7 +619,7 @@ message BigQueryKey { // Complete BigQuery table reference. BigQueryTable table_reference = 1; - // Row number inferred at the time the table was scanned. This value is + // Row number inferred at the time that the table was scanned. This value is // nondeterministic, cannot be queried, and may be null for inspection // jobs. To locate findings within a table, specify // `inspect_job.storage_config.big_query_options.identifying_fields` in diff --git a/tests/fixtures/php/php_asset/expected/Asset/samples/V1/AssetServiceClient/analyze_move.php b/tests/fixtures/php/php_asset/expected/Asset/samples/V1/AssetServiceClient/analyze_move.php index 60b26384d..c400f4ab2 100644 --- a/tests/fixtures/php/php_asset/expected/Asset/samples/V1/AssetServiceClient/analyze_move.php +++ b/tests/fixtures/php/php_asset/expected/Asset/samples/V1/AssetServiceClient/analyze_move.php @@ -40,7 +40,7 @@ * "projects/12345"). * @param string $destinationParent Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). */ diff --git a/tests/fixtures/php/php_asset/expected/Asset/src/V1/AnalyzeMoveRequest.php b/tests/fixtures/php/php_asset/expected/Asset/src/V1/AnalyzeMoveRequest.php index 71af341d6..099ab0d06 100644 --- a/tests/fixtures/php/php_asset/expected/Asset/src/V1/AnalyzeMoveRequest.php +++ b/tests/fixtures/php/php_asset/expected/Asset/src/V1/AnalyzeMoveRequest.php @@ -27,7 +27,7 @@ class AnalyzeMoveRequest extends \Google\Protobuf\Internal\Message /** * Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * @@ -56,7 +56,7 @@ class AnalyzeMoveRequest extends \Google\Protobuf\Internal\Message * @type string $destination_parent * Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * @type int $view @@ -104,7 +104,7 @@ public function setResource($var) /** * Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * @@ -119,7 +119,7 @@ public function getDestinationParent() /** * Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * diff --git a/tests/fixtures/php/php_asset/expected/Asset/src/V1/Asset.php b/tests/fixtures/php/php_asset/expected/Asset/src/V1/Asset.php index 6753a6cfa..e2c93c903 100644 --- a/tests/fixtures/php/php_asset/expected/Asset/src/V1/Asset.php +++ b/tests/fixtures/php/php_asset/expected/Asset/src/V1/Asset.php @@ -145,13 +145,13 @@ class Asset extends \Google\Protobuf\Internal\Message * There can be more than one organization policy with different constraints * set on a given resource. * @type \Google\Identity\AccessContextManager\V1\AccessPolicy $access_policy - * Please also refer to the [access policy user + * Please refer to the [access policy user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-policies). * @type \Google\Identity\AccessContextManager\V1\AccessLevel $access_level - * Please also refer to the [access level user + * Please refer to the [access level user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-levels). * @type \Google\Identity\AccessContextManager\V1\ServicePerimeter $service_perimeter - * Please also refer to the [service perimeter user + * Please refer to the [service perimeter user * guide](https://cloud.google.com/vpc-service-controls/docs/overview). * @type \Google\Cloud\OsConfig\V1\Inventory $os_inventory * A representation of runtime OS Inventory information. See [this @@ -400,7 +400,7 @@ public function setOrgPolicy($var) } /** - * Please also refer to the [access policy user + * Please refer to the [access policy user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-policies). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.AccessPolicy access_policy = 7; @@ -417,7 +417,7 @@ public function hasAccessPolicy() } /** - * Please also refer to the [access policy user + * Please refer to the [access policy user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-policies). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.AccessPolicy access_policy = 7; @@ -433,7 +433,7 @@ public function setAccessPolicy($var) } /** - * Please also refer to the [access level user + * Please refer to the [access level user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-levels). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.AccessLevel access_level = 8; @@ -450,7 +450,7 @@ public function hasAccessLevel() } /** - * Please also refer to the [access level user + * Please refer to the [access level user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-levels). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.AccessLevel access_level = 8; @@ -466,7 +466,7 @@ public function setAccessLevel($var) } /** - * Please also refer to the [service perimeter user + * Please refer to the [service perimeter user * guide](https://cloud.google.com/vpc-service-controls/docs/overview). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.ServicePerimeter service_perimeter = 9; @@ -483,7 +483,7 @@ public function hasServicePerimeter() } /** - * Please also refer to the [service perimeter user + * Please refer to the [service perimeter user * guide](https://cloud.google.com/vpc-service-controls/docs/overview). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.ServicePerimeter service_perimeter = 9; diff --git a/tests/fixtures/php/php_asset/expected/Asset/src/V1/BigQueryDestination.php b/tests/fixtures/php/php_asset/expected/Asset/src/V1/BigQueryDestination.php index 269016c8e..a68a7fd80 100644 --- a/tests/fixtures/php/php_asset/expected/Asset/src/V1/BigQueryDestination.php +++ b/tests/fixtures/php/php_asset/expected/Asset/src/V1/BigQueryDestination.php @@ -36,7 +36,7 @@ class BigQueryDestination extends \Google\Protobuf\Internal\Message * If the destination table already exists and this flag is `TRUE`, the * table will be overwritten by the contents of assets snapshot. If the flag * is `FALSE` or unset and the destination table already exists, the export - * call returns an INVALID_ARGUMEMT error. + * call returns an INVALID_ARGUMENT error. * * Generated from protobuf field bool force = 3; */ @@ -110,7 +110,7 @@ class BigQueryDestination extends \Google\Protobuf\Internal\Message * If the destination table already exists and this flag is `TRUE`, the * table will be overwritten by the contents of assets snapshot. If the flag * is `FALSE` or unset and the destination table already exists, the export - * call returns an INVALID_ARGUMEMT error. + * call returns an INVALID_ARGUMENT error. * @type \Google\Cloud\Asset\V1\PartitionSpec $partition_spec * [partition_spec] determines whether to export to partitioned table(s) and * how to partition the data. @@ -225,7 +225,7 @@ public function setTable($var) * If the destination table already exists and this flag is `TRUE`, the * table will be overwritten by the contents of assets snapshot. If the flag * is `FALSE` or unset and the destination table already exists, the export - * call returns an INVALID_ARGUMEMT error. + * call returns an INVALID_ARGUMENT error. * * Generated from protobuf field bool force = 3; * @return bool @@ -239,7 +239,7 @@ public function getForce() * If the destination table already exists and this flag is `TRUE`, the * table will be overwritten by the contents of assets snapshot. If the flag * is `FALSE` or unset and the destination table already exists, the export - * call returns an INVALID_ARGUMEMT error. + * call returns an INVALID_ARGUMENT error. * * Generated from protobuf field bool force = 3; * @param bool $var diff --git a/tests/fixtures/php/php_asset/expected/Asset/src/V1/ExportAssetsRequest.php b/tests/fixtures/php/php_asset/expected/Asset/src/V1/ExportAssetsRequest.php index d65e59cee..787571a96 100644 --- a/tests/fixtures/php/php_asset/expected/Asset/src/V1/ExportAssetsRequest.php +++ b/tests/fixtures/php/php_asset/expected/Asset/src/V1/ExportAssetsRequest.php @@ -45,7 +45,7 @@ class ExportAssetsRequest extends \Google\Protobuf\Internal\Message * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -115,7 +115,7 @@ class ExportAssetsRequest extends \Google\Protobuf\Internal\Message * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -234,7 +234,7 @@ public function setReadTime($var) * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -258,7 +258,7 @@ public function getAssetTypes() * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. diff --git a/tests/fixtures/php/php_asset/expected/Asset/src/V1/Feed.php b/tests/fixtures/php/php_asset/expected/Asset/src/V1/Feed.php index a4a524de7..ddb328792 100644 --- a/tests/fixtures/php/php_asset/expected/Asset/src/V1/Feed.php +++ b/tests/fixtures/php/php_asset/expected/Asset/src/V1/Feed.php @@ -98,7 +98,7 @@ class Feed extends \Google\Protobuf\Internal\Message * * Otherwise: * it outputs the supported relationships of the types of [asset_names] and * [asset_types] or returns an error if any of the [asset_names] or the - * [asset_types] has no replationship support. + * [asset_types] has no relationship support. * See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types and relationship types. @@ -168,7 +168,7 @@ class Feed extends \Google\Protobuf\Internal\Message * * Otherwise: * it outputs the supported relationships of the types of [asset_names] and * [asset_types] or returns an error if any of the [asset_names] or the - * [asset_types] has no replationship support. + * [asset_types] has no relationship support. * See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types and relationship types. @@ -428,7 +428,7 @@ public function setCondition($var) * * Otherwise: * it outputs the supported relationships of the types of [asset_names] and * [asset_types] or returns an error if any of the [asset_names] or the - * [asset_types] has no replationship support. + * [asset_types] has no relationship support. * See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types and relationship types. @@ -454,7 +454,7 @@ public function getRelationshipTypes() * * Otherwise: * it outputs the supported relationships of the types of [asset_names] and * [asset_types] or returns an error if any of the [asset_names] or the - * [asset_types] has no replationship support. + * [asset_types] has no relationship support. * See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types and relationship types. diff --git a/tests/fixtures/php/php_asset/expected/Asset/src/V1/Gapic/AssetServiceGapicClient.php b/tests/fixtures/php/php_asset/expected/Asset/src/V1/Gapic/AssetServiceGapicClient.php index 0a2484da9..885c34812 100644 --- a/tests/fixtures/php/php_asset/expected/Asset/src/V1/Gapic/AssetServiceGapicClient.php +++ b/tests/fixtures/php/php_asset/expected/Asset/src/V1/Gapic/AssetServiceGapicClient.php @@ -641,7 +641,7 @@ public function analyzeIamPolicyLongrunning( * "projects/12345"). * @param string $destinationParent Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * @param array $optionalArgs { @@ -988,7 +988,7 @@ public function deleteFeed($name, array $optionalArgs = []) * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. * - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -1170,7 +1170,7 @@ public function getFeed($name, array $optionalArgs = []) * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. * - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. diff --git a/tests/fixtures/php/php_asset/expected/Asset/src/V1/IamPolicyAnalysisOutputConfig/BigQueryDestination/PartitionKey.php b/tests/fixtures/php/php_asset/expected/Asset/src/V1/IamPolicyAnalysisOutputConfig/BigQueryDestination/PartitionKey.php index 6902ee9a9..2c9f50618 100644 --- a/tests/fixtures/php/php_asset/expected/Asset/src/V1/IamPolicyAnalysisOutputConfig/BigQueryDestination/PartitionKey.php +++ b/tests/fixtures/php/php_asset/expected/Asset/src/V1/IamPolicyAnalysisOutputConfig/BigQueryDestination/PartitionKey.php @@ -25,7 +25,7 @@ class PartitionKey const PARTITION_KEY_UNSPECIFIED = 0; /** * The time when the request is received. If specified as partition key, - * the result table(s) is partitoned by the RequestTime column, an + * the result table(s) is partitioned by the RequestTime column, an * additional timestamp column representing when the request was received. * * Generated from protobuf enum REQUEST_TIME = 1; diff --git a/tests/fixtures/php/php_asset/expected/Asset/src/V1/IamPolicySearchResult.php b/tests/fixtures/php/php_asset/expected/Asset/src/V1/IamPolicySearchResult.php index ba6752659..807aa6f89 100644 --- a/tests/fixtures/php/php_asset/expected/Asset/src/V1/IamPolicySearchResult.php +++ b/tests/fixtures/php/php_asset/expected/Asset/src/V1/IamPolicySearchResult.php @@ -42,7 +42,7 @@ class IamPolicySearchResult extends \Google\Protobuf\Internal\Message * projects/{PROJECT_NUMBER}. If an IAM policy is set on a resource (like VM * instance, Cloud Storage bucket), the project field will indicate the * project that contains the resource. If an IAM policy is set on a folder or - * orgnization, this field will be empty. + * organization, this field will be empty. * To search against the `project`: * * specify the `scope` field as this project in your search request. * @@ -123,7 +123,7 @@ class IamPolicySearchResult extends \Google\Protobuf\Internal\Message * projects/{PROJECT_NUMBER}. If an IAM policy is set on a resource (like VM * instance, Cloud Storage bucket), the project field will indicate the * project that contains the resource. If an IAM policy is set on a folder or - * orgnization, this field will be empty. + * organization, this field will be empty. * To search against the `project`: * * specify the `scope` field as this project in your search request. * @type string[]|\Google\Protobuf\Internal\RepeatedField $folders @@ -242,7 +242,7 @@ public function setAssetType($var) * projects/{PROJECT_NUMBER}. If an IAM policy is set on a resource (like VM * instance, Cloud Storage bucket), the project field will indicate the * project that contains the resource. If an IAM policy is set on a folder or - * orgnization, this field will be empty. + * organization, this field will be empty. * To search against the `project`: * * specify the `scope` field as this project in your search request. * @@ -259,7 +259,7 @@ public function getProject() * projects/{PROJECT_NUMBER}. If an IAM policy is set on a resource (like VM * instance, Cloud Storage bucket), the project field will indicate the * project that contains the resource. If an IAM policy is set on a folder or - * orgnization, this field will be empty. + * organization, this field will be empty. * To search against the `project`: * * specify the `scope` field as this project in your search request. * diff --git a/tests/fixtures/php/php_asset/expected/Asset/src/V1/ListAssetsRequest.php b/tests/fixtures/php/php_asset/expected/Asset/src/V1/ListAssetsRequest.php index a422a71ff..bbf55ffe9 100644 --- a/tests/fixtures/php/php_asset/expected/Asset/src/V1/ListAssetsRequest.php +++ b/tests/fixtures/php/php_asset/expected/Asset/src/V1/ListAssetsRequest.php @@ -45,7 +45,7 @@ class ListAssetsRequest extends \Google\Protobuf\Internal\Message * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -124,7 +124,7 @@ class ListAssetsRequest extends \Google\Protobuf\Internal\Message * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -248,7 +248,7 @@ public function setReadTime($var) * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -272,7 +272,7 @@ public function getAssetTypes() * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. diff --git a/tests/fixtures/php/php_asset/expected/Asset/src/V1/PartitionSpec/PartitionKey.php b/tests/fixtures/php/php_asset/expected/Asset/src/V1/PartitionSpec/PartitionKey.php index d7dd49a6d..d418bedec 100644 --- a/tests/fixtures/php/php_asset/expected/Asset/src/V1/PartitionSpec/PartitionKey.php +++ b/tests/fixtures/php/php_asset/expected/Asset/src/V1/PartitionSpec/PartitionKey.php @@ -25,7 +25,7 @@ class PartitionKey const PARTITION_KEY_UNSPECIFIED = 0; /** * The time when the snapshot is taken. If specified as partition key, the - * result table(s) is partitoned by the additional timestamp column, + * result table(s) is partitioned by the additional timestamp column, * readTime. If [read_time] in ExportAssetsRequest is specified, the * readTime column's value will be the same as it. Otherwise, its value will * be the current time that is used to take the snapshot. @@ -35,7 +35,7 @@ class PartitionKey const READ_TIME = 1; /** * The time when the request is received and started to be processed. If - * specified as partition key, the result table(s) is partitoned by the + * specified as partition key, the result table(s) is partitioned by the * requestTime column, an additional timestamp column representing when the * request was received. * diff --git a/tests/fixtures/php/php_asset/expected/Asset/src/V1/ResourceSearchResult.php b/tests/fixtures/php/php_asset/expected/Asset/src/V1/ResourceSearchResult.php index 36b924252..50e8a1764 100644 --- a/tests/fixtures/php/php_asset/expected/Asset/src/V1/ResourceSearchResult.php +++ b/tests/fixtures/php/php_asset/expected/Asset/src/V1/ResourceSearchResult.php @@ -205,7 +205,7 @@ class ResourceSearchResult extends \Google\Protobuf\Internal\Message * attributes](https://cloud.google.com/asset-inventory/docs/supported-asset-types#searchable_asset_types) * to see which fields are included. * You can search values of these fields through free text search. However, - * you should not consume the field programically as the field names and + * you should not consume the field programmatically as the field names and * values may change as the GCP service updates to a new incompatible API * version. * To search against the `additional_attributes`: @@ -412,7 +412,7 @@ class ResourceSearchResult extends \Google\Protobuf\Internal\Message * attributes](https://cloud.google.com/asset-inventory/docs/supported-asset-types#searchable_asset_types) * to see which fields are included. * You can search values of these fields through free text search. However, - * you should not consume the field programically as the field names and + * you should not consume the field programmatically as the field names and * values may change as the GCP service updates to a new incompatible API * version. * To search against the `additional_attributes`: @@ -1047,7 +1047,7 @@ public function setState($var) * attributes](https://cloud.google.com/asset-inventory/docs/supported-asset-types#searchable_asset_types) * to see which fields are included. * You can search values of these fields through free text search. However, - * you should not consume the field programically as the field names and + * you should not consume the field programmatically as the field names and * values may change as the GCP service updates to a new incompatible API * version. * To search against the `additional_attributes`: @@ -1083,7 +1083,7 @@ public function clearAdditionalAttributes() * attributes](https://cloud.google.com/asset-inventory/docs/supported-asset-types#searchable_asset_types) * to see which fields are included. * You can search values of these fields through free text search. However, - * you should not consume the field programically as the field names and + * you should not consume the field programmatically as the field names and * values may change as the GCP service updates to a new incompatible API * version. * To search against the `additional_attributes`: diff --git a/tests/fixtures/php/php_asset/src/Asset/samples/V1/AssetServiceClient/analyze_move.php b/tests/fixtures/php/php_asset/src/Asset/samples/V1/AssetServiceClient/analyze_move.php index 60b26384d..c400f4ab2 100644 --- a/tests/fixtures/php/php_asset/src/Asset/samples/V1/AssetServiceClient/analyze_move.php +++ b/tests/fixtures/php/php_asset/src/Asset/samples/V1/AssetServiceClient/analyze_move.php @@ -40,7 +40,7 @@ * "projects/12345"). * @param string $destinationParent Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). */ diff --git a/tests/fixtures/php/php_asset/src/Asset/src/V1/AnalyzeMoveRequest.php b/tests/fixtures/php/php_asset/src/Asset/src/V1/AnalyzeMoveRequest.php index 71af341d6..099ab0d06 100644 --- a/tests/fixtures/php/php_asset/src/Asset/src/V1/AnalyzeMoveRequest.php +++ b/tests/fixtures/php/php_asset/src/Asset/src/V1/AnalyzeMoveRequest.php @@ -27,7 +27,7 @@ class AnalyzeMoveRequest extends \Google\Protobuf\Internal\Message /** * Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * @@ -56,7 +56,7 @@ class AnalyzeMoveRequest extends \Google\Protobuf\Internal\Message * @type string $destination_parent * Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * @type int $view @@ -104,7 +104,7 @@ public function setResource($var) /** * Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * @@ -119,7 +119,7 @@ public function getDestinationParent() /** * Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * diff --git a/tests/fixtures/php/php_asset/src/Asset/src/V1/Asset.php b/tests/fixtures/php/php_asset/src/Asset/src/V1/Asset.php index 6753a6cfa..e2c93c903 100644 --- a/tests/fixtures/php/php_asset/src/Asset/src/V1/Asset.php +++ b/tests/fixtures/php/php_asset/src/Asset/src/V1/Asset.php @@ -145,13 +145,13 @@ class Asset extends \Google\Protobuf\Internal\Message * There can be more than one organization policy with different constraints * set on a given resource. * @type \Google\Identity\AccessContextManager\V1\AccessPolicy $access_policy - * Please also refer to the [access policy user + * Please refer to the [access policy user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-policies). * @type \Google\Identity\AccessContextManager\V1\AccessLevel $access_level - * Please also refer to the [access level user + * Please refer to the [access level user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-levels). * @type \Google\Identity\AccessContextManager\V1\ServicePerimeter $service_perimeter - * Please also refer to the [service perimeter user + * Please refer to the [service perimeter user * guide](https://cloud.google.com/vpc-service-controls/docs/overview). * @type \Google\Cloud\OsConfig\V1\Inventory $os_inventory * A representation of runtime OS Inventory information. See [this @@ -400,7 +400,7 @@ public function setOrgPolicy($var) } /** - * Please also refer to the [access policy user + * Please refer to the [access policy user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-policies). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.AccessPolicy access_policy = 7; @@ -417,7 +417,7 @@ public function hasAccessPolicy() } /** - * Please also refer to the [access policy user + * Please refer to the [access policy user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-policies). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.AccessPolicy access_policy = 7; @@ -433,7 +433,7 @@ public function setAccessPolicy($var) } /** - * Please also refer to the [access level user + * Please refer to the [access level user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-levels). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.AccessLevel access_level = 8; @@ -450,7 +450,7 @@ public function hasAccessLevel() } /** - * Please also refer to the [access level user + * Please refer to the [access level user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-levels). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.AccessLevel access_level = 8; @@ -466,7 +466,7 @@ public function setAccessLevel($var) } /** - * Please also refer to the [service perimeter user + * Please refer to the [service perimeter user * guide](https://cloud.google.com/vpc-service-controls/docs/overview). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.ServicePerimeter service_perimeter = 9; @@ -483,7 +483,7 @@ public function hasServicePerimeter() } /** - * Please also refer to the [service perimeter user + * Please refer to the [service perimeter user * guide](https://cloud.google.com/vpc-service-controls/docs/overview). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.ServicePerimeter service_perimeter = 9; diff --git a/tests/fixtures/php/php_asset/src/Asset/src/V1/BigQueryDestination.php b/tests/fixtures/php/php_asset/src/Asset/src/V1/BigQueryDestination.php index 269016c8e..a68a7fd80 100644 --- a/tests/fixtures/php/php_asset/src/Asset/src/V1/BigQueryDestination.php +++ b/tests/fixtures/php/php_asset/src/Asset/src/V1/BigQueryDestination.php @@ -36,7 +36,7 @@ class BigQueryDestination extends \Google\Protobuf\Internal\Message * If the destination table already exists and this flag is `TRUE`, the * table will be overwritten by the contents of assets snapshot. If the flag * is `FALSE` or unset and the destination table already exists, the export - * call returns an INVALID_ARGUMEMT error. + * call returns an INVALID_ARGUMENT error. * * Generated from protobuf field bool force = 3; */ @@ -110,7 +110,7 @@ class BigQueryDestination extends \Google\Protobuf\Internal\Message * If the destination table already exists and this flag is `TRUE`, the * table will be overwritten by the contents of assets snapshot. If the flag * is `FALSE` or unset and the destination table already exists, the export - * call returns an INVALID_ARGUMEMT error. + * call returns an INVALID_ARGUMENT error. * @type \Google\Cloud\Asset\V1\PartitionSpec $partition_spec * [partition_spec] determines whether to export to partitioned table(s) and * how to partition the data. @@ -225,7 +225,7 @@ public function setTable($var) * If the destination table already exists and this flag is `TRUE`, the * table will be overwritten by the contents of assets snapshot. If the flag * is `FALSE` or unset and the destination table already exists, the export - * call returns an INVALID_ARGUMEMT error. + * call returns an INVALID_ARGUMENT error. * * Generated from protobuf field bool force = 3; * @return bool @@ -239,7 +239,7 @@ public function getForce() * If the destination table already exists and this flag is `TRUE`, the * table will be overwritten by the contents of assets snapshot. If the flag * is `FALSE` or unset and the destination table already exists, the export - * call returns an INVALID_ARGUMEMT error. + * call returns an INVALID_ARGUMENT error. * * Generated from protobuf field bool force = 3; * @param bool $var diff --git a/tests/fixtures/php/php_asset/src/Asset/src/V1/ExportAssetsRequest.php b/tests/fixtures/php/php_asset/src/Asset/src/V1/ExportAssetsRequest.php index d65e59cee..787571a96 100644 --- a/tests/fixtures/php/php_asset/src/Asset/src/V1/ExportAssetsRequest.php +++ b/tests/fixtures/php/php_asset/src/Asset/src/V1/ExportAssetsRequest.php @@ -45,7 +45,7 @@ class ExportAssetsRequest extends \Google\Protobuf\Internal\Message * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -115,7 +115,7 @@ class ExportAssetsRequest extends \Google\Protobuf\Internal\Message * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -234,7 +234,7 @@ public function setReadTime($var) * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -258,7 +258,7 @@ public function getAssetTypes() * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. diff --git a/tests/fixtures/php/php_asset/src/Asset/src/V1/Feed.php b/tests/fixtures/php/php_asset/src/Asset/src/V1/Feed.php index a4a524de7..ddb328792 100644 --- a/tests/fixtures/php/php_asset/src/Asset/src/V1/Feed.php +++ b/tests/fixtures/php/php_asset/src/Asset/src/V1/Feed.php @@ -98,7 +98,7 @@ class Feed extends \Google\Protobuf\Internal\Message * * Otherwise: * it outputs the supported relationships of the types of [asset_names] and * [asset_types] or returns an error if any of the [asset_names] or the - * [asset_types] has no replationship support. + * [asset_types] has no relationship support. * See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types and relationship types. @@ -168,7 +168,7 @@ class Feed extends \Google\Protobuf\Internal\Message * * Otherwise: * it outputs the supported relationships of the types of [asset_names] and * [asset_types] or returns an error if any of the [asset_names] or the - * [asset_types] has no replationship support. + * [asset_types] has no relationship support. * See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types and relationship types. @@ -428,7 +428,7 @@ public function setCondition($var) * * Otherwise: * it outputs the supported relationships of the types of [asset_names] and * [asset_types] or returns an error if any of the [asset_names] or the - * [asset_types] has no replationship support. + * [asset_types] has no relationship support. * See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types and relationship types. @@ -454,7 +454,7 @@ public function getRelationshipTypes() * * Otherwise: * it outputs the supported relationships of the types of [asset_names] and * [asset_types] or returns an error if any of the [asset_names] or the - * [asset_types] has no replationship support. + * [asset_types] has no relationship support. * See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types and relationship types. diff --git a/tests/fixtures/php/php_asset/src/Asset/src/V1/Gapic/AssetServiceGapicClient.php b/tests/fixtures/php/php_asset/src/Asset/src/V1/Gapic/AssetServiceGapicClient.php index 0a2484da9..885c34812 100644 --- a/tests/fixtures/php/php_asset/src/Asset/src/V1/Gapic/AssetServiceGapicClient.php +++ b/tests/fixtures/php/php_asset/src/Asset/src/V1/Gapic/AssetServiceGapicClient.php @@ -641,7 +641,7 @@ public function analyzeIamPolicyLongrunning( * "projects/12345"). * @param string $destinationParent Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * @param array $optionalArgs { @@ -988,7 +988,7 @@ public function deleteFeed($name, array $optionalArgs = []) * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. * - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -1170,7 +1170,7 @@ public function getFeed($name, array $optionalArgs = []) * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. * - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. diff --git a/tests/fixtures/php/php_asset/src/Asset/src/V1/IamPolicyAnalysisOutputConfig/BigQueryDestination/PartitionKey.php b/tests/fixtures/php/php_asset/src/Asset/src/V1/IamPolicyAnalysisOutputConfig/BigQueryDestination/PartitionKey.php index 6902ee9a9..2c9f50618 100644 --- a/tests/fixtures/php/php_asset/src/Asset/src/V1/IamPolicyAnalysisOutputConfig/BigQueryDestination/PartitionKey.php +++ b/tests/fixtures/php/php_asset/src/Asset/src/V1/IamPolicyAnalysisOutputConfig/BigQueryDestination/PartitionKey.php @@ -25,7 +25,7 @@ class PartitionKey const PARTITION_KEY_UNSPECIFIED = 0; /** * The time when the request is received. If specified as partition key, - * the result table(s) is partitoned by the RequestTime column, an + * the result table(s) is partitioned by the RequestTime column, an * additional timestamp column representing when the request was received. * * Generated from protobuf enum REQUEST_TIME = 1; diff --git a/tests/fixtures/php/php_asset/src/Asset/src/V1/IamPolicySearchResult.php b/tests/fixtures/php/php_asset/src/Asset/src/V1/IamPolicySearchResult.php index ba6752659..807aa6f89 100644 --- a/tests/fixtures/php/php_asset/src/Asset/src/V1/IamPolicySearchResult.php +++ b/tests/fixtures/php/php_asset/src/Asset/src/V1/IamPolicySearchResult.php @@ -42,7 +42,7 @@ class IamPolicySearchResult extends \Google\Protobuf\Internal\Message * projects/{PROJECT_NUMBER}. If an IAM policy is set on a resource (like VM * instance, Cloud Storage bucket), the project field will indicate the * project that contains the resource. If an IAM policy is set on a folder or - * orgnization, this field will be empty. + * organization, this field will be empty. * To search against the `project`: * * specify the `scope` field as this project in your search request. * @@ -123,7 +123,7 @@ class IamPolicySearchResult extends \Google\Protobuf\Internal\Message * projects/{PROJECT_NUMBER}. If an IAM policy is set on a resource (like VM * instance, Cloud Storage bucket), the project field will indicate the * project that contains the resource. If an IAM policy is set on a folder or - * orgnization, this field will be empty. + * organization, this field will be empty. * To search against the `project`: * * specify the `scope` field as this project in your search request. * @type string[]|\Google\Protobuf\Internal\RepeatedField $folders @@ -242,7 +242,7 @@ public function setAssetType($var) * projects/{PROJECT_NUMBER}. If an IAM policy is set on a resource (like VM * instance, Cloud Storage bucket), the project field will indicate the * project that contains the resource. If an IAM policy is set on a folder or - * orgnization, this field will be empty. + * organization, this field will be empty. * To search against the `project`: * * specify the `scope` field as this project in your search request. * @@ -259,7 +259,7 @@ public function getProject() * projects/{PROJECT_NUMBER}. If an IAM policy is set on a resource (like VM * instance, Cloud Storage bucket), the project field will indicate the * project that contains the resource. If an IAM policy is set on a folder or - * orgnization, this field will be empty. + * organization, this field will be empty. * To search against the `project`: * * specify the `scope` field as this project in your search request. * diff --git a/tests/fixtures/php/php_asset/src/Asset/src/V1/ListAssetsRequest.php b/tests/fixtures/php/php_asset/src/Asset/src/V1/ListAssetsRequest.php index a422a71ff..bbf55ffe9 100644 --- a/tests/fixtures/php/php_asset/src/Asset/src/V1/ListAssetsRequest.php +++ b/tests/fixtures/php/php_asset/src/Asset/src/V1/ListAssetsRequest.php @@ -45,7 +45,7 @@ class ListAssetsRequest extends \Google\Protobuf\Internal\Message * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -124,7 +124,7 @@ class ListAssetsRequest extends \Google\Protobuf\Internal\Message * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -248,7 +248,7 @@ public function setReadTime($var) * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -272,7 +272,7 @@ public function getAssetTypes() * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. diff --git a/tests/fixtures/php/php_asset/src/Asset/src/V1/PartitionSpec/PartitionKey.php b/tests/fixtures/php/php_asset/src/Asset/src/V1/PartitionSpec/PartitionKey.php index d7dd49a6d..d418bedec 100644 --- a/tests/fixtures/php/php_asset/src/Asset/src/V1/PartitionSpec/PartitionKey.php +++ b/tests/fixtures/php/php_asset/src/Asset/src/V1/PartitionSpec/PartitionKey.php @@ -25,7 +25,7 @@ class PartitionKey const PARTITION_KEY_UNSPECIFIED = 0; /** * The time when the snapshot is taken. If specified as partition key, the - * result table(s) is partitoned by the additional timestamp column, + * result table(s) is partitioned by the additional timestamp column, * readTime. If [read_time] in ExportAssetsRequest is specified, the * readTime column's value will be the same as it. Otherwise, its value will * be the current time that is used to take the snapshot. @@ -35,7 +35,7 @@ class PartitionKey const READ_TIME = 1; /** * The time when the request is received and started to be processed. If - * specified as partition key, the result table(s) is partitoned by the + * specified as partition key, the result table(s) is partitioned by the * requestTime column, an additional timestamp column representing when the * request was received. * diff --git a/tests/fixtures/php/php_asset/src/Asset/src/V1/ResourceSearchResult.php b/tests/fixtures/php/php_asset/src/Asset/src/V1/ResourceSearchResult.php index 36b924252..50e8a1764 100644 --- a/tests/fixtures/php/php_asset/src/Asset/src/V1/ResourceSearchResult.php +++ b/tests/fixtures/php/php_asset/src/Asset/src/V1/ResourceSearchResult.php @@ -205,7 +205,7 @@ class ResourceSearchResult extends \Google\Protobuf\Internal\Message * attributes](https://cloud.google.com/asset-inventory/docs/supported-asset-types#searchable_asset_types) * to see which fields are included. * You can search values of these fields through free text search. However, - * you should not consume the field programically as the field names and + * you should not consume the field programmatically as the field names and * values may change as the GCP service updates to a new incompatible API * version. * To search against the `additional_attributes`: @@ -412,7 +412,7 @@ class ResourceSearchResult extends \Google\Protobuf\Internal\Message * attributes](https://cloud.google.com/asset-inventory/docs/supported-asset-types#searchable_asset_types) * to see which fields are included. * You can search values of these fields through free text search. However, - * you should not consume the field programically as the field names and + * you should not consume the field programmatically as the field names and * values may change as the GCP service updates to a new incompatible API * version. * To search against the `additional_attributes`: @@ -1047,7 +1047,7 @@ public function setState($var) * attributes](https://cloud.google.com/asset-inventory/docs/supported-asset-types#searchable_asset_types) * to see which fields are included. * You can search values of these fields through free text search. However, - * you should not consume the field programically as the field names and + * you should not consume the field programmatically as the field names and * values may change as the GCP service updates to a new incompatible API * version. * To search against the `additional_attributes`: @@ -1083,7 +1083,7 @@ public function clearAdditionalAttributes() * attributes](https://cloud.google.com/asset-inventory/docs/supported-asset-types#searchable_asset_types) * to see which fields are included. * You can search values of these fields through free text search. However, - * you should not consume the field programically as the field names and + * you should not consume the field programmatically as the field names and * values may change as the GCP service updates to a new incompatible API * version. * To search against the `additional_attributes`: diff --git a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/AnalyzeMoveRequest.php b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/AnalyzeMoveRequest.php index 0cda14e21..14de0ca4a 100644 --- a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/AnalyzeMoveRequest.php +++ b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/AnalyzeMoveRequest.php @@ -27,7 +27,7 @@ class AnalyzeMoveRequest extends \Google\Protobuf\Internal\Message /** * Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * @@ -56,7 +56,7 @@ class AnalyzeMoveRequest extends \Google\Protobuf\Internal\Message * @type string $destination_parent * Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * @type int $view @@ -104,7 +104,7 @@ public function setResource($var) /** * Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * @@ -119,7 +119,7 @@ public function getDestinationParent() /** * Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * diff --git a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/Asset.php b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/Asset.php index e0998ce8a..165f1dc90 100644 --- a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/Asset.php +++ b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/Asset.php @@ -145,13 +145,13 @@ class Asset extends \Google\Protobuf\Internal\Message * There can be more than one organization policy with different constraints * set on a given resource. * @type \Google\Identity\AccessContextManager\V1\AccessPolicy $access_policy - * Please also refer to the [access policy user + * Please refer to the [access policy user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-policies). * @type \Google\Identity\AccessContextManager\V1\AccessLevel $access_level - * Please also refer to the [access level user + * Please refer to the [access level user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-levels). * @type \Google\Identity\AccessContextManager\V1\ServicePerimeter $service_perimeter - * Please also refer to the [service perimeter user + * Please refer to the [service perimeter user * guide](https://cloud.google.com/vpc-service-controls/docs/overview). * @type \Google\Cloud\OsConfig\V1\Inventory $os_inventory * A representation of runtime OS Inventory information. See [this @@ -400,7 +400,7 @@ public function setOrgPolicy($var) } /** - * Please also refer to the [access policy user + * Please refer to the [access policy user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-policies). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.AccessPolicy access_policy = 7; @@ -417,7 +417,7 @@ public function hasAccessPolicy() } /** - * Please also refer to the [access policy user + * Please refer to the [access policy user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-policies). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.AccessPolicy access_policy = 7; @@ -433,7 +433,7 @@ public function setAccessPolicy($var) } /** - * Please also refer to the [access level user + * Please refer to the [access level user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-levels). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.AccessLevel access_level = 8; @@ -450,7 +450,7 @@ public function hasAccessLevel() } /** - * Please also refer to the [access level user + * Please refer to the [access level user * guide](https://cloud.google.com/access-context-manager/docs/overview#access-levels). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.AccessLevel access_level = 8; @@ -466,7 +466,7 @@ public function setAccessLevel($var) } /** - * Please also refer to the [service perimeter user + * Please refer to the [service perimeter user * guide](https://cloud.google.com/vpc-service-controls/docs/overview). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.ServicePerimeter service_perimeter = 9; @@ -483,7 +483,7 @@ public function hasServicePerimeter() } /** - * Please also refer to the [service perimeter user + * Please refer to the [service perimeter user * guide](https://cloud.google.com/vpc-service-controls/docs/overview). * * Generated from protobuf field .google.identity.accesscontextmanager.v1.ServicePerimeter service_perimeter = 9; diff --git a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/BigQueryDestination.php b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/BigQueryDestination.php index a364d668c..f975a2b2e 100644 --- a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/BigQueryDestination.php +++ b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/BigQueryDestination.php @@ -36,7 +36,7 @@ class BigQueryDestination extends \Google\Protobuf\Internal\Message * If the destination table already exists and this flag is `TRUE`, the * table will be overwritten by the contents of assets snapshot. If the flag * is `FALSE` or unset and the destination table already exists, the export - * call returns an INVALID_ARGUMEMT error. + * call returns an INVALID_ARGUMENT error. * * Generated from protobuf field bool force = 3; */ @@ -110,7 +110,7 @@ class BigQueryDestination extends \Google\Protobuf\Internal\Message * If the destination table already exists and this flag is `TRUE`, the * table will be overwritten by the contents of assets snapshot. If the flag * is `FALSE` or unset and the destination table already exists, the export - * call returns an INVALID_ARGUMEMT error. + * call returns an INVALID_ARGUMENT error. * @type \Google\Cloud\Asset\V1\PartitionSpec $partition_spec * [partition_spec] determines whether to export to partitioned table(s) and * how to partition the data. @@ -225,7 +225,7 @@ public function setTable($var) * If the destination table already exists and this flag is `TRUE`, the * table will be overwritten by the contents of assets snapshot. If the flag * is `FALSE` or unset and the destination table already exists, the export - * call returns an INVALID_ARGUMEMT error. + * call returns an INVALID_ARGUMENT error. * * Generated from protobuf field bool force = 3; * @return bool @@ -239,7 +239,7 @@ public function getForce() * If the destination table already exists and this flag is `TRUE`, the * table will be overwritten by the contents of assets snapshot. If the flag * is `FALSE` or unset and the destination table already exists, the export - * call returns an INVALID_ARGUMEMT error. + * call returns an INVALID_ARGUMENT error. * * Generated from protobuf field bool force = 3; * @param bool $var diff --git a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/ExportAssetsRequest.php b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/ExportAssetsRequest.php index 29d28003d..99f67c2e3 100644 --- a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/ExportAssetsRequest.php +++ b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/ExportAssetsRequest.php @@ -45,7 +45,7 @@ class ExportAssetsRequest extends \Google\Protobuf\Internal\Message * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -115,7 +115,7 @@ class ExportAssetsRequest extends \Google\Protobuf\Internal\Message * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -234,7 +234,7 @@ public function setReadTime($var) * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -258,7 +258,7 @@ public function getAssetTypes() * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. diff --git a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/Feed.php b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/Feed.php index bc1313b13..c39e46294 100644 --- a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/Feed.php +++ b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/Feed.php @@ -98,7 +98,7 @@ class Feed extends \Google\Protobuf\Internal\Message * * Otherwise: * it outputs the supported relationships of the types of [asset_names] and * [asset_types] or returns an error if any of the [asset_names] or the - * [asset_types] has no replationship support. + * [asset_types] has no relationship support. * See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types and relationship types. @@ -168,7 +168,7 @@ class Feed extends \Google\Protobuf\Internal\Message * * Otherwise: * it outputs the supported relationships of the types of [asset_names] and * [asset_types] or returns an error if any of the [asset_names] or the - * [asset_types] has no replationship support. + * [asset_types] has no relationship support. * See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types and relationship types. @@ -428,7 +428,7 @@ public function setCondition($var) * * Otherwise: * it outputs the supported relationships of the types of [asset_names] and * [asset_types] or returns an error if any of the [asset_names] or the - * [asset_types] has no replationship support. + * [asset_types] has no relationship support. * See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types and relationship types. @@ -454,7 +454,7 @@ public function getRelationshipTypes() * * Otherwise: * it outputs the supported relationships of the types of [asset_names] and * [asset_types] or returns an error if any of the [asset_names] or the - * [asset_types] has no replationship support. + * [asset_types] has no relationship support. * See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types and relationship types. diff --git a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/IamPolicyAnalysisOutputConfig/BigQueryDestination/PartitionKey.php b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/IamPolicyAnalysisOutputConfig/BigQueryDestination/PartitionKey.php index 6902ee9a9..2c9f50618 100644 --- a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/IamPolicyAnalysisOutputConfig/BigQueryDestination/PartitionKey.php +++ b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/IamPolicyAnalysisOutputConfig/BigQueryDestination/PartitionKey.php @@ -25,7 +25,7 @@ class PartitionKey const PARTITION_KEY_UNSPECIFIED = 0; /** * The time when the request is received. If specified as partition key, - * the result table(s) is partitoned by the RequestTime column, an + * the result table(s) is partitioned by the RequestTime column, an * additional timestamp column representing when the request was received. * * Generated from protobuf enum REQUEST_TIME = 1; diff --git a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/IamPolicySearchResult.php b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/IamPolicySearchResult.php index 76b19b241..8b1c396d5 100644 --- a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/IamPolicySearchResult.php +++ b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/IamPolicySearchResult.php @@ -42,7 +42,7 @@ class IamPolicySearchResult extends \Google\Protobuf\Internal\Message * projects/{PROJECT_NUMBER}. If an IAM policy is set on a resource (like VM * instance, Cloud Storage bucket), the project field will indicate the * project that contains the resource. If an IAM policy is set on a folder or - * orgnization, this field will be empty. + * organization, this field will be empty. * To search against the `project`: * * specify the `scope` field as this project in your search request. * @@ -123,7 +123,7 @@ class IamPolicySearchResult extends \Google\Protobuf\Internal\Message * projects/{PROJECT_NUMBER}. If an IAM policy is set on a resource (like VM * instance, Cloud Storage bucket), the project field will indicate the * project that contains the resource. If an IAM policy is set on a folder or - * orgnization, this field will be empty. + * organization, this field will be empty. * To search against the `project`: * * specify the `scope` field as this project in your search request. * @type string[]|\Google\Protobuf\Internal\RepeatedField $folders @@ -242,7 +242,7 @@ public function setAssetType($var) * projects/{PROJECT_NUMBER}. If an IAM policy is set on a resource (like VM * instance, Cloud Storage bucket), the project field will indicate the * project that contains the resource. If an IAM policy is set on a folder or - * orgnization, this field will be empty. + * organization, this field will be empty. * To search against the `project`: * * specify the `scope` field as this project in your search request. * @@ -259,7 +259,7 @@ public function getProject() * projects/{PROJECT_NUMBER}. If an IAM policy is set on a resource (like VM * instance, Cloud Storage bucket), the project field will indicate the * project that contains the resource. If an IAM policy is set on a folder or - * orgnization, this field will be empty. + * organization, this field will be empty. * To search against the `project`: * * specify the `scope` field as this project in your search request. * diff --git a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/ListAssetsRequest.php b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/ListAssetsRequest.php index 9f6907441..b4e970e9e 100644 --- a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/ListAssetsRequest.php +++ b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/ListAssetsRequest.php @@ -45,7 +45,7 @@ class ListAssetsRequest extends \Google\Protobuf\Internal\Message * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -124,7 +124,7 @@ class ListAssetsRequest extends \Google\Protobuf\Internal\Message * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -248,7 +248,7 @@ public function setReadTime($var) * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -272,7 +272,7 @@ public function getAssetTypes() * See [RE2](https://github.com/google/re2/wiki/Syntax) for all supported * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. diff --git a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/PartitionSpec/PartitionKey.php b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/PartitionSpec/PartitionKey.php index d7dd49a6d..d418bedec 100644 --- a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/PartitionSpec/PartitionKey.php +++ b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/PartitionSpec/PartitionKey.php @@ -25,7 +25,7 @@ class PartitionKey const PARTITION_KEY_UNSPECIFIED = 0; /** * The time when the snapshot is taken. If specified as partition key, the - * result table(s) is partitoned by the additional timestamp column, + * result table(s) is partitioned by the additional timestamp column, * readTime. If [read_time] in ExportAssetsRequest is specified, the * readTime column's value will be the same as it. Otherwise, its value will * be the current time that is used to take the snapshot. @@ -35,7 +35,7 @@ class PartitionKey const READ_TIME = 1; /** * The time when the request is received and started to be processed. If - * specified as partition key, the result table(s) is partitoned by the + * specified as partition key, the result table(s) is partitioned by the * requestTime column, an additional timestamp column representing when the * request was received. * diff --git a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/ResourceSearchResult.php b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/ResourceSearchResult.php index 690c3b988..abc52673a 100644 --- a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/ResourceSearchResult.php +++ b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/proto/src/Google/Cloud/Asset/V1/ResourceSearchResult.php @@ -205,7 +205,7 @@ class ResourceSearchResult extends \Google\Protobuf\Internal\Message * attributes](https://cloud.google.com/asset-inventory/docs/supported-asset-types#searchable_asset_types) * to see which fields are included. * You can search values of these fields through free text search. However, - * you should not consume the field programically as the field names and + * you should not consume the field programmatically as the field names and * values may change as the GCP service updates to a new incompatible API * version. * To search against the `additional_attributes`: @@ -412,7 +412,7 @@ class ResourceSearchResult extends \Google\Protobuf\Internal\Message * attributes](https://cloud.google.com/asset-inventory/docs/supported-asset-types#searchable_asset_types) * to see which fields are included. * You can search values of these fields through free text search. However, - * you should not consume the field programically as the field names and + * you should not consume the field programmatically as the field names and * values may change as the GCP service updates to a new incompatible API * version. * To search against the `additional_attributes`: @@ -1047,7 +1047,7 @@ public function setState($var) * attributes](https://cloud.google.com/asset-inventory/docs/supported-asset-types#searchable_asset_types) * to see which fields are included. * You can search values of these fields through free text search. However, - * you should not consume the field programically as the field names and + * you should not consume the field programmatically as the field names and * values may change as the GCP service updates to a new incompatible API * version. * To search against the `additional_attributes`: @@ -1083,7 +1083,7 @@ public function clearAdditionalAttributes() * attributes](https://cloud.google.com/asset-inventory/docs/supported-asset-types#searchable_asset_types) * to see which fields are included. * You can search values of these fields through free text search. However, - * you should not consume the field programically as the field names and + * you should not consume the field programmatically as the field names and * values may change as the GCP service updates to a new incompatible API * version. * To search against the `additional_attributes`: diff --git a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/samples/V1/AssetServiceClient/analyze_move.php b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/samples/V1/AssetServiceClient/analyze_move.php index 60b26384d..c400f4ab2 100644 --- a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/samples/V1/AssetServiceClient/analyze_move.php +++ b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/samples/V1/AssetServiceClient/analyze_move.php @@ -40,7 +40,7 @@ * "projects/12345"). * @param string $destinationParent Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). */ diff --git a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/src/V1/Gapic/AssetServiceGapicClient.php b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/src/V1/Gapic/AssetServiceGapicClient.php index 0c64ca0f7..92ad61fd9 100644 --- a/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/src/V1/Gapic/AssetServiceGapicClient.php +++ b/tests/fixtures/php/php_asset/src/owl-bot-staging/Asset/V1/src/V1/Gapic/AssetServiceGapicClient.php @@ -562,7 +562,7 @@ public function analyzeIamPolicyLongrunning($analysisQuery, $outputConfig, array * "projects/12345"). * @param string $destinationParent Required. Name of the GCP Folder or Organization to reparent the target * resource. The analysis will be performed against hypothetically moving the - * resource to this specified desitination parent. This can only be a Folder + * resource to this specified destination parent. This can only be a Folder * number (such as "folders/123") or an Organization number (such as * "organizations/123"). * @param array $optionalArgs { @@ -874,7 +874,7 @@ public function deleteFeed($name, array $optionalArgs = []) * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. * - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. @@ -1035,7 +1035,7 @@ public function getFeed($name, array $optionalArgs = []) * regular expression syntax. If the regular expression does not match any * supported asset type, an INVALID_ARGUMENT error will be returned. * - * If specified, only matching assets will be returned, otherwise, it will + * If specified, only matching assets will be returned; otherwise, it will * snapshot all asset types. See [Introduction to Cloud Asset * Inventory](https://cloud.google.com/asset-inventory/docs/overview) * for all supported asset types. diff --git a/tests/fixtures/python_library/setup.py b/tests/fixtures/python_library/setup.py index c4fb30196..11ac2c6ca 100644 --- a/tests/fixtures/python_library/setup.py +++ b/tests/fixtures/python_library/setup.py @@ -95,7 +95,7 @@ "Operating System :: OS Independent", "Topic :: Internet", ], - platforms="Posix; MacOS X; Windows", + platforms="POSIX; MacOS X; Windows", packages=packages, namespace_packages=namespaces, install_requires=dependencies, diff --git a/tests/fixtures/python_library_w_version_py/setup.py b/tests/fixtures/python_library_w_version_py/setup.py index c4fb30196..11ac2c6ca 100644 --- a/tests/fixtures/python_library_w_version_py/setup.py +++ b/tests/fixtures/python_library_w_version_py/setup.py @@ -95,7 +95,7 @@ "Operating System :: OS Independent", "Topic :: Internet", ], - platforms="Posix; MacOS X; Windows", + platforms="POSIX; MacOS X; Windows", packages=packages, namespace_packages=namespaces, install_requires=dependencies, diff --git a/tests/test_metadata.py b/tests/test_metadata.py index 296105c6c..1ffdcfcb2 100644 --- a/tests/test_metadata.py +++ b/tests/test_metadata.py @@ -265,7 +265,7 @@ def test_add_new_files_with_bad_file(source_tree, preserve_track_obsolete_file_f try: os.symlink(tmpdir / dne, tmpdir / "badlink") except OSError: - # On Windows, creating a symlink requires Admin priveleges, which + # On Windows, creating a symlink requires Admin privileges, which # should never be granted to test runners. assert "win32" == sys.platform return @@ -293,9 +293,9 @@ def test_read_nonexistent_metadata(tmpdir): @pytest.fixture(scope="function") def preserve_track_obsolete_file_flag(): - should_track_obselete_files = metadata.should_track_obsolete_files() - yield should_track_obselete_files - metadata.set_track_obsolete_files(should_track_obselete_files) + should_track_obsolete_files = metadata.should_track_obsolete_files() + yield should_track_obsolete_files + metadata.set_track_obsolete_files(should_track_obsolete_files) def test_track_obsolete_files_defaults_to_false(preserve_track_obsolete_file_flag): diff --git a/tests/test_partials.py b/tests/test_partials.py index ed89a1558..522fccf54 100644 --- a/tests/test_partials.py +++ b/tests/test_partials.py @@ -28,5 +28,5 @@ def test_readme_partials(): def test_readme_partials_not_found(): - data = partials.load_partials(["non-existent.yaml"]) + data = partials.load_partials(["nonexistent.yaml"]) assert len(data) == 0 diff --git a/tests/test_snippets.py b/tests/test_snippets.py index b994bad0d..d3d4abee1 100644 --- a/tests/test_snippets.py +++ b/tests/test_snippets.py @@ -114,7 +114,7 @@ def test_nested_snippets(): def test_non_existent_file(): with util.chdir(FIXTURES): - all_snippets = snippets.all_snippets_from_file("snippets/non-existent-file.foo") + all_snippets = snippets.all_snippets_from_file("snippets/nonexistent-file.foo") assert len(all_snippets) == 0 diff --git a/tests/test_transforms.py b/tests/test_transforms.py index b5033a066..03fcbf27c 100644 --- a/tests/test_transforms.py +++ b/tests/test_transforms.py @@ -233,7 +233,7 @@ def test_replace_not_found(expand_path_fixtures): def test_required_move_not_found(): try: - transforms.move(["non-existent"], required=True) + transforms.move(["nonexistent"], required=True) assert False, "should have thrown error" except transforms.MissingSourceError: assert True