A suspicious use of an incrementer in for loop

[lifove]

Hi

I've found a suspicious use of an incrementer in the recent snapshot.
(Path: com.windowtester.swt.runtime/src/com/windowtester/runtime/swt/internal/finder/eclipse/views/ViewExplorer.java)

In Line 57, should views[i] be views[j]? I have no idea if categories.length is same as views.length so just report the issue.

Thanks!

53                 for (int i = 0; i < categories.length; i++) {
 54                         IViewCategory category = categories[i];
 55                         IViewDescriptor[] views = category.getViews();
 56                         for (int j = 0; j < views.length; j++) {
 57                                 IViewDescriptor candidateView = views[i];
 58                                 if (view == candidateView)
 59                                         return category.getLabel();
 60                         }
 61                 }

[fredg02]

Indeed, this looks suspicious. How did you find that error? Just by accident? Have you tested the method where it is used?

[lifove]

I used a static analysis tool. Then, after reading the source code file, I found that it is quite suspicious as the loop was only one using inconsistent incrementers compared to that in other methods. I have not tested the method. Sorry for it.

[fredg02]

No worries. Thanks for finding that issue.
Are you using WindowTester in production?

[lifove]

No, I'm just a researcher who wants to develop useful tools for developers. I was implementing my own static analysis tool that provides less (hopefully no) false positive results. Thanks!