From 868c42a09e01928b8005fd09eee1783b30bb3e76 Mon Sep 17 00:00:00 2001 From: Isabella Basso do Amaral Date: Thu, 5 Sep 2024 14:29:14 -0300 Subject: [PATCH] fix missing fields when ordering by Signed-off-by: Isabella Basso do Amaral --- ml_metadata/metadata_store/postgresql_query_executor.cc | 2 +- ml_metadata/metadata_store/query_config_executor.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ml_metadata/metadata_store/postgresql_query_executor.cc b/ml_metadata/metadata_store/postgresql_query_executor.cc index 501a9251b..47237ac9b 100644 --- a/ml_metadata/metadata_store/postgresql_query_executor.cc +++ b/ml_metadata/metadata_store/postgresql_query_executor.cc @@ -903,7 +903,7 @@ absl::Status PostgreSQLQueryExecutor::ListNodeIDsUsingOptions( sql_gen_status.message())); } sql_query = absl::Substitute( - "SELECT distinct $0.id, $0.create_time_since_epoch FROM $1 WHERE $2 " + "SELECT distinct $0.id, $0.create_time_since_epoch, $0.last_update_time_since_epoch FROM $1 WHERE $2 " "AND ", *node_table_alias, // TODO(b/257334039): remove query_version-conditional logic diff --git a/ml_metadata/metadata_store/query_config_executor.cc b/ml_metadata/metadata_store/query_config_executor.cc index d369a511d..0e5688dce 100644 --- a/ml_metadata/metadata_store/query_config_executor.cc +++ b/ml_metadata/metadata_store/query_config_executor.cc @@ -844,7 +844,7 @@ absl::Status QueryConfigExecutor::ListNodeIDsUsingOptions( sql_gen_status.message())); } sql_query = absl::Substitute( - "SELECT distinct $0.`id` FROM $1 WHERE $2 AND ", *node_table_alias, + "SELECT distinct $0.`id`, $0.`create_time_since_epoch`, $0.`last_update_time_since_epoch` FROM $1 WHERE $2 AND ", *node_table_alias, // TODO(b/257334039): remove query_version-conditional logic query_builder.GetFromClause(query_version), query_builder.GetWhereClause());