Skip to content

[Task Editor] Improve rendering performance#2462

Merged
rfontanarosa merged 7 commits intomasterfrom
rfontanarosa/2247/task-editor-is-slow-when-there-are-too-many-tasks
Mar 25, 2026
Merged

[Task Editor] Improve rendering performance#2462
rfontanarosa merged 7 commits intomasterfrom
rfontanarosa/2247/task-editor-is-slow-when-there-are-too-many-tasks

Conversation

@rfontanarosa
Copy link
Collaborator

@rfontanarosa rfontanarosa commented Mar 21, 2026

closes #2247

  • trackBy to prevent angular from destroying and recreating DOM nodes on every change
  • Lifted expanded state from each TaskFormComponent instance up to TaskEditorComponent as a signal
  • ChangeDetectionStrategy.OnPush on TaskFormComponent and TaskConditionFormComponent so they only re-render when their inputs actually change
  • input() + effect() replacing @input() tasks + ngOnChanges in TaskEditorComponent, so the form is only rebuilt when the tasks signal changes — not on every input
    change
  • TaskOptionsPipe made pure to avoid re-evaluation on every change detection cycle

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.38%. Comparing base (48817b2) to head (ab64490).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...onents/shared/task-editor/task-editor.component.ts 60.00% 6 Missing ⚠️
...hared/task-editor/task-form/task-form.component.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2462      +/-   ##
==========================================
+ Coverage   59.32%   59.38%   +0.05%     
==========================================
  Files         113      113              
  Lines        2793     2797       +4     
  Branches      422      421       -1     
==========================================
+ Hits         1657     1661       +4     
  Misses       1074     1074              
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rfontanarosa rfontanarosa requested a review from gino-m March 21, 2026 19:48
@rfontanarosa rfontanarosa self-assigned this Mar 21, 2026
@rfontanarosa rfontanarosa merged commit 8d8f16e into master Mar 25, 2026
9 checks passed
@rfontanarosa rfontanarosa deleted the rfontanarosa/2247/task-editor-is-slow-when-there-are-too-many-tasks branch March 25, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task editor is slow when there are too many tasks

3 participants