Skip to content

Improve start-emulator action#2457

Merged
rfontanarosa merged 5 commits intomasterfrom
andreia/add-more-logs-to-ci
Mar 17, 2026
Merged

Improve start-emulator action#2457
rfontanarosa merged 5 commits intomasterfrom
andreia/add-more-logs-to-ci

Conversation

@andreia-ferreira
Copy link
Collaborator

The android CI depends on the start-emulator action. However, sometimes this action fails and the log file was not being correctly stored/retrievable. This PR updates the output location and adds the buffered output with stdbuf to ensure the logs are as complete as possible.
It also adds a fail-fast check so the action exits immediately if the emulator process crashes.

@gino-m @rfontanarosa PTAL?

@auto-assign auto-assign bot requested a review from rfontanarosa March 17, 2026 11:51
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the start-emulator action used in Android CI by improving log management and adding a fail-fast mechanism. These changes ensure more reliable and informative CI runs by addressing issues with log retrieval and unexpected emulator crashes.

Highlights

  • Log Storage: The log file location for the Firebase emulator was updated to /tmp/firebase-emulator.log to ensure correct storage and retrieval.
  • Buffered Output: The action now uses stdbuf to buffer the output, aiming to capture more complete logs.
  • Fail-Fast Check: A fail-fast check was added to immediately exit the action if the emulator process crashes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .github/actions/start-emulator/action.yml
    • Updated log file location to /tmp/firebase-emulator.log
    • Added stdbuf to buffer output for more complete logs
    • Implemented a fail-fast check to exit immediately if the emulator crashes
Activity
  • The pull request addresses issues with the start-emulator action in Android CI.
  • The author, andreia-ferreira, requests reviews from gino-m and rfontanarosa.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the start-emulator action by adding stdbuf for better log buffering, moving logs to /tmp, and implementing a fail-fast check for the emulator process. These are solid improvements for the CI's reliability and debuggability. I have one suggestion to further enhance logging when the emulator process exits unexpectedly.

@rfontanarosa rfontanarosa merged commit 18e836d into master Mar 17, 2026
9 checks passed
@rfontanarosa rfontanarosa deleted the andreia/add-more-logs-to-ci branch March 17, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants