diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ArrayEqualsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ArrayEqualsTest.java index 8032b99b2c3..943bcd613f9 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ArrayEqualsTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ArrayEqualsTest.java @@ -118,7 +118,7 @@ public void bothMethodCalls() { System.out.println("arrays are not equal!"); } } - }\ + } """) .doTest(); } @@ -163,7 +163,7 @@ public void objectArray() { System.out.println("arrays are not equal!"); } } - }\ + } """) .doTest(); } @@ -232,7 +232,7 @@ public void secondArray() { System.out.println("Objects are not equal!"); } } - }\ + } """) .doTest(); } @@ -285,7 +285,7 @@ public void secondArray() { System.out.println("arrays are not equal!"); } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ArrayHashCodeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ArrayHashCodeTest.java index 2112ff5af87..98a57419e3c 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ArrayHashCodeTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ArrayHashCodeTest.java @@ -104,7 +104,7 @@ public void varargsHashCodeOnMoreThanOneArg() { // Arrays.deepHashCode(multidimensionalStringArray)) hashCode = Objects.hashCode(obj1, obj2, multidimensionalStringArray); } -}\ +} """) .doTest(); } @@ -148,7 +148,7 @@ public void varagsHashCodeOnObjectOrStringArray() { hashCode = Objects.hashCode(objArray); hashCode = Objects.hashCode((Object[]) stringArray); } - }\ + } """) .doTest(); } @@ -195,7 +195,7 @@ public void varagsHashCodeOnObjectOrStringArray() { hashCode = Objects.hash(objArray); hashCode = Objects.hash((Object[]) stringArray); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ArrayToStringTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ArrayToStringTest.java index 2f151036060..99e11070ef8 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ArrayToStringTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ArrayToStringTest.java @@ -102,7 +102,7 @@ public void arrayOfArrays() { // BUG: Diagnostic contains: Arrays.deepToString(a) System.out.println(a); } - }\ + } """) .doTest(); } @@ -130,7 +130,7 @@ public void objectEquals() { System.out.println("string is not empty!"); } } - }\ + } """) .doTest(); } @@ -307,7 +307,7 @@ public void stringVariableAddsArrayAndAssigns() { // BUG: Diagnostic contains: += Arrays.toString(a) b += a; } - }\ + } """) .doTest(); } @@ -335,7 +335,7 @@ public void concatenateCompoundAssign_int() { String b = " a string "; b += a; } - }\ + } """) .doTest(); } @@ -366,7 +366,7 @@ public void stringLiteralRightOperandIsArray() { // BUG: Diagnostic contains: + Arrays.toString(a) String b = "a string" + a; } - }\ + } """) .doTest(); } @@ -393,7 +393,7 @@ public void notArray_refactored() { String b = " a string"; String c = a + b; } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/AssertFalseTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/AssertFalseTest.java index 76e2a97c2f6..ec93b40e112 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/AssertFalseTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/AssertFalseTest.java @@ -50,7 +50,7 @@ public void assertTrue() { public void assertFalseFromCondition() { assert 0 == 1; } - }\ + } """) .doTest(); } @@ -71,7 +71,7 @@ public void assertFalse() { // BUG: Diagnostic contains: throw new AssertionError() assert false; } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/AsyncFunctionReturnsNullTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/AsyncFunctionReturnsNullTest.java index 7eff9365cd2..811f98d34b5 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/AsyncFunctionReturnsNullTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/AsyncFunctionReturnsNullTest.java @@ -140,7 +140,7 @@ public ListenableFuture apply(String input) throws Exception { interface MyNonAsyncFunction { ListenableFuture apply(@Nullable I input) throws Exception; } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/BadComparableTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/BadComparableTest.java index 2544c4150c7..10b38e17165 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/BadComparableTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/BadComparableTest.java @@ -85,7 +85,7 @@ public int compare(File lhs, File rhs) { return (int) (rhs.lastModified() - lhs.lastModified()); } }; -}\ +} """) .doTest(); } @@ -232,7 +232,7 @@ public char compare(byte n1, byte n2) { return (char) (n1 - n2); } }; - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/BadImportTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/BadImportTest.java index cd3f6df0091..e0801ba9eee 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/BadImportTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/BadImportTest.java @@ -355,7 +355,7 @@ void useNestedBuilder() { new Builder(); } } - }\ + } """) .doTest(); } @@ -501,7 +501,7 @@ ImmutableList.Builder returnRaw() { void classLiteral() { System.out.println(ImmutableList.Builder.class); } -}\ +} """) .doTest(TestMode.AST_MATCH); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/BadShiftAmountTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/BadShiftAmountTest.java index 4a56e6bde5d..9fde3076483 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/BadShiftAmountTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/BadShiftAmountTest.java @@ -78,7 +78,7 @@ public void foo() { // BUG: Diagnostic contains: (long) c >>> 32 result += c >>> 32; } - }\ + } """) .doTest(); } @@ -105,7 +105,7 @@ public void foo() { result += x >>> 3; result += (long) (x & 0xff) >> 40; } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/BanClassLoaderTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/BanClassLoaderTest.java index 4f2f2c3bec0..2c98af5c7ec 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/BanClassLoaderTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/BanClassLoaderTest.java @@ -83,7 +83,7 @@ public static final Class methodHandlesDefineClass(byte[] bytes) // BUG: Diagnostic contains: BanClassLoader return MethodHandles.lookup().defineClass(bytes); } -}\ +} """) .doTest(); } @@ -114,7 +114,7 @@ public final Class overrideClassLoader() throws ClassNotFoundException { private class NotClassLoader { protected void loadClass() {} } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/BanJNDITest.java b/core/src/test/java/com/google/errorprone/bugpatterns/BanJNDITest.java index 4222c16fb7e..4dc475c0315 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/BanJNDITest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/BanJNDITest.java @@ -169,7 +169,7 @@ private Object subclassesJavaNamingcontext() throws NamingException { // BUG: Diagnostic contains: BanJNDI return c.lookup("hello"); } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ByteBufferBackingArrayTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ByteBufferBackingArrayTest.java index 48c882487f0..a334c9851a5 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ByteBufferBackingArrayTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ByteBufferBackingArrayTest.java @@ -104,7 +104,7 @@ void array_precededByNotAValidMethod_isFlagged() { // BUG: Diagnostic contains: ByteBuffer.array() buff.array(); } -}\ +} """) .doTest(); } @@ -249,7 +249,7 @@ void array_inLambdaExpression_precededByByteBufferAllocate_isNotFlagged() { return null; }; } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/CannotMockFinalClassTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/CannotMockFinalClassTest.java index 6393f87c9fb..54330dc8dad 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/CannotMockFinalClassTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/CannotMockFinalClassTest.java @@ -54,7 +54,7 @@ public void method() { // BUG: Diagnostic contains: Mockito cannot mock FinalClass local = Mockito.mock(FinalClass.class); } - }\ + } """) .doTest(); } @@ -102,7 +102,7 @@ static class NonFinalClass {} public void method() { NonFinalClass local = Mockito.mock(NonFinalClass.class); } - }\ + } """) .doTest(); } @@ -125,7 +125,7 @@ static final class FinalClass {} public void method() { FinalClass local = Mockito.mock(FinalClass.class); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ChainedAssertionLosesContextTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ChainedAssertionLosesContextTest.java index 71ae709219d..d5429428f76 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ChainedAssertionLosesContextTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ChainedAssertionLosesContextTest.java @@ -126,7 +126,7 @@ Foo otherFoo() { return this; } } -}\ +} """) .doTest(); } @@ -191,7 +191,7 @@ Foo otherFoo() { return this; } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ChainingConstructorIgnoresParameterTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ChainingConstructorIgnoresParameterTest.java index a028af576f1..84d2eb28714 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ChainingConstructorIgnoresParameterTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ChainingConstructorIgnoresParameterTest.java @@ -122,7 +122,7 @@ static class MultipleQueuedErrors { enum Location { TEST_TARGET } -}\ +} """) .doTest(); } @@ -233,7 +233,7 @@ static class Varargs2 { this("something"); } } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/CheckReturnValueTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/CheckReturnValueTest.java index 77eb62b290c..3eb2b154e5b 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/CheckReturnValueTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/CheckReturnValueTest.java @@ -229,7 +229,7 @@ public static void ignoresCheck() { check(); } } -}\ +} """) .doTest(); } @@ -356,7 +356,7 @@ public void testMethodReference(boolean predicate) { callSupplier(this::mustCheck); callSupplier(predicate ? this::mustCheck : this::nothingToCheck); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ClassCanBeStaticTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ClassCanBeStaticTest.java index 48ab3a1a4eb..f13d38d2487 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ClassCanBeStaticTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ClassCanBeStaticTest.java @@ -111,7 +111,7 @@ int localMethod() { } } } - }\ + } """) .setArgs("--release", "11") .doTest(); @@ -137,7 +137,7 @@ public class ClassCanBeStaticPositiveCase1 { class Inner1 { int innerVar; } - }\ + } """) .doTest(); } @@ -168,7 +168,7 @@ int localMethod(int outerVar2) { return outerVar2; } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/CollectionToArraySafeParameterTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/CollectionToArraySafeParameterTest.java index 122c033bbd2..f8b7c09ba56 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/CollectionToArraySafeParameterTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/CollectionToArraySafeParameterTest.java @@ -77,7 +77,7 @@ void test(FooBar foo) { class FooBar extends HashSet {} class Foo extends HashSet {} - }\ + } """) .doTest(); } @@ -142,7 +142,7 @@ Integer[] toArray(Integer[] someArray) { return new Integer[10]; } } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/CollectorShouldNotUseStateTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/CollectorShouldNotUseStateTest.java index 53a382a5f61..8f1443fdd84 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/CollectorShouldNotUseStateTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/CollectorShouldNotUseStateTest.java @@ -87,7 +87,7 @@ public void accept(Builder objectBuilder, Object o) { (left, right) -> left.addAll(right.build()), ImmutableList.Builder::build); } - }\ + } """) .doTest(); } @@ -127,7 +127,7 @@ public void accept(Builder objectBuilder, Object o) { (left, right) -> left.addAll(right.build()), ImmutableList.Builder::build); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ComparableAndComparatorTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ComparableAndComparatorTest.java index b4368b26fe9..69d4c363b3d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ComparableAndComparatorTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ComparableAndComparatorTest.java @@ -75,7 +75,7 @@ public int compareTo(SubClass o) { return 0; } } - }\ + } """) .doTest(); } @@ -162,7 +162,7 @@ public int compare(Integer one, Integer two) { return 0; } } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ComparableTypeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ComparableTypeTest.java index 0dd57f58273..0fd25eaa4d5 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ComparableTypeTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ComparableTypeTest.java @@ -149,7 +149,7 @@ public int compareTo(Integer o) { return 0; } } -}\ +} """) .doTest(); } @@ -256,7 +256,7 @@ public int compareTo(Object o) { return 0; } } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ComparisonContractViolatedTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ComparisonContractViolatedTest.java index 62d459ba035..5ec097cf9b9 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ComparisonContractViolatedTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ComparisonContractViolatedTest.java @@ -143,7 +143,7 @@ public int compare(Struct o1, Struct o2) { return o1.equals(o2) ? 0 : POSITIVE_CONSTANT; } }; - }\ + } """) .doTest(); } @@ -180,7 +180,7 @@ public int compareTo(IntOrInfinity o) { return (o instanceof NegativeInfinity) ? 0 : -1; } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ComparisonOutOfRangeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ComparisonOutOfRangeTest.java index f25dcedde72..dd664eb0f74 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ComparisonOutOfRangeTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ComparisonOutOfRangeTest.java @@ -166,7 +166,7 @@ void longs(long l) { // BUG: Diagnostic contains: false result = l == Long.MIN_VALUE * 2.0; } - }\ + } """) .doTest(); } @@ -278,7 +278,7 @@ void longs(long l) { String binaryTreeMixingByteWithNonNumeric(byte b) { return "value is: " + b; } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/DeadExceptionTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/DeadExceptionTest.java index 95ccc22f351..061297d3f9c 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/DeadExceptionTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/DeadExceptionTest.java @@ -98,7 +98,7 @@ public void testLooksLikeAJunitTestMethod() { // BUG: Diagnostic contains: throw new Exception new Exception(); } - }\ + } """) .doTest(); } @@ -121,7 +121,7 @@ public void noError() { public Exception returnsException() { return new RuntimeException("returned"); } - }\ + } """) .doTest(); } @@ -164,7 +164,7 @@ public void shouldAllowTestingOfExceptionConstructorSideEffects() { // expected } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/DepAnnTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/DepAnnTest.java index a78c3f2ee17..2b7ea633a74 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/DepAnnTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/DepAnnTest.java @@ -76,7 +76,7 @@ interface Interface {} */ // BUG: Diagnostic contains: @Deprecated public void deprecatedMethood() {} - }\ + } """) .doTest(); } @@ -140,7 +140,7 @@ public void deprecatedMethodWithMalformedComment() {} public void suppressed() {} public void newMethod() {} - }\ + } """) .doTest(); } @@ -177,7 +177,7 @@ class SummaryRowKey

{} public abstract void m2(); } - }\ + } """) .doTest(); } @@ -229,7 +229,7 @@ interface Interface {} */ // BUG: Diagnostic contains: @Deprecated public void deprecatedMethood() {} - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/EmptyCatchTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/EmptyCatchTest.java index 94170993c72..a93303c0f70 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/EmptyCatchTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/EmptyCatchTest.java @@ -68,7 +68,7 @@ public void expectedException() { } catch (Exception expected) { } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/EmptyIfStatementTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/EmptyIfStatementTest.java index 31bfbedf0b5..681b8ea4b63 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/EmptyIfStatementTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/EmptyIfStatementTest.java @@ -86,7 +86,7 @@ public static void positiveCase5() { System.out.println("foo"); } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/EqualsHashCodeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/EqualsHashCodeTest.java index 5fda4fba676..a354d6ba7e1 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/EqualsHashCodeTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/EqualsHashCodeTest.java @@ -42,7 +42,7 @@ public boolean equals(Object o) { return false; } } -}\ +} """) .doTest(); } @@ -72,7 +72,7 @@ public int hashCode() { } public static class Neither {} - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/EqualsIncompatibleTypeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/EqualsIncompatibleTypeTest.java index ac5b9fb62aa..3afd83fc665 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/EqualsIncompatibleTypeTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/EqualsIncompatibleTypeTest.java @@ -194,7 +194,7 @@ void testSomeGenerics( // BUG: Diagnostic contains: T and String are incompatible iClazz.equals(strClazz); } -}\ +} """) .doTest(); } @@ -393,7 +393,7 @@ abstract class F2 { void checkOtherEquals(F1 f1, F2 f2) { f2.equals(f1); } - }\ + } """) .doTest(); } @@ -529,7 +529,7 @@ void something(J j1, J j2) { // Technically this could work, since there's nothing stopping A1 == A2, etc. boolean equals = j1.equals(j2); } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/EqualsNaNTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/EqualsNaNTest.java index bee6f7fd51a..3b5c12d54ea 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/EqualsNaNTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/EqualsNaNTest.java @@ -60,7 +60,7 @@ public class EqualsNaNPositiveCases { // BUG: Diagnostic contains: Double.isNaN(123456) static final boolean INT_IS_NAN = 123456 == Double.NaN; - }\ + } """) .doTest(); } @@ -79,7 +79,7 @@ public void negativeCase() { public class EqualsNaNNegativeCases { static final boolean NAN_AFTER_MATH = (0.0 / 0.0) == 1.0; static final boolean NORMAL_COMPARISON = 1.0 == 2.0; - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/EqualsReferenceTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/EqualsReferenceTest.java index ae35efb3e6b..8e80d1f3598 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/EqualsReferenceTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/EqualsReferenceTest.java @@ -71,7 +71,7 @@ public boolean equals(Object o) { return equals(o); } } - }\ + } """) .doTest(); } @@ -147,7 +147,7 @@ public Object getValue() { return null; } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ErroneousThreadPoolConstructorCheckerTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ErroneousThreadPoolConstructorCheckerTest.java index 52938b658cd..a3841704663 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ErroneousThreadPoolConstructorCheckerTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ErroneousThreadPoolConstructorCheckerTest.java @@ -127,7 +127,7 @@ private void createThreadPoolWithUnboundedPriorityBlockingQueue( SECONDS, new PriorityBlockingQueue<>(initialCapacity, comparingInt(Object::hashCode))); } -}\ +} """) .doTest(); } @@ -216,7 +216,7 @@ private void createThreadPoolWithBoundedSynchronousQueue() { new ThreadPoolExecutor( CORE_POOL_SIZE, MAXIMUM_POOL_SIZE, KEEP_ALIVE_TIME, SECONDS, new SynchronousQueue<>()); } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/FinallyTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/FinallyTest.java index cf3369c2ff5..5558e354934 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/FinallyTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/FinallyTest.java @@ -306,7 +306,7 @@ public void throwFromNestedCatchInFinally() throws Exception { } } } - }\ + } """) .doTest(); } @@ -396,7 +396,7 @@ public void test7() { } } } - }\ + } """) .doTest(); } @@ -466,7 +466,7 @@ public void nestedTryInFinally2() throws Exception { } } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/FloatingPointAssertionWithinEpsilonTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/FloatingPointAssertionWithinEpsilonTest.java index 3b397a77ec8..c131448714d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/FloatingPointAssertionWithinEpsilonTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/FloatingPointAssertionWithinEpsilonTest.java @@ -90,7 +90,7 @@ public void testDouble() { // BUG: Diagnostic contains: 1.1e-16 assertEquals("equal!", 1.0, 1.0, TOLERANCE2); } - }\ + } """) .doTest(); } @@ -146,7 +146,7 @@ public void testZeroCases() { assertEquals(1f, 1f, 0f); } - }\ + } """) .doTest(); } @@ -209,7 +209,7 @@ public void testDouble() { // BUG: Diagnostic contains: 1.1e-16 assertEquals("equal!", 1.0, 1.0, TOLERANCE2); } - }\ + } """) .addOutputLines( "FloatingPointAssertionWithinEpsilonPositiveCases_expected.java", @@ -248,7 +248,7 @@ public void testDouble() { assertEquals(1.0, 1.0, 0); assertEquals("equal!", 1.0, 1.0, 0); } - }\ + } """) .doTest(TestMode.AST_MATCH); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/FunctionalInterfaceMethodChangedTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/FunctionalInterfaceMethodChangedTest.java index 770ebafb7fc..7782028263b 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/FunctionalInterfaceMethodChangedTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/FunctionalInterfaceMethodChangedTest.java @@ -126,7 +126,7 @@ default String superSam() { return null; } } - }\ + } """) .doTest(); } @@ -204,7 +204,7 @@ default Void call() throws Exception { return null; } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/FutureReturnValueIgnoredTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/FutureReturnValueIgnoredTest.java index 2dbf55218dd..ea6b8169015 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/FutureReturnValueIgnoredTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/FutureReturnValueIgnoredTest.java @@ -238,7 +238,7 @@ public Object apply(Object string) { }, runnable -> runnable.run()); } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/FuturesGetCheckedIllegalExceptionTypeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/FuturesGetCheckedIllegalExceptionTypeTest.java index 53ff2ed5ed4..024dbdd777a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/FuturesGetCheckedIllegalExceptionTypeTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/FuturesGetCheckedIllegalExceptionTypeTest.java @@ -94,7 +94,7 @@ public InnerClassWithExplicitConstructorException() {} } public class InnerClassWithImplicitConstructorException extends Exception {} -}\ +} """) .doTest(); } @@ -148,7 +148,7 @@ public static class StaticNestedWithImplicitConstructorException extends Excepti public static class ProtectedConstructorException extends Exception { protected ProtectedConstructorException() {} } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/FuzzyEqualsShouldNotBeUsedInEqualsMethodTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/FuzzyEqualsShouldNotBeUsedInEqualsMethodTest.java index 352b2294723..e54d814840b 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/FuzzyEqualsShouldNotBeUsedInEqualsMethodTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/FuzzyEqualsShouldNotBeUsedInEqualsMethodTest.java @@ -58,7 +58,7 @@ public boolean equals(Object other) { return DoubleMath.fuzzyEquals(x, y, z); } } - }\ + } """) .doTest(); } @@ -94,7 +94,7 @@ public boolean equals(Object other, double a) { return DoubleMath.fuzzyEquals(0, 1, 0.2); } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/GetClassOnClassTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/GetClassOnClassTest.java index 9e7acdd0ae8..4611b251948 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/GetClassOnClassTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/GetClassOnClassTest.java @@ -59,7 +59,7 @@ public void getClassOnClass3() { // BUG: Diagnostic contains: String.class.getName() System.out.println(String.class.getClass().getName()); } - }\ + } """) .doTest(); } @@ -92,7 +92,7 @@ public static boolean getClass(Object a) { return true; } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/HidingFieldTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/HidingFieldTest.java index 6936c4ac328..4c3b41036af 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/HidingFieldTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/HidingFieldTest.java @@ -90,7 +90,7 @@ public static class ClassG extends ClassF { // BUG: Diagnostic contains: ClassF String varThree; } -}\ +} """) .addSourceLines( "HidingFieldPositiveCases2.java", @@ -120,7 +120,7 @@ public class ClassB extends HidingFieldPositiveCases1.ClassB { // BUG: Diagnostic contains: hiding ClassA.varOne public int varOne = 2; } -}\ +} """) .doTest(); } @@ -175,7 +175,7 @@ public void varThree() {} public void varTwo() {} } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ImplementAssertionWithChainingTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ImplementAssertionWithChainingTest.java index 064e07419b4..88776ddb201 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ImplementAssertionWithChainingTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ImplementAssertionWithChainingTest.java @@ -125,7 +125,7 @@ Foo otherFoo() { } private enum Kind {} -}\ +} """) .doTest(); } @@ -199,7 +199,7 @@ Foo otherFoo() { return this; } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/InconsistentCapitalizationTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/InconsistentCapitalizationTest.java index ad0a660a379..d4e321c21f0 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/InconsistentCapitalizationTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/InconsistentCapitalizationTest.java @@ -194,7 +194,7 @@ static class Child extends Parent { } } } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/IncrementInForLoopAndHeaderTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/IncrementInForLoopAndHeaderTest.java index 0ef8c3ad0d0..1c9e4008712 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/IncrementInForLoopAndHeaderTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/IncrementInForLoopAndHeaderTest.java @@ -116,7 +116,7 @@ public void expressionStatement() { // BUG: Diagnostic contains: increment for (int i = 0; i < 10; i++) i++; } - }\ + } """) .doTest(); } @@ -190,7 +190,7 @@ public void otherVarInc() { a++; } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/InsecureCipherModeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/InsecureCipherModeTest.java index 78ce815e49a..ad1aa8d8191 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/InsecureCipherModeTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/InsecureCipherModeTest.java @@ -257,7 +257,7 @@ public void keyOperations(StringProvider provider) { // We don't handle any exception as this code is not meant to be executed. } } -}\ +} """) .doTest(); } @@ -411,7 +411,7 @@ public void ellipticCurveDiffieHellman() { // We don't handle any exception as this code is not meant to be executed. } } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/InstanceOfAndCastMatchWrongTypeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/InstanceOfAndCastMatchWrongTypeTest.java index 5e2961dce64..550865dc234 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/InstanceOfAndCastMatchWrongTypeTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/InstanceOfAndCastMatchWrongTypeTest.java @@ -192,7 +192,7 @@ public static String testCall() { } } - class SuperClass {}\ + class SuperClass {} """) .doTest(); } @@ -471,7 +471,7 @@ static class SuperNegativeClass {} static class SubNegativeClass extends SuperNegativeClass {} static class DisjointClass {} -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/InvalidPatternSyntaxTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/InvalidPatternSyntaxTest.java index 85990470c26..9127529c328 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/InvalidPatternSyntaxTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/InvalidPatternSyntaxTest.java @@ -67,7 +67,7 @@ public class InvalidPatternSyntaxPositiveCases { // BUG: Diagnostic contains: "".split(INVALID, 0); } - }\ + } """) .doTest(); } @@ -105,7 +105,7 @@ public void foo(String x) { "".split(x); "".split(x, 0); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/IterableAndIteratorTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/IterableAndIteratorTest.java index 9762eae8c4c..a3c76ba6525 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/IterableAndIteratorTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/IterableAndIteratorTest.java @@ -143,7 +143,7 @@ public Iterator iterator() { return this; } } -}\ +} """) .doTest(); } @@ -215,7 +215,7 @@ public Iterator iterator() { return l; } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/JUnit3TestNotRunTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/JUnit3TestNotRunTest.java index 092f6a30434..15ed5018bd4 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/JUnit3TestNotRunTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/JUnit3TestNotRunTest.java @@ -66,7 +66,7 @@ public void tesgName() {} // tentative - can cause false positives // BUG: Diagnostic contains: JUnit3TestNotRun public void textName() {} - }\ + } """) .doTest(); } @@ -402,7 +402,7 @@ public void ignoredTest2() {} @Ignore @Test public void ignoredTest() {} - }\ + } """) .doTest(); } @@ -439,7 +439,7 @@ public void tstName() {} @Test public void TestName() {} - }\ + } """) .doTest(); } @@ -472,7 +472,7 @@ public void tesMisspelled() {} @Test public void tesBothIssuesAtOnce() {} - }\ + } """) .doTest(); } @@ -502,7 +502,7 @@ public void tesMisspelled() {} @Test public void tesBothIssuesAtOnce() {} -}\ +} """) .doTest(); } @@ -535,7 +535,7 @@ public void tesMisspelled() {} @Test public void tesBothIssuesAtOnce() {} - }\ + } """) // needed as a dependency .addSourceLines( @@ -561,7 +561,7 @@ public void tesMisspelled() {} @Test public void tesBothIssuesAtOnce() {} - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4SetUpNotRunTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4SetUpNotRunTest.java index b2333a4b7af..1876e3324ed 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4SetUpNotRunTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4SetUpNotRunTest.java @@ -133,7 +133,7 @@ public class JUnit4SetUpNotRunPositiveCaseCustomBefore { public void setUp() {} } - @interface Before {}\ + @interface Before {} """) .doTest(); } @@ -201,7 +201,7 @@ public void initMocks() {} protected void badVisibility() {} } - @interface Before {}\ + @interface Before {} """) .doTest(); } @@ -289,7 +289,7 @@ public void setUp() {} @RunWith(JUnit4.class) class J4SetUpExtendsAnnotatedMethod extends SetUpAnnotatedBaseClass { public void setUp() {} -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4TearDownNotRunTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4TearDownNotRunTest.java index 6ed60c646f1..d2e292fe8cf 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4TearDownNotRunTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4TearDownNotRunTest.java @@ -119,7 +119,7 @@ public class JUnit4TearDownNotRunPositiveCaseCustomAfter { public void tearDown() {} } - @interface After {}\ + @interface After {} """) .doTest(); } @@ -144,7 +144,7 @@ public class JUnit4TearDownNotRunPositiveCaseCustomAfter2 { public void tidyUp() {} } - @interface After {}\ + @interface After {} """) .doTest(); } @@ -229,7 +229,7 @@ public void tearDown() {} class J4TearDownInheritsFromAnnotatedMethod2 extends TearDownAnnotatedBaseClass { @After public void tearDown() {} - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4TestNotRunTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4TestNotRunTest.java index e6049c75acd..04e4204a3aa 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4TestNotRunTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/JUnit4TestNotRunTest.java @@ -56,7 +56,7 @@ public void testThisIsATest() {} // BUG: Diagnostic contains: @Test public static void testThisIsAStaticTest() {} - }\ + } """) .doTest(); } @@ -84,7 +84,7 @@ public void testThisIsATest() {} // BUG: Diagnostic contains: @Test public static void testThisIsAStaticTest() {} - }\ + } """) .doTest(); } @@ -683,7 +683,7 @@ public void negativeCase1() { */ public class JUnit4TestNotRunNegativeCase1 { public void testThisIsATest() {} - }\ + } """) .doTest(); } @@ -707,7 +707,7 @@ public void negativeCase2() { @RunWith(JUnit38ClassRunner.class) public class JUnit4TestNotRunNegativeCase2 { public void testThisIsATest() {} - }\ + } """) .doTest(); } @@ -755,7 +755,7 @@ public void testTest3(int foo) {} public int testSomething() { return 42; } -}\ +} """) .doTest(); } @@ -780,7 +780,7 @@ public void negativeCase4() { @RunWith(JUnit4.class) public class JUnit4TestNotRunNegativeCase4 extends TestCase { public void testThisIsATest() {} -}\ +} """) .doTest(); } @@ -814,7 +814,7 @@ public void testTearDown() {} @Test public void testOverrideThis() {} - }\ + } """) .addSourceLines( "JUnit4TestNotRunNegativeCase5.java", @@ -839,7 +839,7 @@ public void testTearDown() {} @Override public void testOverrideThis() {} -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/JUnitAssertSameCheckTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/JUnitAssertSameCheckTest.java index 281afe4b319..44f4f28be07 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/JUnitAssertSameCheckTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/JUnitAssertSameCheckTest.java @@ -59,7 +59,7 @@ public void test(Object obj) { // BUG: Diagnostic contains: An object is tested for reference equality to itself using JUnit junit.framework.Assert.assertSame("message", obj, obj); } -}\ +} """) .doTest(); } @@ -85,7 +85,7 @@ public void test(Object obj1, Object obj2) { junit.framework.Assert.assertSame(obj1, obj2); junit.framework.Assert.assertSame("message", obj1, obj2); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/JUnitParameterMethodNotFoundTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/JUnitParameterMethodNotFoundTest.java index 72d1ef075e5..a6847119a38 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/JUnitParameterMethodNotFoundTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/JUnitParameterMethodNotFoundTest.java @@ -160,7 +160,7 @@ public Object dataProviderInner() { return new Object[] {1}; } } -}\ +} """) .doTest(); } @@ -183,7 +183,7 @@ public class JUnitParameterMethodNotFoundNegativeCaseNonJUnitParamsRunner { @Test @Parameters(method = "named1") public void paramStaticProvider() {} - }\ + } """) .doTest(); } @@ -204,7 +204,7 @@ public abstract class JUnitParameterMethodNotFoundNegativeCaseBaseClass { public Object named1() { return new Object[] {1}; } - }\ + } """) .addSourceLines( "JUnitParameterMethodNotFoundNegativeCaseSuperClass.java", @@ -222,7 +222,7 @@ public class JUnitParameterMethodNotFoundNegativeCaseSuperClass @Test @Parameters(method = "named1") public void testNamed(int a) {} - }\ + } """) .doTest(); } @@ -263,7 +263,7 @@ public Object dataProvider() { return new Object[] {1}; } } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/LambdaFunctionalInterfaceTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/LambdaFunctionalInterfaceTest.java index 491b446401e..c49b3d215ce 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/LambdaFunctionalInterfaceTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/LambdaFunctionalInterfaceTest.java @@ -196,7 +196,7 @@ public int getSumAll() { return sumAll(o -> 2); } } -}\ +} """) .doTest(); } @@ -294,7 +294,7 @@ public Double getMu() { return findOptimalMuLambda(mu -> 0L, 3.0); } } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/LiteEnumValueOfTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/LiteEnumValueOfTest.java index 8b5d58976fa..11a2c63d75a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/LiteEnumValueOfTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/LiteEnumValueOfTest.java @@ -36,7 +36,7 @@ public final class LiteEnumValueOfTest { """ package android.os; - public interface Parcel {}\ + public interface Parcel {} """) .addSourceLines( "Parcelable.java", @@ -57,7 +57,7 @@ interface Creator { interface ClassLoaderCreator extends Creator { T createFromParcel(Parcel source, ClassLoader loader); } - }\ + } """) .addSourceLines( "FakeLiteEnum.java", diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/LockOnNonEnclosingClassLiteralTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/LockOnNonEnclosingClassLiteralTest.java index edabbfdd726..9d9540a0572 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/LockOnNonEnclosingClassLiteralTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/LockOnNonEnclosingClassLiteralTest.java @@ -60,7 +60,7 @@ public void methodContainsSynchronizedBlock() { } } } -}\ +} """) .doTest(); } @@ -94,7 +94,7 @@ public void methodContainsSynchronizedBlock() { } } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/LongLiteralLowerCaseSuffixTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/LongLiteralLowerCaseSuffixTest.java index d1523893aed..503bc47b86a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/LongLiteralLowerCaseSuffixTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/LongLiteralLowerCaseSuffixTest.java @@ -141,7 +141,7 @@ public void underscoredLowerCase() { // BUG: Diagnostic contains: value = 0_1__2L long value = 0_1__2l; } -}\ +} """) .doTest(); } @@ -200,7 +200,7 @@ public void zeroHexUpperCase() { public void negativeHexUpperCase() { long value = -0x80L; } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/MisleadingEscapedSpaceTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/MisleadingEscapedSpaceTest.java index c6d16754d50..ebf611a2911 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/MisleadingEscapedSpaceTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/MisleadingEscapedSpaceTest.java @@ -35,7 +35,7 @@ public void misleadingEscape() { class Test { // BUG: Diagnostic contains: private static final String FOO = " \\s "; - }\ + } """) .doTest(); } @@ -48,7 +48,7 @@ public void literalBackslashS() { """ class Test { private static final String FOO = " \\\\s "; - }\ + } """) .doTest(); } @@ -62,7 +62,7 @@ public void asSingleCharacter_misleading() { class Test { // BUG: Diagnostic contains: private static final char x = '\\s'; - }\ + } """) .doTest(); } @@ -131,7 +131,7 @@ public void withinCommentInBrokenUpString_noFinding() { """ class Test { private static final String FOO = "foo" + /* \\s */ " bar"; - }\ + } """) .doTest(); } @@ -161,7 +161,7 @@ public void escapedSpaceAtEndOfString() { class Test { // BUG: Diagnostic contains: private static final String FOO = "foo\\s"; - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/MissingFailTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/MissingFailTest.java index 7d53d88afae..3c7083621d0 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/MissingFailTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/MissingFailTest.java @@ -176,7 +176,7 @@ private static void dummyMethod() {} private static void assertDummy() {} private static void verifyDummy() {} - }\ + } """) .doTest(); } @@ -217,7 +217,7 @@ public void expectedException_helperMethod() { } private static void dummyMethod() {} - }\ + } """) .doTest(); } @@ -259,7 +259,7 @@ public void catchAssert() { private static void dummyMethod() {} private static void assertDummy() {} - }\ + } """) .doTest(); } @@ -731,7 +731,7 @@ String dummy() { return ""; } } -}\ +} """) .doTest(); } @@ -765,7 +765,7 @@ public void catchAssert() { private static void dummyMethod() {} private static void assertDummy() {} - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/MisusedWeekYearTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/MisusedWeekYearTest.java index 508dba5ad2e..8eaaa1afca2 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/MisusedWeekYearTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/MisusedWeekYearTest.java @@ -128,7 +128,7 @@ void testDateTimeFormatter() { // BUG: Diagnostic contains: java.time.format.DateTimeFormatter.ofPattern(WEEK_YEAR_PATTERN); } -}\ +} """) .doTest(); } @@ -176,7 +176,7 @@ void testApplyPatternAndApplyLocalizedPattern() { // BUG: Diagnostic contains: sdf.applyLocalizedPattern("YYYY-MM-dd"); } -}\ +} """) .doTest(); } @@ -230,7 +230,7 @@ void testSubtype() { mySdf.applyPattern("YYYY-MM-dd"); mySdf.applyLocalizedPattern("YYYY-MM-dd"); } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ModifyCollectionInEnhancedForLoopTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ModifyCollectionInEnhancedForLoopTest.java index ff6021fd32e..592f5079e49 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ModifyCollectionInEnhancedForLoopTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ModifyCollectionInEnhancedForLoopTest.java @@ -127,7 +127,7 @@ public static void testMapEntrySet(HashMap map) { map.remove(a.getKey()); } } - }\ + } """) .doTest(); } @@ -234,7 +234,7 @@ private static void customConcurrent(MyBlockingQueue mbq) { mbq.add(i); } } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ModifySourceCollectionInStreamTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ModifySourceCollectionInStreamTest.java index 657df6eef69..294110128bc 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ModifySourceCollectionInStreamTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ModifySourceCollectionInStreamTest.java @@ -116,7 +116,7 @@ private List mutateStreamSourceLambdaExpression( private List getMutableValues() { return mutableValues; } -}\ +} """) .doTest(); } @@ -225,7 +225,7 @@ private interface CustomContainer { boolean add(T t); } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ModifyingCollectionWithItselfTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ModifyingCollectionWithItselfTest.java index ad23e1fe045..54d7d97ff07 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ModifyingCollectionWithItselfTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ModifyingCollectionWithItselfTest.java @@ -102,7 +102,7 @@ void expressionStatementChecks() { b = a.removeAll(a); } } - }\ + } """) .doTest(); } @@ -140,7 +140,7 @@ public boolean retainAll(List b) { public boolean containsAll(List b) { return a.containsAll(b); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/MultipleParallelOrSequentialCallsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/MultipleParallelOrSequentialCallsTest.java index 13a4d50b5ed..87c47e5212f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/MultipleParallelOrSequentialCallsTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/MultipleParallelOrSequentialCallsTest.java @@ -170,7 +170,7 @@ private boolean testClass() { return true; } } -}\ +} """) .doTest(); } @@ -231,7 +231,7 @@ public SomeObject parallel() { return null; } } - }\ + } """) .doTest(); } @@ -373,7 +373,7 @@ private boolean testClass() { return true; } } -}\ +} """) .addOutputLines( "MultipleParallelOrSequentialCallsPositiveCases_expected.java", @@ -503,7 +503,7 @@ private boolean testClass() { return true; } } -}\ +} """) .doTest(TestMode.AST_MATCH); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/MultipleUnaryOperatorsInMethodCallTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/MultipleUnaryOperatorsInMethodCallTest.java index cd151e5e8e4..44eb0df4820 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/MultipleUnaryOperatorsInMethodCallTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/MultipleUnaryOperatorsInMethodCallTest.java @@ -73,7 +73,7 @@ public static void threeArgs(int a, int b, int c) {} public static int someFunction(int a) { return 0; } - }\ + } """) .doTest(); } @@ -102,7 +102,7 @@ public static void tests(int a, int b, int[] xs) { } public static void testMethod(int one, int two) {} - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/NestedInstanceOfConditionsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/NestedInstanceOfConditionsTest.java index 1c80d0bfd6b..0626442e9e0 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/NestedInstanceOfConditionsTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/NestedInstanceOfConditionsTest.java @@ -109,7 +109,7 @@ static class ClassA {} static class ClassB {} static class ClassC {} - }\ + } """) .doTest(); } @@ -208,7 +208,7 @@ public static class SubClass extends SuperClass {} /** test class */ public static class DisjointClass {} ; -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/NoAllocationCheckerTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/NoAllocationCheckerTest.java index 689409a3406..aa8cd7b8d14 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/NoAllocationCheckerTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/NoAllocationCheckerTest.java @@ -541,7 +541,7 @@ public static class NoAllocationSubclass extends NoAllocationParentClass { // BUG: Diagnostic contains: @NoAllocation public void method() {} } - }\ + } """) .doTest(); } @@ -1082,7 +1082,7 @@ public static class NoAllocationSubclassWithSuppression extends NoAllocationPare @SuppressWarnings("NoAllocation") public void method() {} } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/NonAtomicVolatileUpdateTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/NonAtomicVolatileUpdateTest.java index 491e3e9803c..20d83eb3027 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/NonAtomicVolatileUpdateTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/NonAtomicVolatileUpdateTest.java @@ -103,7 +103,7 @@ public void stringUpdate() { // BUG: Diagnostic contains: myVolatileString = myVolatileString + "update"; } - }\ + } """) .doTest(); } @@ -168,7 +168,7 @@ public void synchronizedBlock() { myVolatileString = myVolatileString + "update"; } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/NonRuntimeAnnotationTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/NonRuntimeAnnotationTest.java index edab567855f..c6058d0438a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/NonRuntimeAnnotationTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/NonRuntimeAnnotationTest.java @@ -65,7 +65,7 @@ public NonRuntime testAnnotation() { /** Annotation that is implicitly NOT retained at runtime */ public @interface NotSpecified {} -}\ +} """) .doTest(); } @@ -94,7 +94,7 @@ public Runtime testAnnotation() { /** Annotation that is retained at runtime */ @Retention(RetentionPolicy.RUNTIME) public @interface Runtime {} -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ObjectToStringTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ObjectToStringTest.java index 7d1cadfe4f8..35ee7858965 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ObjectToStringTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ObjectToStringTest.java @@ -68,7 +68,7 @@ void genericClassShowsErasure() { // BUG: Diagnostic contains: `FinalGenericClassWithoutToString@ System.out.println(finalGenericClassWithoutToString.toString()); } - }\ + } """) .doTest(); } @@ -149,7 +149,7 @@ public void overridePresentInAbstractClassInHierarchy(Duration durationArg) { unusedString = durationArg.toString(); System.out.println("test joda string " + durationArg); } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/OptionalNotPresentTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/OptionalNotPresentTest.java index 401953c3f1a..a6f5ffa85ec 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/OptionalNotPresentTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/OptionalNotPresentTest.java @@ -89,7 +89,7 @@ public String getWhenPresent_nestedCheck(Optional optional) { } return ""; } - }\ + } """) .doTest(); } @@ -197,7 +197,7 @@ public String getWhenAbsent_methodScoped(Optional optional) { } return optional.get(); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/OverrideThrowableToStringTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/OverrideThrowableToStringTest.java index ece9adab4c2..20321c963f6 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/OverrideThrowableToStringTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/OverrideThrowableToStringTest.java @@ -72,7 +72,7 @@ public String toString() { return ""; } } - }\ + } """) .doTest(); } @@ -119,7 +119,7 @@ public String getMessage() { return ""; } } - }\ + } """) .doTest(); } @@ -166,7 +166,7 @@ public String toString() { return ""; } } - }\ + } """) .addOutputLines( "OverrideThrowableToStringPositiveCases_expected.java", @@ -205,7 +205,7 @@ public String getMessage() { return ""; } } - }\ + } """) .doTest(TestMode.AST_MATCH); } @@ -223,7 +223,7 @@ class Test extends Throwable { public String toString() { return ""; } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/OverridesTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/OverridesTest.java index b711f83c2e5..5aa9ac6ce98 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/OverridesTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/OverridesTest.java @@ -166,7 +166,7 @@ abstract class SubThree extends SubTwo { // BUG: Diagnostic contains: abstract void varargsMethod(Object[] newNames); } -}\ +} """) .doTest(); } @@ -208,7 +208,7 @@ abstract class SubThree extends SubTwo { // BUG: Diagnostic contains: abstract void arrayMethod(Object... newNames); } -}\ +} """) .doTest(); } @@ -288,7 +288,7 @@ void foo(Base base) { base.varargsMethod(null, new Object[] {}, new Object[] {}, new Object[] {}, new Object[] {}); } } -}\ +} """) .doTest(); } @@ -370,7 +370,7 @@ public Builder varargsMethod(String... args) { return this; } } -}\ +} """) .doTest(); } @@ -405,7 +405,7 @@ abstract class SubThree extends SubTwo { @Override abstract void varargsMethod(Object... newNames); } - }\ + } """) .doTest(); } @@ -440,7 +440,7 @@ abstract class SubThree extends SubTwo { @Override abstract void arrayMethod(Object[] xs); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/PreconditionsInvalidPlaceholderTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/PreconditionsInvalidPlaceholderTest.java index 07076428bfc..f9ff5859720 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/PreconditionsInvalidPlaceholderTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/PreconditionsInvalidPlaceholderTest.java @@ -59,7 +59,7 @@ public void verifyFoo(int x) { // BUG: Diagnostic contains: Verify.verify(x > 0, "%d > 0", x); } - }\ + } """) .doTest(); } @@ -96,7 +96,7 @@ public static void checkNotNull(Object foo, String bar, Object baz) {} public void checkSelf() { checkNotNull(foo, "Foo", this); } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/PrimitiveArrayPassedToVarargsMethodTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/PrimitiveArrayPassedToVarargsMethodTest.java index aa15815c527..1d738229620 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/PrimitiveArrayPassedToVarargsMethodTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/PrimitiveArrayPassedToVarargsMethodTest.java @@ -66,7 +66,7 @@ public void doIt() { // BUG: Diagnostic contains: Arrays.asList(intArray); } - }\ + } """) .doTest(); } @@ -97,7 +97,7 @@ public void doIt() { intArrayVarargsMethod(intArray); objectVarargsMethodWithMultipleParams(new Object()); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/PrivateSecurityContractProtoAccessTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/PrivateSecurityContractProtoAccessTest.java index 68ef9214017..d7e7da8514f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/PrivateSecurityContractProtoAccessTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/PrivateSecurityContractProtoAccessTest.java @@ -87,7 +87,7 @@ static ByteString readSafeHtmlProtoBuilderBytes(SafeHtmlProto.Builder safeHtmlPr // BUG: Diagnostic contains: Forbidden access to a private proto field return safeHtmlProto.getPrivateDoNotAccessOrElseSafeHtmlWrappedValueBytes(); } -}\ +} """) .doTest(); } @@ -116,7 +116,7 @@ public class PrivateSecurityContractProtoAccessNegativeCases { static { safeHtml = SafeHtmls.fromProto(safeHtmlProto); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ProtocolBufferOrdinalTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ProtocolBufferOrdinalTest.java index 20561a34d54..ef8a6c1907e 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ProtocolBufferOrdinalTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ProtocolBufferOrdinalTest.java @@ -67,7 +67,7 @@ public int getNumber() { return number; } } - }\ + } """) .doTest(); } @@ -88,7 +88,7 @@ public class ProtocolBufferOrdinalNegativeCases { public static void checkProtoEnum() { TestEnum.TEST_ENUM_VAL.getNumber(); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/RestrictedApiCheckerTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/RestrictedApiCheckerTest.java index 64e49f5c2c1..f98a3f965bb 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/RestrictedApiCheckerTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/RestrictedApiCheckerTest.java @@ -38,7 +38,7 @@ public class RestrictedApiCheckerTest { import java.lang.annotation.Target; @Target({ElementType.METHOD, ElementType.CONSTRUCTOR}) - public @interface Allowlist {}\ + public @interface Allowlist {} """) .addSourceLines( "RestrictedApiMethods.java", diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/RethrowReflectiveOperationExceptionAsLinkageErrorTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/RethrowReflectiveOperationExceptionAsLinkageErrorTest.java index bf0f21f2fab..d74babc784f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/RethrowReflectiveOperationExceptionAsLinkageErrorTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/RethrowReflectiveOperationExceptionAsLinkageErrorTest.java @@ -81,7 +81,7 @@ void multiLineCatchBlock() { throw new AssertionError(e1); } } - }\ + } """) .doTest(); } @@ -144,7 +144,7 @@ void multiCatchExceptions() { void throwNewReflectiveOperationException() { throw new AssertionError(new ReflectiveOperationException("Test")); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ReturnValueIgnoredTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ReturnValueIgnoredTest.java index 2b4f1c5453a..7b9ff37fc1e 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ReturnValueIgnoredTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ReturnValueIgnoredTest.java @@ -186,7 +186,7 @@ public class ReturnValueIgnoredPositiveCases { // BUG: Diagnostic contains: Return value of 'toString' must be used Arrays.toString(objects); } - }\ + } """) .doTest(); } @@ -251,7 +251,7 @@ public void arraysNoReturnValues() { Arrays.fill(numbers, 0); Arrays.sort(numbers); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/RxReturnValueIgnoredTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/RxReturnValueIgnoredTest.java index 46459ca250b..7994981690f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/RxReturnValueIgnoredTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/RxReturnValueIgnoredTest.java @@ -237,7 +237,7 @@ static void getFromMap() { // BUG: Diagnostic contains: Rx objects must be checked. map4.get(null); } -}\ +} """) .doTest(); } @@ -343,7 +343,7 @@ void checkIgnore() { getFlowable(); getMaybe(); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/SelfAssertionTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/SelfAssertionTest.java index d0679063eda..4f3d876f547 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/SelfAssertionTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/SelfAssertionTest.java @@ -96,7 +96,7 @@ public void testAssertWithMessageNotSame() { // BUG: Diagnostic contains: assertWithMessage("msg").that(test).isNotSameInstanceAs(test); } - }\ + } """) .doTest(); } @@ -125,7 +125,7 @@ public void testEq() { public void testNeq() { assertThat(Boolean.TRUE.toString()).isNotEqualTo(Boolean.FALSE.toString()); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/SelfAssignmentTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/SelfAssignmentTest.java index 4d1a57dc328..736acc8c475 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/SelfAssignmentTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/SelfAssignmentTest.java @@ -92,7 +92,7 @@ public void testCast(int x) { // BUG: Diagnostic contains: this.a = (int) x; this.a = (int) a; } - }\ + } """) .doTest(); } @@ -204,7 +204,7 @@ private static class Foobar { Foo foo; Bar bar; } - }\ + } """) .doTest(); } @@ -307,7 +307,7 @@ public static int[] getIntArr() { return new int[10]; } } - }\ + } """) .doTest(); } @@ -327,7 +327,7 @@ class Test { // BUG: Diagnostic contains: this.foo = foo; } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/SelfComparisonTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/SelfComparisonTest.java index 5cff2449df4..60b68bbaf43 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/SelfComparisonTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/SelfComparisonTest.java @@ -115,7 +115,7 @@ public int test5() { return compareTo(this); } } - }\ + } """) .doTest(); } @@ -163,7 +163,7 @@ public int compareTo(CopmarisonTest obj) { return testField.compareTo(obj.testField); } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/SelfEqualsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/SelfEqualsTest.java index f410186f7e1..16c291ec8d8 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/SelfEqualsTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/SelfEqualsTest.java @@ -130,7 +130,7 @@ public void testSub() { // BUG: Diagnostic contains: sc.equals(sc); } - }\ + } """) .doTest(); } @@ -180,7 +180,7 @@ public void testAssertThatEq(SelfEqualsNegativeCases obj) { public void testAssertThatNeq(SelfEqualsNegativeCases obj) { assertThat(obj).isNotEqualTo(obj); } - }\ + } """) .doTest(); } @@ -256,7 +256,7 @@ private static class ForTesting { public ForTesting testing; public String string; } - }\ + } """) .doTest(); } @@ -294,7 +294,7 @@ public boolean equals(Object o) { public int hashCode() { return field != null ? field.hashCode() : 0; } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ShouldHaveEvenArgsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ShouldHaveEvenArgsTest.java index 525910413dc..77bc1e4fc53 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ShouldHaveEvenArgsTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ShouldHaveEvenArgsTest.java @@ -85,7 +85,7 @@ public void testWithOddArgsWithCorrespondence() { // BUG: Diagnostic contains: even number of arguments .containsExactly("hello", "there", "hello", "there", "rest"); } - }\ + } """) .doTest(); } @@ -141,7 +141,7 @@ public void testWithArray() { assertThat(map).containsExactly(key, value, (Object[]) args); assertThat(map).containsExactly(key, value, key, value, key, value); } - }\ + } """) .doTest(); } @@ -201,7 +201,7 @@ public void testWithOddArgsWithCorrespondence() { // BUG: Diagnostic contains: even number of arguments .containsExactly("hello", "there", "hello", "there", "rest"); } - }\ + } """) .doTest(); } @@ -254,7 +254,7 @@ public void testWithArray() { assertThat(multimap).containsExactly(key, value, (Object[]) args); assertThat(multimap).containsExactly(key, value, key, value, key, value); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/SizeGreaterThanOrEqualsZeroTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/SizeGreaterThanOrEqualsZeroTest.java index 5635e57dd52..7eeb9fd1b8d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/SizeGreaterThanOrEqualsZeroTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/SizeGreaterThanOrEqualsZeroTest.java @@ -173,7 +173,7 @@ List getIntList() { return intList; } } -}\ +} """) .doTest(); } @@ -266,7 +266,7 @@ public int size() { return length; } } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/StaticQualifiedUsingExpressionTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/StaticQualifiedUsingExpressionTest.java index 62f864ff9bb..9b538da35ba 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/StaticQualifiedUsingExpressionTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/StaticQualifiedUsingExpressionTest.java @@ -199,7 +199,7 @@ public void test7() { // x = C.foo(); int x = new C().foo(); } - }\ + } """) .doTest(); } @@ -228,7 +228,7 @@ public int test1() { // return TestClass.staticTestMethod() return new TestClass().staticTestMethod(); } - }\ + } """) .doTest(); } @@ -280,7 +280,7 @@ public void testJavacAltname() { public void testEclipseAltname() { this.staticTestMethod(); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/StringBuilderInitWithCharTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/StringBuilderInitWithCharTest.java index f4468b6c04b..37b7a273ef8 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/StringBuilderInitWithCharTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/StringBuilderInitWithCharTest.java @@ -51,7 +51,7 @@ public class StringBuilderInitWithCharPositiveCases { // BUG: Diagnostic contains: new StringBuilder().append(c) new StringBuilder(c); } - }\ + } """) .doTest(); } @@ -73,7 +73,7 @@ public class StringBuilderInitWithCharNegativeCases { new StringBuilder(5); new StringBuilder(); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/StringConcatToTextBlockTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/StringConcatToTextBlockTest.java index 187ce618ce8..1810d65354f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/StringConcatToTextBlockTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/StringConcatToTextBlockTest.java @@ -120,7 +120,7 @@ class Test { \""" hello foo - world\\ + world\ \"""; } """) @@ -148,7 +148,7 @@ class Test { hello foo - world\\ + world\ \"""; } """) @@ -176,7 +176,7 @@ class Test { String s = \""" string - literals\\ + literals\ \"""; } """) @@ -204,7 +204,7 @@ class Test { String s = \""" string - literals\\ + literals\ \"""; } """) @@ -232,7 +232,7 @@ class Test { String s = \""" string - literals\\ + literals\ \"""; } """) diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/StringSplitterTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/StringSplitterTest.java index d8eb2a30915..1183041a1d3 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/StringSplitterTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/StringSplitterTest.java @@ -501,7 +501,7 @@ public void StringSplitOneArg() { // BUG: Diagnostic contains: String[] xs = foo.split(":"); } - }\ + } """) .doTest(); } @@ -529,7 +529,7 @@ public void StringSplitTwoArgsOneNegative() { String foo = "a:b"; foo.split(":", -1); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/SuppressWarningsDeprecatedTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/SuppressWarningsDeprecatedTest.java index 1661f1cf193..d89f969b5eb 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/SuppressWarningsDeprecatedTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/SuppressWarningsDeprecatedTest.java @@ -154,7 +154,7 @@ public static void negativeCase6() { class Bar {} Bar b = null; } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/SwigMemoryLeakTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/SwigMemoryLeakTest.java index 56bdf1e42e0..d09b3a2b9fa 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/SwigMemoryLeakTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/SwigMemoryLeakTest.java @@ -61,7 +61,7 @@ public synchronized void delete() { swigCPtr = 0; } } -}\ +} """) .doTest(); } @@ -102,7 +102,7 @@ public synchronized void delete() { } private static native void nativeDelete(long cptr); - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ThreadJoinLoopTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ThreadJoinLoopTest.java index c2deeb2cc93..784077f16ba 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ThreadJoinLoopTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ThreadJoinLoopTest.java @@ -205,7 +205,7 @@ public void whileInThread() { } } } - }\ + } """) .doTest(); } @@ -335,7 +335,7 @@ public void tryAssigningThread(Thread thread) { } } } - }\ + } """) .doTest(); } @@ -514,7 +514,7 @@ public void whileInThread() { } } } - }\ + } """) .addOutputLines( "ThreadJoinLoopPositiveCases_expected.java", @@ -595,7 +595,7 @@ public void whileInThread() { Uninterruptibles.joinUninterruptibly(this); } } - }\ + } """) .doTest(TestMode.AST_MATCH); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ThrowIfUncheckedKnownCheckedTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ThrowIfUncheckedKnownCheckedTest.java index 6597a296531..4486209df84 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ThrowIfUncheckedKnownCheckedTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ThrowIfUncheckedKnownCheckedTest.java @@ -71,7 +71,7 @@ void checkedGeneric(E e) { } void foo() throws IOException, ExecutionException {} - }\ + } """) .doTest(); } @@ -147,7 +147,7 @@ void nullException() { throwIfUnchecked(null); // throws NPE propagateIfPossible(null); // no-op } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ThrowsUncheckedExceptionTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ThrowsUncheckedExceptionTest.java index e96302b6054..2887b7d9a17 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/ThrowsUncheckedExceptionTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/ThrowsUncheckedExceptionTest.java @@ -69,7 +69,7 @@ public void doEverything() throws RuntimeException, IOException, IndexOutOfBound public void doBetter() throws RuntimeException, AssertionError { throw new RuntimeException("thrown"); } -}\ +} """) .doTest(); } @@ -96,7 +96,7 @@ public void doSomething() { public void doMore() throws IOException { throw new FileNotFoundException("thrown"); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/TreeToStringTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/TreeToStringTest.java index 33b86a03b74..a372b736631 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/TreeToStringTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/TreeToStringTest.java @@ -151,7 +151,7 @@ public boolean matches(ClassTree classTree, VisitorState state) { } }; } -}\ +} """) .doTest(); } @@ -180,7 +180,7 @@ private static void foo(VisitorState state) { ASTHelpers.getSymbol(tree).getSimpleName().toString(); } } - }\ + } """) .addModules( "jdk.compiler/com.sun.tools.javac.code", "jdk.compiler/com.sun.tools.javac.util") diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/TruthAssertExpectedTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/TruthAssertExpectedTest.java index d7d8188900a..b7a7b1d6a57 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/TruthAssertExpectedTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/TruthAssertExpectedTest.java @@ -86,7 +86,7 @@ private void lists() { // assertThat(ImmutableList.of(this)).containsExactlyElementsIn(EXPECTED_LIST).inOrder(); assertThat(EXPECTED_LIST).containsExactlyElementsIn(ImmutableList.of(this)).inOrder(); } -}\ +} """) .doTest(); } @@ -147,7 +147,7 @@ private void constantValues() { assertThat(expected).isEqualTo(10L); assertThat(expected).isEqualTo(CONSTANT); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/TruthConstantAssertsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/TruthConstantAssertsTest.java index 8bb2903a353..3788f65ec19 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/TruthConstantAssertsTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/TruthConstantAssertsTest.java @@ -72,7 +72,7 @@ private static TruthConstantAssertsPositiveCases someStaticMethod() { private TruthConstantAssertsPositiveCases memberMethod() { return new TruthConstantAssertsPositiveCases(); } -}\ +} """) .doTest(); } @@ -105,7 +105,7 @@ public void testNegativeCases() { private static TruthConstantAssertsNegativeCases getObject() { return new TruthConstantAssertsNegativeCases(); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/TryFailThrowableTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/TryFailThrowableTest.java index d9770cfef64..ceec771b8a7 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/TryFailThrowableTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/TryFailThrowableTest.java @@ -216,7 +216,7 @@ public static void catchesError_nestedNoBlock() { } catch (Error e) { } } -}\ +} """) .doTest(); } @@ -396,7 +396,7 @@ public void testInTestCase() { private static void dummyRecover() {} private static void dummyMethod() {} - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/URLEqualsHashCodeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/URLEqualsHashCodeTest.java index e9569828ef7..c16ae619db5 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/URLEqualsHashCodeTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/URLEqualsHashCodeTest.java @@ -132,7 +132,7 @@ public void immutableSetOfURL() { // BUG: Diagnostic contains: java.net.URL ImmutableSet urlSet2 = ImmutableSet.builder().build(); } - }\ + } """) .doTest(); } @@ -199,7 +199,7 @@ private static class ExtendedMap extends HashMap { public void hashMapExtendedClass() { ExtendedMap urlMap; } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UngroupedOverloadsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UngroupedOverloadsTest.java index 620527ae048..ba307a0ff32 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/UngroupedOverloadsTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/UngroupedOverloadsTest.java @@ -78,7 +78,7 @@ public void foo(int x, int y) { } public void norf() {} - }\ + } """) .doTest(); } @@ -165,7 +165,7 @@ public void foo() { public void norf(int x, int y, int w) { norf(x + w, y + w); } - }\ + } """) .doTest(); } @@ -221,7 +221,7 @@ public void foo(int x) {} public void foo() { foo(foo); } - }\ + } """) .doTest(); } @@ -276,7 +276,7 @@ public void quux(int x) { public void foo() { foo(42); } - }\ + } """) .doTest(); } @@ -326,7 +326,7 @@ public void quux(int x) { public void foo() { foo(42); } -}\ +} """) .setArgs(ImmutableList.of("-XepOpt:UngroupedOverloads:BatchFindings")) .doTest(); @@ -378,7 +378,7 @@ public void baz(String x, String y) { public int foo() { return this.foo; } - }\ + } """) .doTest(); } @@ -418,7 +418,7 @@ public void bar(int x, int y, int z) { public void quux() {} public void bar(String s) {} - }\ + } """) .addOutputLines( "UngroupedOverloadsRefactoringComments_expected.java", @@ -452,7 +452,7 @@ public void bar(String s) {} public static final String BAZ = "baz"; // Stuff about `baz` continues. public void quux() {} - }\ + } """) .doTest(); } @@ -500,7 +500,7 @@ public void norf() {} public void quux(int x, int y, int z) {} public void thud() {} - }\ + } """) .addOutputLines( "UngroupedOverloadsRefactoringMultiple_expected.java", @@ -542,7 +542,7 @@ public void quux(int x, int y, int z) {} public void norf() {} public void thud() {} - }\ + } """) .doTest(); } @@ -585,7 +585,7 @@ public void quux(int x, int y) {} public void foo(int x, int y, int z) {} public void bar(int x, int y) {} - }\ + } """) .addOutputLines( "UngroupedOverloadsRefactoringInterleaved_expected.java", @@ -622,7 +622,7 @@ public void quux() {} public void quux(int x) {} public void quux(int x, int y) {} - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryBoxedAssignmentTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryBoxedAssignmentTest.java index 836ddfa058a..ed644e82fe0 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryBoxedAssignmentTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryBoxedAssignmentTest.java @@ -103,7 +103,7 @@ Integer positive_wrappedAgain(int aInteger) { void negative_methodReference() { Function toBoolean = Boolean::valueOf; } - }\ + } """) .addOutputLines( "UnnecessaryBoxedAssignmentCases_expected.java", @@ -176,7 +176,7 @@ Integer positive_wrappedAgain(int aInteger) { void negative_methodReference() { Function toBoolean = Boolean::valueOf; } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryLongToIntConversionTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryLongToIntConversionTest.java index fbd52cb7fcc..299f04899f6 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryLongToIntConversionTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryLongToIntConversionTest.java @@ -109,7 +109,7 @@ public void intValue() { // BUG: Diagnostic contains: UnnecessaryLongToIntConversion acceptsLong(x.intValue()); } -}\ +} """) .doTest(); } @@ -225,7 +225,7 @@ public void toIntExactForIntParameter() { long x = 1; acceptsInt(Math.toIntExact(x)); } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UnsafeReflectiveConstructionCastTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UnsafeReflectiveConstructionCastTest.java index 45eebd05b87..d2018eb6a2d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/UnsafeReflectiveConstructionCastTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/UnsafeReflectiveConstructionCastTest.java @@ -180,7 +180,7 @@ public T get(String className) { } } } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UnusedVariableTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UnusedVariableTest.java index 6d99a15b531..c11d473dd2c 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/UnusedVariableTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/UnusedVariableTest.java @@ -1727,7 +1727,7 @@ public void simpleRecord() { "SimpleRecord.java", // """ // public record SimpleRecord(Integer foo, Long bar) {} - //\ + // """) .expectNoDiagnostics() .doTest(); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/WaitNotInLoopTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/WaitNotInLoopTest.java index 5bb0111ce30..e4fd5478b75 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/WaitNotInLoopTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/WaitNotInLoopTest.java @@ -110,7 +110,7 @@ public void testAwaitUntil(Condition cond) throws Exception { // BUG: Diagnostic contains: awaitUntil(java.util.Date) must always be called in a loop cond.awaitUntil(new Date()); } -}\ +} """) .doTest(); } @@ -215,7 +215,7 @@ private void wait(Object obj) {} public void testNotObjectWait() { wait(new Object()); } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/BinderIdentityRestoredDangerouslyTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/BinderIdentityRestoredDangerouslyTest.java index 8116775f42d..64a1088dcce 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/BinderIdentityRestoredDangerouslyTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/BinderIdentityRestoredDangerouslyTest.java @@ -41,7 +41,7 @@ public static final long clearCallingIdentity() { } public static final void restoreCallingIdentity(long token) {} - }\ + } """) .setArgs(ImmutableList.of("-XDandroidCompatible=true")); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/FragmentInjectionTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/FragmentInjectionTest.java index 0ce68ef4a83..5bfd550f0d5 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/FragmentInjectionTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/FragmentInjectionTest.java @@ -40,7 +40,7 @@ public class PreferenceActivity { protected boolean isValidFragment(String className) { return true; } - }\ + } """) .setArgs(ImmutableList.of("-XDandroidCompatible=true")); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/FragmentNotInstantiableTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/FragmentNotInstantiableTest.java index a53d878403b..d2e26c97689 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/FragmentNotInstantiableTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/FragmentNotInstantiableTest.java @@ -117,7 +117,7 @@ class LocalFragment extends Fragment {} return new LocalFragment(); } } - }\ + } """) .doTest(); } @@ -203,7 +203,7 @@ public class ImplicitlyStaticInnerFragment extends Fragment {} class ImplicitlyStaticAndPublicInnerFragment extends Fragment {} } - }\ + } """) .doTest(); } @@ -282,7 +282,7 @@ class LocalFragment extends Fragment {} return new LocalFragment(); } } - }\ + } """) .addSourceLines( "CustomFragment.java", @@ -292,7 +292,7 @@ class LocalFragment extends Fragment {} /** * @author jasonlong@google.com (Jason Long) */ - public class CustomFragment {}\ + public class CustomFragment {} """) .addSourceLines( "CustomFragmentNotInstantiablePositiveCases.java", @@ -358,7 +358,7 @@ class LocalFragment extends CustomFragment {} return new LocalFragment(); } } - }\ + } """) .doTest(); } @@ -444,7 +444,7 @@ public class ImplicitlyStaticInnerFragment extends Fragment {} class ImplicitlyStaticAndPublicInnerFragment extends Fragment {} } - }\ + } """) .addSourceLines( "CustomFragment.java", @@ -454,7 +454,7 @@ class ImplicitlyStaticAndPublicInnerFragment extends Fragment {} /** * @author jasonlong@google.com (Jason Long) */ - public class CustomFragment {}\ + public class CustomFragment {} """) .addSourceLines( "CustomFragmentNotInstantiableNegativeCases.java", @@ -514,7 +514,7 @@ public class ImplicitlyStaticInnerFragment extends CustomFragment {} class ImplicitlyStaticAndPublicInnerFragment extends CustomFragment {} } - }\ + } """) .doTest(); } @@ -527,14 +527,14 @@ private CompilationTestHelper createCompilationTestHelper( """ package android.app; - public class Fragment {}\ + public class Fragment {} """) .addSourceLines( "Fragment.java", """ package android.support.v4.app; - public class Fragment {}\ + public class Fragment {} """) .setArgs(ImmutableList.of("-XDandroidCompatible=true")); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/HardCodedSdCardPathTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/HardCodedSdCardPathTest.java index 46f2f391e83..4260a4ee26a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/HardCodedSdCardPathTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/HardCodedSdCardPathTest.java @@ -79,7 +79,7 @@ public class HardCodedSdCardPathPositiveCases { // BUG: Diagnostic contains: Context static final String PATH11 = "/data" + "/" + "user"; - }\ + } """) .doTest(); } @@ -128,7 +128,7 @@ public class HardCodedSdCardPathNegativeCases { static final String FRAGMENT4 = "1user"; static final String PATH5 = FRAGMENT3 + "/" + FRAGMENT4; - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/IsLoggableTagLengthTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/IsLoggableTagLengthTest.java index d01b2689a27..ec92411c17a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/IsLoggableTagLengthTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/IsLoggableTagLengthTest.java @@ -41,7 +41,7 @@ public static boolean isLoggable(String tag, int level) { } public static final int INFO = 0; - }\ + } """) .setArgs(ImmutableList.of("-XDandroidCompatible=true")); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/MislabeledAndroidStringTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/MislabeledAndroidStringTest.java index 25ae3c9f630..b17f7926930 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/MislabeledAndroidStringTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/MislabeledAndroidStringTest.java @@ -133,7 +133,7 @@ public static final class string { public static final int no = 1; public static final int copy = 2; } - }\ + } """) .setArgs(ImmutableList.of("-XDandroidCompatible=true")); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/RectIntersectReturnValueIgnoredTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/RectIntersectReturnValueIgnoredTest.java index e4acb2def3d..0b4e228d952 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/RectIntersectReturnValueIgnoredTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/RectIntersectReturnValueIgnoredTest.java @@ -44,7 +44,7 @@ public boolean intersect(Rect other) { } public void setEmpty() {} - }\ + } """) .setArgs(ImmutableList.of("-XDandroidCompatible=true")); @@ -94,7 +94,7 @@ void checkInField(RectContainer container) { container.rect.intersect( container.xPos, container.yPos, container.xPos + 10, container.yPos + 20); } -}\ +} """) .doTest(); } @@ -158,7 +158,7 @@ void checkInMethod(int length, int width) { RectContainer container = new RectContainer(); container.intersect(length, width); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/android/WakelockReleasedDangerouslyTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/android/WakelockReleasedDangerouslyTest.java index 56e7f68a331..2a15af0d8d8 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/android/WakelockReleasedDangerouslyTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/android/WakelockReleasedDangerouslyTest.java @@ -51,7 +51,7 @@ public void release() {} public void setReferenceCounted(boolean referenceCounted) {} } - }\ + } """) .expectUnchanged(); private final CompilationTestHelper compilationHelper = @@ -75,7 +75,7 @@ public void release() {} public void setReferenceCounted(boolean referenceCounted) {} } - }\ + } """) .setArgs(ImmutableList.of("-XDandroidCompatible=true")); diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/collectionincompatibletype/CollectionIncompatibleTypeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/collectionincompatibletype/CollectionIncompatibleTypeTest.java index 980c484addb..fc6fc2cfa13 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/collectionincompatibletype/CollectionIncompatibleTypeTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/collectionincompatibletype/CollectionIncompatibleTypeTest.java @@ -292,7 +292,7 @@ public boolean oneFinalClassAndOneNonFinalClass( // BUG: Diagnostic contains: return collection.contains(nonFinalClass1); } -}\ +} """) .doTest(); } @@ -568,7 +568,7 @@ public void classToken( Set>> iterables, Class arrayListClass) { iterables.contains(arrayListClass); } -}\ +} """) .doTest(); } @@ -589,7 +589,7 @@ public void test() { Properties properties = new Properties(); properties.get(""); } - }\ + } """) .doTest(); } @@ -609,7 +609,7 @@ public class CollectionIncompatibleTypeClassCast extends HashMap { public void test(K k) { get(k); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/collectionincompatibletype/IncompatibleArgumentTypeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/collectionincompatibletype/IncompatibleArgumentTypeTest.java index 9b20650862c..ffa31fda086 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/collectionincompatibletype/IncompatibleArgumentTypeTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/collectionincompatibletype/IncompatibleArgumentTypeTest.java @@ -83,7 +83,7 @@ void testVarargs(A stringA) { // OK, everything compatible w/ Object Object o = stringA.varargs("foo", 2L, 1.0d, "a"); } -}\ +} """) .doTest(); } @@ -158,7 +158,7 @@ void extraStuff() { // enforce it here. new Foo().new Sub().new SubSub().>methodVarIsFree(123); } -}\ +} """) .doTest(); } @@ -238,7 +238,7 @@ void testVarArgs(Multimap intToString) { Integer[] keys = {123, 345}; intToString.containsAllKeys(123, (Object[]) keys); } -}\ +} """) .doTest(); } @@ -298,7 +298,7 @@ void testArraySpecialization( // BUG: Diagnostic contains: String[] is not compatible with the required type: Number[] arrayTest.doSomething(strings); } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/flogger/FloggerRedundantIsEnabledTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/flogger/FloggerRedundantIsEnabledTest.java index 5f7968646ce..e0b88d4d4cc 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/flogger/FloggerRedundantIsEnabledTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/flogger/FloggerRedundantIsEnabledTest.java @@ -137,7 +137,7 @@ public void checkSevere(FluentLogger logger) { logger.atSevere().log("test"); } } - }\ + } """) .doTest(); } @@ -233,7 +233,7 @@ public boolean isEnabled() { return true; } } -}\ +} """) .doTest(); } @@ -343,7 +343,7 @@ public void checkSevere(FluentLogger logger) { logger.atSevere().log("test"); } } - }\ + } """) .addOutputLines( "FloggerRedundantIsEnabledPositiveCases_expected.java", @@ -418,7 +418,7 @@ public void checkWarning(FluentLogger logger) { public void checkSevere(FluentLogger logger) { logger.atSevere().log("test"); } - }\ + } """) .doTest(TestMode.AST_MATCH); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/AssistedInjectAndInjectOnConstructorsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/AssistedInjectAndInjectOnConstructorsTest.java index 28aa8c8b24e..3712a282735 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/AssistedInjectAndInjectOnConstructorsTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/AssistedInjectAndInjectOnConstructorsTest.java @@ -84,7 +84,7 @@ public TestClass3(int n) {} public TestClass3(String s) {} } -}\ +} """) .doTest(); } @@ -146,7 +146,7 @@ public TestClass6() {} @AssistedInject public TestClass6(int n) {} } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/AssistedInjectAndInjectOnSameConstructorTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/AssistedInjectAndInjectOnSameConstructorTest.java index be06b3aa825..02b9bc5005f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/AssistedInjectAndInjectOnSameConstructorTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/AssistedInjectAndInjectOnSameConstructorTest.java @@ -61,7 +61,7 @@ public class TestClass2 { @AssistedInject public TestClass2() {} } -}\ +} """) .doTest(); } @@ -142,7 +142,7 @@ public class TestClass8 { @AssistedInject public TestClass8() {} } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/AutoFactoryAtInjectTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/AutoFactoryAtInjectTest.java index 2dbb1abf9f6..d32d0cf156d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/AutoFactoryAtInjectTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/AutoFactoryAtInjectTest.java @@ -63,7 +63,7 @@ static class HasAutoFactoryOnConstructor { @AutoFactory HasAutoFactoryOnConstructor() {} } - }\ + } """) .doTest(); } @@ -104,7 +104,7 @@ static class OnDifferentConstructors { @AutoFactory OnDifferentConstructors(Object object) {} } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/CloseableProvidesTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/CloseableProvidesTest.java index 49a64f0663f..7a18fdcbeca 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/CloseableProvidesTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/CloseableProvidesTest.java @@ -67,7 +67,7 @@ ImplementsClosable providesImplementsClosable() { PrintWriter providesPrintWriter() throws Exception { return new PrintWriter("some_file_path", StandardCharsets.UTF_8.name()); } - }\ + } """) .doTest(); } @@ -104,7 +104,7 @@ DoesNotImplementsClosable providesDoesNotImplementsClosable() { Object providesObject() { return new Object(); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/InjectOnMemberAndConstructorTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/InjectOnMemberAndConstructorTest.java index 195b2a1f76f..4349981ac9b 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/InjectOnMemberAndConstructorTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/InjectOnMemberAndConstructorTest.java @@ -113,7 +113,7 @@ public class MixedInject { @Inject public MixedInject() {} } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/InjectedConstructorAnnotationsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/InjectedConstructorAnnotationsTest.java index 51b5a85e3f4..b6ebbacc80d 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/InjectedConstructorAnnotationsTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/InjectedConstructorAnnotationsTest.java @@ -115,7 +115,7 @@ public class TestClass4 { @TestAnnotation public TestClass4() {} } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/InvalidTargetingOnScopingAnnotationTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/InvalidTargetingOnScopingAnnotationTest.java index cc437cb7d46..475ee7ff158 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/InvalidTargetingOnScopingAnnotationTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/InvalidTargetingOnScopingAnnotationTest.java @@ -96,7 +96,7 @@ public class InvalidTargetingOnScopingAnnotationPositiveCases { @ScopeAnnotation @Retention(RUNTIME) public @interface TestAnnotation7 {} - }\ + } """) .doTest(); } @@ -146,7 +146,7 @@ public class InvalidTargetingOnScopingAnnotationNegativeCases { @Target(PARAMETER) @Retention(RUNTIME) public @interface TestAnnotation4 {} -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/JavaxInjectOnAbstractMethodTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/JavaxInjectOnAbstractMethodTest.java index eea757cbe4a..fa6b170f9bc 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/JavaxInjectOnAbstractMethodTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/JavaxInjectOnAbstractMethodTest.java @@ -99,7 +99,7 @@ interface HasDefault { @javax.inject.Inject default void foo() {} } -}\ +} """) .doTest(); } @@ -156,7 +156,7 @@ public abstract class TestClass6 { @javax.inject.Inject abstract void abstractMethod(); } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/JavaxInjectOnFinalFieldTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/JavaxInjectOnFinalFieldTest.java index bfdcff68060..1f1534aca32 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/JavaxInjectOnFinalFieldTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/JavaxInjectOnFinalFieldTest.java @@ -87,7 +87,7 @@ public class TestClass4 { @Inject final void method() {} } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/MissingRuntimeRetentionTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/MissingRuntimeRetentionTest.java index 1bbe9927fd5..25a5a0b4b1f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/MissingRuntimeRetentionTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/MissingRuntimeRetentionTest.java @@ -103,7 +103,7 @@ public class MissingRuntimeRetentionPositiveCases { @Target({TYPE, METHOD}) // BUG: Diagnostic contains: @Retention(RUNTIME) public @interface TestAnnotation7 {} - }\ + } """) .doTest(); } @@ -169,7 +169,7 @@ public class MissingRuntimeRetentionNegativeCases { @com.google.inject.multibindings.MapKey @Retention(RUNTIME) public @interface TestAnnotation7 {} - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/MoreThanOneInjectableConstructorTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/MoreThanOneInjectableConstructorTest.java index f55969ddafa..0fa502a282b 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/MoreThanOneInjectableConstructorTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/MoreThanOneInjectableConstructorTest.java @@ -94,7 +94,7 @@ public TestClass4(int m, int n) {} @Inject public TestClass4(int m, int n, boolean x) {} } -}\ +} """) .doTest(); } @@ -173,7 +173,7 @@ public TestClass7() {} @Inject public TestClass7(int n) {} } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/MoreThanOneQualifierTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/MoreThanOneQualifierTest.java index c2f8a876e6d..22c8418b09a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/MoreThanOneQualifierTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/MoreThanOneQualifierTest.java @@ -165,7 +165,7 @@ public void setN( @BindingAnnotation @Retention(RUNTIME) public @interface Bar2 {} -}\ +} """) .doTest(); } @@ -234,7 +234,7 @@ public void setN(@Bar int n) {} @BindingAnnotation @Retention(RUNTIME) public @interface Bar {} -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/MoreThanOneScopeAnnotationOnClassTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/MoreThanOneScopeAnnotationOnClassTest.java index e114a07f574..771d54b3e46 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/MoreThanOneScopeAnnotationOnClassTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/MoreThanOneScopeAnnotationOnClassTest.java @@ -67,7 +67,7 @@ class TestClass2 {} @SessionScoped // BUG: Diagnostic contains: class TestClass3 {} - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/OverlappingQualifierAndScopeAnnotationTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/OverlappingQualifierAndScopeAnnotationTest.java index e028c6d0ca5..d0111623ec9 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/OverlappingQualifierAndScopeAnnotationTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/OverlappingQualifierAndScopeAnnotationTest.java @@ -62,7 +62,7 @@ public class OverlappingQualifierAndScopeAnnotationPositiveCases { @com.google.inject.BindingAnnotation // BUG: Diagnostic contains: OverlappingQualifierAndScopeAnnotation @interface JavaxScopeAndGuiceBindingAnnotation {} - }\ + } """) .doTest(); } @@ -112,7 +112,7 @@ public class OverlappingQualifierAndScopeAnnotationNegativeCases { @javax.inject.Scope @com.google.inject.BindingAnnotation @interface JavaxScopeAndGuiceBindingAnnotation {} - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/QualifierWithTypeUseTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/QualifierWithTypeUseTest.java index 7b90ba4a1e9..a91c564f9a0 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/QualifierWithTypeUseTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/QualifierWithTypeUseTest.java @@ -70,7 +70,7 @@ public class QualifierWithTypeUsePositiveCases { // BUG: Diagnostic contains: remove @Target(ElementType.TYPE_USE) @interface BindingAnnotation3 {} - }\ + } """) .doTest(); } @@ -96,7 +96,7 @@ public class QualifierWithTypeUseNegativeCases { @Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER}) @interface NotAQualifier {} - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/ScopeAnnotationOnInterfaceOrAbstractClassTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/ScopeAnnotationOnInterfaceOrAbstractClassTest.java index 18714a16da7..9b30e7e6cd5 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/ScopeAnnotationOnInterfaceOrAbstractClassTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/ScopeAnnotationOnInterfaceOrAbstractClassTest.java @@ -58,7 +58,7 @@ public abstract class TestClass1 {} // BUG: Diagnostic contains: remove @Singleton public interface TestClass2 {} -}\ +} """) .doTest(); } @@ -110,7 +110,7 @@ interface DaggerInterfaceComponent { @CustomScope abstract class DaggerAbstractClassSubcomponent {} } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/dagger/AndroidInjectionBeforeSuperTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/dagger/AndroidInjectionBeforeSuperTest.java index ebbbc1b5e91..32330135d1e 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/dagger/AndroidInjectionBeforeSuperTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/dagger/AndroidInjectionBeforeSuperTest.java @@ -34,7 +34,7 @@ public final class AndroidInjectionBeforeSuperTest { public class Activity { public void onCreate(android.os.Bundle bundle) {} - }\ + } """) .addSourceLines( "Fragment.java", @@ -45,7 +45,7 @@ public class Fragment { public void onAttach(android.app.Activity activity) {} public void onAttach(android.content.Context context) {} - }\ + } """) .addSourceLines( "Service.java", @@ -58,35 +58,35 @@ public void onCreate() {} public android.os.IBinder onBind(android.content.Intent intent) { return null; } - }\ + } """) .addSourceLines( "Context.java", """ package android.content; - public class Context {}\ + public class Context {} """) .addSourceLines( "Intent.java", """ package android.content; - public class Intent {}\ + public class Intent {} """) .addSourceLines( "Bundle.java", """ package android.os; - public class Bundle {}\ + public class Bundle {} """) .addSourceLines( "IBinder.java", """ package android.os; - public interface IBinder {}\ + public interface IBinder {} """); @Test @@ -168,7 +168,7 @@ public IBinder onBind(Intent intent) { return null; } } - }\ + } """) .addSourceLines( "AndroidInjection.java", @@ -189,7 +189,7 @@ public static void inject(Activity activity) {} public static void inject(Fragment fragment) {} public static void inject(Service service) {} -}\ +} """) .doTest(); } @@ -278,7 +278,7 @@ public IBinder onBind(Intent intent) { return null; } } - }\ + } """) .addSourceLines( "AndroidInjection.java", @@ -299,7 +299,7 @@ public static void inject(Activity activity) {} public static void inject(Fragment fragment) {} public static void inject(Service service) {} -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/AssistedInjectScopingTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/AssistedInjectScopingTest.java index 551fc770e1d..891f928a1e6 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/AssistedInjectScopingTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/AssistedInjectScopingTest.java @@ -101,7 +101,7 @@ public class TestClass6 { @javax.inject.Inject public TestClass6(String unassisted, @Assisted String assisted) {} } - }\ + } """) .doTest(); } @@ -203,7 +203,7 @@ public TestClass10(@Assisted String assisted, int i) {} public TestClass10(int i, @Assisted String assisted) {} } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/AssistedParametersTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/AssistedParametersTest.java index 340103ae682..05f0bd31660 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/AssistedParametersTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/AssistedParametersTest.java @@ -93,7 +93,7 @@ class GenericClass { // BUG: Diagnostic contains: int: a, b GenericClass(@Assisted Integer a, @Assisted int b) {} } -}\ +} """) .doTest(); } @@ -157,7 +157,7 @@ public class TestClass5 { public TestClass5( @Assisted("foo") List x, @Assisted("foo") List y, String z) {} } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/BindingToUnqualifiedCommonTypeTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/BindingToUnqualifiedCommonTypeTest.java index e8a2f686610..1c0bd6d1076 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/BindingToUnqualifiedCommonTypeTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/BindingToUnqualifiedCommonTypeTest.java @@ -78,7 +78,7 @@ String providesGreeting() { return "hi"; } } - }\ + } """) .doTest(); } @@ -171,7 +171,7 @@ class A {} @BindingAnnotation @Retention(RetentionPolicy.RUNTIME) @interface MyBindingAnnotation {} -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/InjectOnFinalFieldTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/InjectOnFinalFieldTest.java index f4a66866850..b9b0de86b0a 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/InjectOnFinalFieldTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/InjectOnFinalFieldTest.java @@ -57,7 +57,7 @@ public class TestClass1 { // BUG: Diagnostic contains: Object c final Object c = null; } - }\ + } """) .doTest(); } @@ -95,7 +95,7 @@ public class TestClass4 { @Inject final void method() {} } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/OverridesGuiceInjectableMethodTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/OverridesGuiceInjectableMethodTest.java index b87116cc98b..698e08d7b3c 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/OverridesGuiceInjectableMethodTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/OverridesGuiceInjectableMethodTest.java @@ -97,7 +97,7 @@ public class TestClass7 extends TestClass1 { // BUG: Diagnostic contains: @Inject public void foo() {} } -}\ +} """) .doTest(); } @@ -166,7 +166,7 @@ public void foo() {} /** Class that extends a class with an injected method, but doesn't override it. */ public class TestClass7 extends TestClass1 {} -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/OverridesJavaxInjectableMethodTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/OverridesJavaxInjectableMethodTest.java index 96751036400..2140ad7746f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/OverridesJavaxInjectableMethodTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/OverridesJavaxInjectableMethodTest.java @@ -73,7 +73,7 @@ public class TestClass3 extends TestClass2 { // BUG: Diagnostic contains: @Inject public void foo() {} } -}\ +} """) .doTest(); } @@ -141,7 +141,7 @@ public class TestClass9 extends TestClass3 { @SuppressWarnings("OverridesJavaxInjectableMethod") public void foo() {} } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/ProvidesMethodOutsideOfModuleTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/ProvidesMethodOutsideOfModuleTest.java index d19e6530f53..def8c20772e 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/ProvidesMethodOutsideOfModuleTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/inject/guice/ProvidesMethodOutsideOfModuleTest.java @@ -81,7 +81,7 @@ int thisIsNotOk() { return 42; } } - }\ + } """) .doTest(); } @@ -123,7 +123,7 @@ int providesFoo() { return 42; } } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/nullness/EqualsBrokenForNullTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/nullness/EqualsBrokenForNullTest.java index 44ee4dcf4c1..7bc28037836 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/nullness/EqualsBrokenForNullTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/nullness/EqualsBrokenForNullTest.java @@ -216,7 +216,7 @@ public boolean equals(Object o) { return that.a == a; } } - }\ + } """) .doTest(); } @@ -353,7 +353,7 @@ public boolean equals(Object o) { return that.a == a; } } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/nullness/NullablePrimitiveTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/nullness/NullablePrimitiveTest.java index 6d5b90722fc..f3aac3f6ccd 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/nullness/NullablePrimitiveTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/nullness/NullablePrimitiveTest.java @@ -82,7 +82,7 @@ public void method(@Nullable Integer a) {} public Integer method() { return Integer.valueOf(0); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/nullness/UnnecessaryCheckNotNullTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/nullness/UnnecessaryCheckNotNullTest.java index 5f6c86faf88..1afad3cf771 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/nullness/UnnecessaryCheckNotNullTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/nullness/UnnecessaryCheckNotNullTest.java @@ -239,7 +239,7 @@ public void error_fully_qualified_import_requireNonNull() { // BUG: Diagnostic contains: remove this line java.util.Objects.requireNonNull("string literal"); } - }\ + } """) .doTest(); } @@ -289,7 +289,7 @@ public void go() { com.google.common.base.Verify.verifyNotNull(testObj, "this is ok"); java.util.Objects.requireNonNull(testObj, "this is ok"); } - }\ + } """) .doTest(); } @@ -431,7 +431,7 @@ public Tester getTester() { return tester; } } - }\ + } """) .doTest(); } @@ -458,7 +458,7 @@ public void test() { Preconditions.checkNotNull(obj1, "%s should not be null", "obj1"); Preconditions.checkNotNull(obj1.toString()); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/nullness/UnsafeWildcardTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/nullness/UnsafeWildcardTest.java index 7683afdc538..d8666df7965 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/nullness/UnsafeWildcardTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/nullness/UnsafeWildcardTest.java @@ -76,7 +76,7 @@ public static void main(String... args) { // BUG: Diagnostic contains: impossible new Impl<>(Stream.of(null, null)).apply("boom"); } - }\ + } """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/overloading/InconsistentOverloadsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/overloading/InconsistentOverloadsTest.java index c0e856836fb..57de1786e7f 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/overloading/InconsistentOverloadsTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/overloading/InconsistentOverloadsTest.java @@ -66,7 +66,7 @@ public void quux(int x, int y, String string) {} public void norf(int x, int y) {} public void norf(Object object, String string) {} - }\ + } """) .doTest(); } @@ -111,7 +111,7 @@ int quux(@Bar @Baz Object object) { // BUG: Diagnostic contains: norf(String string, Object object) abstract int norf(Object object, @Baz @Bar String string); - }\ + } """) .doTest(); } @@ -153,7 +153,7 @@ public void quux(int x, int y, String string) {} // BUG: Diagnostic contains: quux(int x, int y, Object object) public void quux(Object object, int y, int x) {} - }\ + } """) .doTest(); } @@ -182,7 +182,7 @@ public void bar(int x) {} // BUG: Diagnostic contains: bar(int x, List> strings) public void bar(List> strings, int x) {} -}\ +} """) .doTest(); } @@ -217,7 +217,7 @@ public void foo(int z, int x, int y) {} public void bar(int x, int y, String string, Object object) {} public void baz(int x) {} - }\ + } """) .doTest(); } @@ -239,7 +239,7 @@ public void foo(int x, int y, Object object) {} // BUG: Diagnostic contains: foo(Object object, int x, int y, String string) public void foo(String string, int y, Object object, int x) {} - }\ + } """) .doTest(); } @@ -270,7 +270,7 @@ public void foo(int y, int x, String... rest) {} abstract void bar(float y, String string, float x, float z); abstract void bar(Object... rest); - }\ + } """) .doTest(); } @@ -308,7 +308,7 @@ void someMethod(int bar, String foo, List baz) {} // String> fizz) void someMethod(int bar, String foo, List baz, Map fizz) {} } -}\ +} """) .doTest(); } diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/time/TimeUnitMismatchTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/time/TimeUnitMismatchTest.java index 600a30eb57d..a596ce6be21 100644 --- a/core/src/test/java/com/google/errorprone/bugpatterns/time/TimeUnitMismatchTest.java +++ b/core/src/test/java/com/google/errorprone/bugpatterns/time/TimeUnitMismatchTest.java @@ -133,7 +133,7 @@ void optionalGet() { // BUG: Diagnostic contains: expected milliseconds but was nanoseconds long millis = maybeNanos.get(); } - }\ + } """) .doTest(); } @@ -219,7 +219,7 @@ void optionalGet() { Optional maybeNanos = Optional.of(0L); long nanos = maybeNanos.get(); } - }\ + } """) .doTest(); }