Skip to content

Update error descriptions for when result sharding is unlikely to be as expected. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Apr 16, 2025
Merged

Update error descriptions for when result sharding is unlikely to be as expected. #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions drjax/_src/impls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,12 @@ def broadcast_to_placement(
def single_arg_broadcast(x):
replicated_tensor = jnp.tile(x, reps=[n_elements] + [1] * len(x.shape))
if mesh is None:
# No sharding expected, don't worry about it.
logging.warning(
'No mesh found; defaulting to fully replicated broadcast and'
' *NOT* adding sharding constraints over the requested placement'
' axis %s.',
placement,
)
return replicated_tensor
else:

Expand Down Expand Up @@ -275,7 +280,7 @@ def _shard_slice(s):
'No mesh containing axis name %s found; defaulting to standard vmap.'
' Mesh contains names: %s',
placement,
mesh.axis_names if mesh is not None else '',
mesh.axis_names if mesh is not None else 'None',
)
# Users should be free to use whatever mesh their model needs without
# _necessarily_ registering a mesh-dimension for every placement with
Expand Down
Loading