From d1060616f6de6900910848712e63d4b7439a04db Mon Sep 17 00:00:00 2001
From: Olivier Serres <oserres@google.com>
Date: Thu, 9 Nov 2023 14:50:07 -0800
Subject: [PATCH] test_builder: Add the tracing_interval option for the
 rectangular traffic pattern

Update golden configs
---
 test_builder/test_builder                              |  3 +++
 ...ial_5x3x100000x1024x1024-grpc_polling_inline.config |  2 ++
 ...rst_4x3x100000x1024x1024-grpc_polling_inline.config |  2 ++
 ...rst_5x2x100000x1024x1024-grpc_polling_inline.config |  2 ++
 ...st_5x3x1000000x1024x1024-grpc_polling_inline.config |  2 ++
 ..._burst_5x3x100000x1024x0-grpc_polling_inline.config |  2 ++
 ...rst_5x3x100000x1024x1024-grpc_polling_inline.config |  2 ++
 ...5x3x100000x1024x1024-grpc_polling_inline_tcp.config |  2 ++
 ...st_5x3x100000x16384x1024-grpc_polling_inline.config |  2 ++
 ...rst_5x2x100000x1024x1024-grpc_polling_inline.config |  2 ++
 ...rst_5x3x100000x1024x1024-grpc_polling_inline.config |  2 ++
 test_builder/test_builder_golden_configs/sweep4.config | 10 ++++++++++
 12 files changed, 33 insertions(+)

diff --git a/test_builder/test_builder b/test_builder/test_builder
index 04eddc4d..750b3f90 100755
--- a/test_builder/test_builder
+++ b/test_builder/test_builder
@@ -1155,6 +1155,7 @@ function rectangular_traffic_pattern_setup() {
   set_parameter_default request_size 1024
   set_parameter_default response_size 1024
   set_parameter_default fanout_filter ring_x
+  set_parameter_default tracing_interval 0
   local REQUEST_SIZE="${params_dict[request_size]}"
   local RESPONSE_SIZE="${params_dict[response_size]}"
   local RPC_INTERVAL_US="${params_dict[rpc_interval_us]}"
@@ -1162,6 +1163,7 @@ function rectangular_traffic_pattern_setup() {
   local Y_SIZE="${params_dict[y_size]}"
   local NODE_COUNT="$((X_SIZE * Y_SIZE))"
   local FANOUT_FILTER="${params_dict[fanout_filter]}"
+  local TRAFFIC_INTERVAL="${params_dict[tracing_interval]}"
   validate_integer 100 RPC_INTERVAL_US
   validate_integer 2 NODE_COUNT
   local SYNCHRONIZATION_MODE="${params_dict[synchronization_mode]}"
@@ -1208,6 +1210,7 @@ function rectangular_traffic_pattern_setup() {
     fanout_filter: '${FANOUT_FILTER}'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: ${TRAFFIC_INTERVAL}
   }
   action_lists {
     name: 'rectangular_query'
diff --git a/test_builder/test_builder_golden_configs/rectangular_ring_x_exponential_5x3x100000x1024x1024-grpc_polling_inline.config b/test_builder/test_builder_golden_configs/rectangular_ring_x_exponential_5x3x100000x1024x1024-grpc_polling_inline.config
index 51842b27..ec0ccd31 100644
--- a/test_builder/test_builder_golden_configs/rectangular_ring_x_exponential_5x3x100000x1024x1024-grpc_polling_inline.config
+++ b/test_builder/test_builder_golden_configs/rectangular_ring_x_exponential_5x3x100000x1024x1024-grpc_polling_inline.config
@@ -14,6 +14,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_ring_x_exponential_5x3x100000x1024x1024-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_ring_x_exponential_5x3x100000x1024x1024' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '5' }
@@ -66,6 +67,7 @@ tests {
     fanout_filter: 'ring_x'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
diff --git a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_4x3x100000x1024x1024-grpc_polling_inline.config b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_4x3x100000x1024x1024-grpc_polling_inline.config
index 7db7b9b7..e9bbbea3 100644
--- a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_4x3x100000x1024x1024-grpc_polling_inline.config
+++ b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_4x3x100000x1024x1024-grpc_polling_inline.config
@@ -14,6 +14,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_ring_x_sync_burst_4x3x100000x1024x1024-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_ring_x_sync_burst_4x3x100000x1024x1024' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '4' }
@@ -66,6 +67,7 @@ tests {
     fanout_filter: 'ring_x'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
diff --git a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x2x100000x1024x1024-grpc_polling_inline.config b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x2x100000x1024x1024-grpc_polling_inline.config
index 78f67401..848c1b5c 100644
--- a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x2x100000x1024x1024-grpc_polling_inline.config
+++ b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x2x100000x1024x1024-grpc_polling_inline.config
@@ -14,6 +14,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_ring_x_sync_burst_5x2x100000x1024x1024-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_ring_x_sync_burst_5x2x100000x1024x1024' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '5' }
@@ -66,6 +67,7 @@ tests {
     fanout_filter: 'ring_x'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
diff --git a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x1000000x1024x1024-grpc_polling_inline.config b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x1000000x1024x1024-grpc_polling_inline.config
index e3141c75..b4ddb112 100644
--- a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x1000000x1024x1024-grpc_polling_inline.config
+++ b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x1000000x1024x1024-grpc_polling_inline.config
@@ -14,6 +14,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_ring_x_sync_burst_5x3x1000000x1024x1024-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_ring_x_sync_burst_5x3x1000000x1024x1024' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '5' }
@@ -66,6 +67,7 @@ tests {
     fanout_filter: 'ring_x'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
diff --git a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x1024x0-grpc_polling_inline.config b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x1024x0-grpc_polling_inline.config
index c252474f..20a1dbee 100644
--- a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x1024x0-grpc_polling_inline.config
+++ b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x1024x0-grpc_polling_inline.config
@@ -14,6 +14,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_ring_x_sync_burst_5x3x100000x1024x0-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_ring_x_sync_burst_5x3x100000x1024x0' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '5' }
@@ -66,6 +67,7 @@ tests {
     fanout_filter: 'ring_x'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
diff --git a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x1024x1024-grpc_polling_inline.config b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x1024x1024-grpc_polling_inline.config
index c875648c..591ba020 100644
--- a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x1024x1024-grpc_polling_inline.config
+++ b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x1024x1024-grpc_polling_inline.config
@@ -14,6 +14,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_ring_x_sync_burst_5x3x100000x1024x1024-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_ring_x_sync_burst_5x3x100000x1024x1024' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '5' }
@@ -66,6 +67,7 @@ tests {
     fanout_filter: 'ring_x'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
diff --git a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x1024x1024-grpc_polling_inline_tcp.config b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x1024x1024-grpc_polling_inline_tcp.config
index e924bccd..62821d08 100644
--- a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x1024x1024-grpc_polling_inline_tcp.config
+++ b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x1024x1024-grpc_polling_inline_tcp.config
@@ -14,6 +14,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_ring_x_sync_burst_5x3x100000x1024x1024-grpc_polling_inline_tcp' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_ring_x_sync_burst_5x3x100000x1024x1024' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'transport' value: 'tcp' }
@@ -71,6 +72,7 @@ tests {
     fanout_filter: 'ring_x'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
diff --git a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x16384x1024-grpc_polling_inline.config b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x16384x1024-grpc_polling_inline.config
index 69539f98..8c6bf795 100644
--- a/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x16384x1024-grpc_polling_inline.config
+++ b/test_builder/test_builder_golden_configs/rectangular_ring_x_sync_burst_5x3x100000x16384x1024-grpc_polling_inline.config
@@ -14,6 +14,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_ring_x_sync_burst_5x3x100000x16384x1024-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_ring_x_sync_burst_5x3x100000x16384x1024' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '5' }
@@ -66,6 +67,7 @@ tests {
     fanout_filter: 'ring_x'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
diff --git a/test_builder/test_builder_golden_configs/rectangular_same_y_sync_burst_5x2x100000x1024x1024-grpc_polling_inline.config b/test_builder/test_builder_golden_configs/rectangular_same_y_sync_burst_5x2x100000x1024x1024-grpc_polling_inline.config
index 48426044..f8687a59 100644
--- a/test_builder/test_builder_golden_configs/rectangular_same_y_sync_burst_5x2x100000x1024x1024-grpc_polling_inline.config
+++ b/test_builder/test_builder_golden_configs/rectangular_same_y_sync_burst_5x2x100000x1024x1024-grpc_polling_inline.config
@@ -14,6 +14,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_same_y_sync_burst_5x2x100000x1024x1024-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_same_y_sync_burst_5x2x100000x1024x1024' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '5' }
@@ -66,6 +67,7 @@ tests {
     fanout_filter: 'same_y'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
diff --git a/test_builder/test_builder_golden_configs/rectangular_same_y_sync_burst_5x3x100000x1024x1024-grpc_polling_inline.config b/test_builder/test_builder_golden_configs/rectangular_same_y_sync_burst_5x3x100000x1024x1024-grpc_polling_inline.config
index bd389640..b09eeafe 100644
--- a/test_builder/test_builder_golden_configs/rectangular_same_y_sync_burst_5x3x100000x1024x1024-grpc_polling_inline.config
+++ b/test_builder/test_builder_golden_configs/rectangular_same_y_sync_burst_5x3x100000x1024x1024-grpc_polling_inline.config
@@ -14,6 +14,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_same_y_sync_burst_5x3x100000x1024x1024-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_same_y_sync_burst_5x3x100000x1024x1024' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '5' }
@@ -66,6 +67,7 @@ tests {
     fanout_filter: 'same_y'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
diff --git a/test_builder/test_builder_golden_configs/sweep4.config b/test_builder/test_builder_golden_configs/sweep4.config
index b6e92f85..6c5115a2 100644
--- a/test_builder/test_builder_golden_configs/sweep4.config
+++ b/test_builder/test_builder_golden_configs/sweep4.config
@@ -16,6 +16,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_ring_x_sync_burst_5x3x100000x1000x1000-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_ring_x_sync_burst_5x3x100000x1000x1000' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '5' }
@@ -68,6 +69,7 @@ tests {
     fanout_filter: 'ring_x'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
@@ -91,6 +93,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_ring_x_sync_burst_5x3x100000x2000x2000-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_ring_x_sync_burst_5x3x100000x2000x2000' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '5' }
@@ -143,6 +146,7 @@ tests {
     fanout_filter: 'ring_x'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
@@ -166,6 +170,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_ring_x_sync_burst_5x3x100000x3000x3000-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_ring_x_sync_burst_5x3x100000x3000x3000' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '5' }
@@ -218,6 +223,7 @@ tests {
     fanout_filter: 'ring_x'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
@@ -241,6 +247,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_ring_x_sync_burst_5x3x100000x4000x4000-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_ring_x_sync_burst_5x3x100000x4000x4000' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '5' }
@@ -293,6 +300,7 @@ tests {
     fanout_filter: 'ring_x'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'
@@ -316,6 +324,7 @@ tests {
   attributes: { key: 'test_name' value: 'rectangular_ring_x_sync_burst_5x3x100000x5000x5000-grpc_polling_inline' }
   attributes: { key: 'test_timeout' value: '150' }
   attributes: { key: 'threadpool_size' value: '0' }
+  attributes: { key: 'tracing_interval' value: '0' }
   attributes: { key: 'traffic_alias' value: 'rectangular_ring_x_sync_burst_5x3x100000x5000x5000' }
   attributes: { key: 'traffic_pattern' value: 'rectangular' }
   attributes: { key: 'x_size' value: '5' }
@@ -368,6 +377,7 @@ tests {
     fanout_filter: 'ring_x'
     request_payload_name: 'request_payload'
     response_payload_name: 'response_payload'
+    tracing_interval: 0
   }
   action_lists {
     name: 'rectangular_query'