Build fails on Windows and Linux

[formatc2013]

git clone https://github.com/google/bloaty.git --recursive
cd bloaty
cmake -B build -G Ninja -S . 
cmake --build build 
cmake --build build --target install

re.log

On Windows with similar commands:

[17/175] Building CXX object CMakeFiles/libbloaty.dir/src/bloaty.cc.obj
FAILED: [code=1] CMakeFiles/libbloaty.dir/src/bloaty.cc.obj
C:\msys64\mingw64\bin\c++.exe -DUSE_RE2 -D_LIBCXXABI_FUNC_VIS="" -IC:/bloaty/third_party/re2 -IC:/bloaty/third_party/capstone/include -IC:/bloaty/. -IC:/bloaty/src -IC:/bloaty/third_party/abseil-cpp -IC:/bloaty/build/src -IC:/bloaty/third_party/googletest/googletest/include -IC:/bloaty/third_party/googletest/googlemock/include -IC:/bloaty/third_party/protobuf/upb/reflection/cmake -isystem C:/bloaty/third_party/protobuf/src -isystem C:/bloaty/third_party/zlib -W -Wall -Wno-sign-compare -fdiagnostics-color=always -O2 -g1 -std=gnu++20 -MD -MT CMakeFiles/libbloaty.dir/src/bloaty.cc.obj -MF CMakeFiles\libbloaty.dir\src\bloaty.cc.obj.d -o CMakeFiles/libbloaty.dir/src/bloaty.cc.obj -c C:/bloaty/src/bloaty.cc
In file included from C:/bloaty/src/bloaty.cc:27:
C:/bloaty/third_party/zlib/zlib.h:1468:32: error: expected initializer before 'Z_ARG'
 1468 | ZEXTERN int ZEXPORTVA gzprintf Z_ARG((gzFile file, const char *format, ...));
      |                                ^~~~~
C:/bloaty/third_party/zlib/zlib.h:1902:44: error: expected initializer before 'Z_ARG'
 1902 | ZEXTERN int            ZEXPORTVA gzvprintf Z_ARG((gzFile file,

PS C:\bloaty> cmake --version
cmake version 3.29.2

[EricRahm]

@formatc2013 I think #388 might fix your issue (it's out of date and needs a rebase). If you're interested in trying that out it'd be helpful! If it fixes things we can prioritize getting it rebased and landed.

[formatc2013]

@formatc2013 I think #388 might fix your issue (it's out of date and needs a rebase). If you're interested in trying that out it'd be helpful! If it fixes things we can prioritize getting it rebased and landed.

I jumped to that branch on the fork (not sure if rebasing this to main would help?)
And on Windows and after deleting build folder:

FAILED: [code=1] third_party/zlib/libzlib.dll third_party/zlib/libzlib.dll.a
C:\WINDOWS\system32\cmd.exe /C "cd . && C:\msys64\mingw64\bin\cc.exe -O2 -g -DNDEBUG   -shared -o third_party\zlib\libzlib.dll -Wl,--out-implib,third_party\zlib\libzlib.dll.a -Wl,--major-image-version,1,--minor-image-version,2 third_party/zlib/zlib1rc.obj third_party/zlib/CMakeFiles/zlib.dir/adler32.obj third_party/zlib/CMakeFiles/zlib.dir/compress.obj third_party/zlib/CMakeFiles/zlib.dir/crc32.obj third_party/zlib/CMakeFiles/zlib.dir/deflate.obj third_party/zlib/CMakeFiles/zlib.dir/gzclose.obj third_party/zlib/CMakeFiles/zlib.dir/gzlib.obj third_party/zlib/CMakeFiles/zlib.dir/gzread.obj third_party/zlib/CMakeFiles/zlib.dir/gzwrite.obj third_party/zlib/CMakeFiles/zlib.dir/inflate.obj third_party/zlib/CMakeFiles/zlib.dir/infback.obj third_party/zlib/CMakeFiles/zlib.dir/inftrees.obj third_party/zlib/CMakeFiles/zlib.dir/inffast.obj third_party/zlib/CMakeFiles/zlib.dir/trees.obj third_party/zlib/CMakeFiles/zlib.dir/uncompr.obj third_party/zlib/CMakeFiles/zlib.dir/zutil.obj  -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut32 -luuid -lcomdlg32 -ladvapi32 && cd ."
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/14.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: i386 architecture of input file `third_party/zlib/zlib1rc.obj' is incompatible with i386:x86-64 output
collect2.exe: error: ld returned 1 exit status
[554/602] Building CXX object third_party/abseil-cpp/absl/flags/CMakeFiles/absl_flags_parse.dir/parse.cc.obj
ninja: build stopped: subcommand failed.

Linux has an issue with re2, afaik as before

Yesterday I got a similar error, in the main repo/branch, on my first attempt.
I navigated to zlib folder and

S C:\bloaty\third_party\zlib> gst
HEAD detached at cacf7f1
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        deleted:    zconf.h

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        zconf.h.included

[EricRahm]

@formatc2013 I repro'd your issue on Linux, drafted up #432 which seems to build for me. I don't have mingw setup, if you want to try that out I'd appreciate it! You'll need to make sure you're starting with a clean build directory (rm -rf build/) when testing.

[EricRahm]

My landing closed this. @formatc2013 if you have some time, confirming it would be helpful, no worries if not. Thanks again for the report and help testing!

[formatc2013]

git clone https://github.com/google/bloaty.git --recursive
cd bloaty
cmake -B build -G Ninja -S . 
cmake --build build 
cmake --build build --target install

re.log

On Windows with similar commands:

[17/175] Building CXX object CMakeFiles/libbloaty.dir/src/bloaty.cc.obj
FAILED: [code=1] CMakeFiles/libbloaty.dir/src/bloaty.cc.obj
C:\msys64\mingw64\bin\c++.exe -DUSE_RE2 -D_LIBCXXABI_FUNC_VIS="" -IC:/bloaty/third_party/re2 -IC:/bloaty/third_party/capstone/include -IC:/bloaty/. -IC:/bloaty/src -IC:/bloaty/third_party/abseil-cpp -IC:/bloaty/build/src -IC:/bloaty/third_party/googletest/googletest/include -IC:/bloaty/third_party/googletest/googlemock/include -IC:/bloaty/third_party/protobuf/upb/reflection/cmake -isystem C:/bloaty/third_party/protobuf/src -isystem C:/bloaty/third_party/zlib -W -Wall -Wno-sign-compare -fdiagnostics-color=always -O2 -g1 -std=gnu++20 -MD -MT CMakeFiles/libbloaty.dir/src/bloaty.cc.obj -MF CMakeFiles\libbloaty.dir\src\bloaty.cc.obj.d -o CMakeFiles/libbloaty.dir/src/bloaty.cc.obj -c C:/bloaty/src/bloaty.cc
In file included from C:/bloaty/src/bloaty.cc:27:
C:/bloaty/third_party/zlib/zlib.h:1468:32: error: expected initializer before 'Z_ARG'
 1468 | ZEXTERN int ZEXPORTVA gzprintf Z_ARG((gzFile file, const char *format, ...));
      |                                ^~~~~
C:/bloaty/third_party/zlib/zlib.h:1902:44: error: expected initializer before 'Z_ARG'
 1902 | ZEXTERN int            ZEXPORTVA gzvprintf Z_ARG((gzFile file,

PS C:\bloaty> cmake --version
cmake version 3.29.2

I checked out main and ran a clean build, and got the same errors as in re.log.
Switched off RE2 build in the main CMakeLists and than it built successfully.

The zlib issue I only had on Win MinGW.

Let me know if you have any questions

[EricRahm]

Lets re-open this, I can take another look later this week.

For the re2 issue I think the key line from your log is:

[4/569] Building CXX object third_party/re2/CMakeFiles/re2.dir/re2/mimics_pcre.cc.o
FAILED: third_party/re2/CMakeFiles/re2.dir/re2/mimics_pcre.cc.o
/usr/bin/c++ -DUSE_RE2 -D_LIBCXXABI_FUNC_VIS="" -I/home/domb/Documents/bloaty/third_party/re2 -O2 -g -DNDEBUG -std=c++11 -pthread -std=gnu++20 -MD -MT third_party/re2/CMakeFiles/re2.dir/re2/mimics_pcre.cc.o -MF third_party/re2/CMakeFiles/re2.dir/re2/mimics_pcre.cc.o.d -o third_party/re2/CMakeFiles/re2.dir/re2/mimics_pcre.cc.o -c /home/domb/Documents/bloaty/third_party/re2/re2/mimics_pcre.cc
In file included from /home/domb/Documents/bloaty/third_party/re2/re2/mimics_pcre.cc:28:
/home/domb/Documents/bloaty/third_party/re2/re2/walker-inl.h:122:22: error: expected ‘)’ before ‘*’ token
  122 |   WalkState<T>(Regexp* re, T parent)
      |               ~      ^
      |                      )

What I'm seeing is re2 wants to use c++11, we're overriding that with gnu++20. Hacking things up on a linux build I can reproduce (although I just get a warning, but the warning is more helpful):

[466/855] Building CXX object third_party/re2/CMakeFiles/re2.dir/re2/mimics_pcre.cc.o
In file included from /usr/local/google/home/erahm/bloaty/third_party/re2/re2/mimics_pcre.cc:28:
/usr/local/google/home/erahm/bloaty/third_party/re2/re2/walker-inl.h:122:16: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
  122 |   WalkState<T>(Regexp* re, T parent)
      |                ^~~~~~
/usr/local/google/home/erahm/bloaty/third_party/re2/re2/walker-inl.h:122:16: note: remove the ‘< >’

A few options:

• Roll back to c++17 for unix-like builds (we upgraded to C++20 to fix Windows/msvc builds)
• Update our version of re2, it looks like this might be fixed upstream

As noted a workaround is to set BLOATY_ENABLE_RE2=OFF.

[formatc2013]

Is setting up the build process and all the dependencies in a Docker image a reasonable option?

[EricRahm]

Is setting up the build process and all the dependencies in a Docker image a reasonable option?

We could definitely consider adding a docker builder. I seem to recall an issue / PR that may have started that work so it might be worth digging through the backlog. If you want to file a follow up and / or a PR I'd be happy to work with you on it!